search

microsoft / fluentui-system-icons

Fluent System Icons are a collection of familiar, friendly and modern icons from Microsoft.
https://aka.ms/fluentui-system-icons
MIT License
5.9k stars 518 forks source link

Filled prop type expected to be string #518

Closed natle01 closed 1 year ago

natle01 commented 1 year ago

Passing in a boolean value for the "filled" prop produces an error as it is expecting a string. Although the "filled" prop takes a boolean value, once you render it in the DOM you get an error that it should be a string.

Using version: 2.0.178

Typescipt: image

Console: image

tomi-msft commented 1 year ago

Hi @natle01, thanks for filing the issue! It looks like this is due to the filled prop being passed incorrectly as an svg prop in the bundleIcon utility. #523 should fix the issue

natle01 commented 1 year ago

Great, confirmed it's fixed. Thanks for the quick push