search

microsoft / fluentui-system-icons

Fluent System Icons are a collection of familiar, friendly and modern icons from Microsoft.
https://aka.ms/fluentui-system-icons
MIT License
5.68k stars 501 forks source link

Move react-native-svg from dependencies to peerDependencies #578

Closed verluci closed 1 year ago

verluci commented 1 year ago

React-native-svg is notorious for breaking things when there's multiple versions of the package installed. It's also very frequently required for packages. Listing it as a peerDependency prevents these issues. Other libraries from the Fluentui stack follow this approach as well, for example https://github.com/microsoft/fluentui-react-native/blob/main/packages/components/Icon/package.json

verluci commented 1 year ago

@microsoft-github-policy-service agree

verluci commented 1 year ago

Would you mind taking a look at this pr, @nickromano or @willhou?

nickromano commented 1 year ago

Hey @warren-ms can you please take a look?