search

microsoft / fluentui-system-icons

Fluent System Icons are a collection of familiar, friendly and modern icons from Microsoft.
https://aka.ms/fluentui-system-icons
MIT License
5.93k stars 517 forks source link

Keep the target in the 'tsconfig.json' file consistent with Fluent UI #594

Closed liuxuan1-1 closed 1 year ago

liuxuan1-1 commented 1 year ago

The purpose of this PR is to fix this issue, which is caused by the use of the nullish coalescing operator (??) leading to a webpack build error. It is suggested to keep the 'target' in the 'tsconfig.json' file consistent with Fluent UI's at https://github.com/microsoft/fluentui/blob/master/tsconfig.base.json.

liuxuan1-1 commented 1 year ago

Hi @tomi-msft @spencer-nelson , could you please help review this?

liuxuan1-1 commented 1 year ago

Hi @tomi-msft @spencer-nelson, @jasoncuster, @nickromano, could you please help review this PR?

liuxuan1-1 commented 1 year ago

Hi @tomi-msft @spencer-nelson, @jasoncuster, @nickromano, @MLoughry, @williamch-ms, could you please help review this PR?