search

microsoft / fluentui-system-icons

Fluent System Icons are a collection of familiar, friendly and modern icons from Microsoft.
https://aka.ms/fluentui-system-icons
MIT License
5.64k stars 497 forks source link

Font subsetting plugin bug #684

Closed ColeStansbury closed 4 weeks ago

ColeStansbury commented 5 months ago

There appears to be a number of icons which are not rendering correctly when using the webpack subsetting plugin.

With plugin:

image

Without plugin:

image

Examples include LineHorizontal416Filled LineHorizontal320Filled MoreVertical16Filled MoreHorizontal16Filled

... and others

tomi-msft commented 3 months ago

Hi @ColeStansbury. This occurs because the plugin is trying to maintain the styles present in the svg icons by using style injection into the styles prop of the font icons. This has been fixed in the most recent version.

ColeStansbury commented 4 weeks ago

Thanks! I don't see this problem in 2.0.242 anymore

the subset plugin remains volatile though - see #723