microsoft / fluentui-system-icons

Fluent System Icons are a collection of familiar, friendly and modern icons from Microsoft.
https://aka.ms/fluentui-system-icons
MIT License
5.64k stars 497 forks source link

[BUG] subsetting-webpack-plugin fails with nested node_modules #723

Open ColeStansbury opened 4 weeks ago

ColeStansbury commented 4 weeks ago

The subsetting plugin is not designed to support nested fluent icon modules but webpack will still try to apply the plugin to them. You should either update the plugin docs to make sure webpack doesn't compile nested react-icons or add support for them.

My fix is as follows:

      modules: [
        // TODO - you should be able to have nested modules!
        path.resolve(__dirname, 'node_modules'),
      ],

(Still working on a fix that allows me to nest other packages' node_modules and just exclude react icons)