search

microsoft / fluentui-token-pipeline

The Fluent UI token pipeline generates source code for Fluent UI libraries.
https://microsoft.github.io/fluentui-token-pipeline/
Other
41 stars 18 forks source link

Token pipeline output "ERROR: Unable to determine data type based on token name "Global.Size.20" #71

Closed lyzhan7 closed 1 year ago

lyzhan7 commented 1 year ago

Output from running npx transform-tokens --platform reactnative --in src/global.ios.json --in src/typography.ios.json --in src/light.ios.json --in src/shadow.json --out tokens/reactnative/ios/light:

lynns-macbook-pro:fluentui-design-tokens lyzhan$ npx transform-tokens --platform reactnative --in src/global.ios.json --in src/typography.ios.json --in src/light.ios.json --in src/shadow.json --out tokens/reactnative/ios/light

reactnative
ERROR: Unable to determine data type based on token name "Global.Size.20".
ERROR: Unable to determine data type based on token name "Global.Size.40".
ERROR: Unable to determine data type based on token name "Global.Size.60".
ERROR: Unable to determine data type based on token name "Global.Size.80".
ERROR: Unable to determine data type based on token name "Global.Size.100".
ERROR: Unable to determine data type based on token name "Global.Size.120".
ERROR: Unable to determine data type based on token name "Global.Size.160".
ERROR: Unable to determine data type based on token name "Global.Size.200".
ERROR: Unable to determine data type based on token name "Global.Size.240".
ERROR: Unable to determine data type based on token name "Global.Size.280".
ERROR: Unable to determine data type based on token name "Global.Size.320".
ERROR: Unable to determine data type based on token name "Global.Size.360".
ERROR: Unable to determine data type based on token name "Global.Size.400".
ERROR: Unable to determine data type based on token name "Global.Size.480".
ERROR: Unable to determine data type based on token name "Global.Size.560".
ERROR: Unable to determine data type based on token name "Global.Size.640".
ERROR: Unable to determine data type based on token name "Global.Size.720".
ERROR: Unable to determine data type based on token name "Global.Size.800".
ERROR: Unable to determine data type based on token name "Global.Size.1200".
ERROR: Unable to determine data type based on token name "Global.Size.None".
✔︎  tokens/reactnative/ios/light/tokens-global.json
✔︎  tokens/reactnative/ios/light/tokens-shadow.json
✔︎  tokens/reactnative/ios/light/tokens-aliases.json
✔︎  tokens/reactnative/ios/light/tokens-controls.json

This is on the latest token package version 0.37.0, but issue was introduced by https://github.com/microsoft/fluentui-design-tokens/pull/36 when we renamed "Spacing" to "Size". Seems like some of the error handling needs to be updated

TravisSpomer commented 1 year ago

This should have been fixed with 54eff8ef434c55b3b2367cd0fc14f7bbc80c4298, which is in tool version 0.15.0 from November 17. I'm not an NPM expert and I don't know the best way to make sure npx picks up the latest version of the tool though. 😕