Closed micahgodbolt closed 4 years ago
Project | Bundle | Baseline Size | New Size | Difference |
---|---|---|---|---|
office-ui-fabric-react | Grid | 167.204 kB | 167.241 kB | 37 bytes |
office-ui-fabric-react | Nav | 174.72 kB | 174.757 kB | 37 bytes |
office-ui-fabric-react | ComboBox | 229.238 kB | 229.275 kB | 37 bytes |
office-ui-fabric-react | Pivot | 172.389 kB | 172.426 kB | 37 bytes |
office-ui-fabric-react | Pickers | 268.611 kB | 268.648 kB | 37 bytes |
office-ui-fabric-react | PersonaPresence | 53.203 kB | 53.24 kB | 37 bytes |
office-ui-fabric-react | PersonaCoin | 108.364 kB | 108.401 kB | 37 bytes |
office-ui-fabric-react | Persona | 108.364 kB | 108.401 kB | 37 bytes |
office-ui-fabric-react | Panel | 185.842 kB | 185.879 kB | 37 bytes |
office-ui-fabric-react | ContextualMenu | 144.749 kB | 144.786 kB | 37 bytes |
office-ui-fabric-react | DatePicker | 195.759 kB | 195.796 kB | 37 bytes |
office-ui-fabric-react | Modal | 89.258 kB | 89.295 kB | 37 bytes |
office-ui-fabric-react | Rating | 70.505 kB | 70.542 kB | 37 bytes |
office-ui-fabric-react | MessageBar | 175.683 kB | 175.72 kB | 37 bytes |
office-ui-fabric-react | DetailsList | 207.673 kB | 207.71 kB | 37 bytes |
office-ui-fabric-react | Dialog | 194.323 kB | 194.36 kB | 37 bytes |
office-ui-fabric-react | DocumentCard | 201.043 kB | 201.08 kB | 37 bytes |
office-ui-fabric-react | Dropdown | 217.272 kB | 217.309 kB | 37 bytes |
office-ui-fabric-react | Facepile | 196.181 kB | 196.218 kB | 37 bytes |
office-ui-fabric-react | FloatingPicker | 225.776 kB | 225.813 kB | 37 bytes |
office-ui-fabric-react | Icon | 46.848 kB | 46.885 kB | 37 bytes |
office-ui-fabric-react | GroupedList | 115.777 kB | 115.814 kB | 37 bytes |
office-ui-fabric-react | ColorPicker | 84.557 kB | 84.594 kB | 37 bytes |
office-ui-fabric-react | CommandBar | 187.11 kB | 187.147 kB | 37 bytes |
office-ui-fabric-react | Breadcrumb | 184.816 kB | 184.853 kB | 37 bytes |
office-ui-fabric-react | ShimmeredDetailsList | 218.172 kB | 218.209 kB | 37 bytes |
office-ui-fabric-react | TeachingBubble | 190.712 kB | 190.749 kB | 37 bytes |
office-ui-fabric-react | SwatchColorPicker | 177.59 kB | 177.627 kB | 37 bytes |
office-ui-fabric-react | Styling | 41.021 kB | 41.058 kB | 37 bytes |
office-ui-fabric-react | Button | 179.711 kB | 179.748 kB | 37 bytes |
office-ui-fabric-react | Calendar | 133.758 kB | 133.795 kB | 37 bytes |
office-ui-fabric-react | SpinButton | 179.433 kB | 179.47 kB | 37 bytes |
office-ui-fabric-react | TextField | 72.51 kB | 72.547 kB | 37 bytes |
office-ui-fabric-react | Check | 48.11 kB | 48.147 kB | 37 bytes |
office-ui-fabric-react | Checkbox | 62.168 kB | 62.205 kB | 37 bytes |
office-ui-fabric-react | ChoiceGroup | 58.908 kB | 58.945 kB | 37 bytes |
office-ui-fabric-react | SelectedItemsList | 215.128 kB | 215.165 kB | 37 bytes |
office-ui-fabric-react | ChoiceGroupOption | 54.511 kB | 54.548 kB | 37 bytes |
office-ui-fabric-react | SearchBox | 173.371 kB | 173.408 kB | 37 bytes |
office-ui-fabric-react | ActivityItem | 66.047 kB | 66.084 kB | 37 bytes |
Over Tolerance (1024 B) Over Baseline Below Baseline New Removed 1 kB = 1000 B
Baseline commit: 07f9780fe1a3b180a86004c14788e581f59b1ab7 (build)
@micahgodbolt FYI your build will continue to fail until #12378 is merged, sorry :(
Curious, are Size Auditor's results accurate? I wasn't expecting to see an increase.
Curious, are Size Auditor's results accurate? I wasn't expecting to see an increase.
Why would it increase? This is just changing some text.
(EDIT: I see what you mean--since the increase is just a few bytes, it could be due to small changes like "Fluent UI" being slightly longer than "Fabric", or possibly some measurement inaccuracy).
now if people could only stop changing stuff in the website...that'd be greeeeeeeeeeeaaaaaaaaaaaaaaaaaaat :D
No significant results to display.
Scenario | Master Ticks | PR Ticks | Status |
---|---|---|---|
BaseButton | 772 | 804 | |
BaseButton (experiments) | 946 | 941 | |
DefaultButton | 1008 | 1040 | |
DefaultButton (experiments) | 1837 | 1839 | |
DetailsRow | 3227 | 3377 | |
DetailsRow (fast icons) | 3213 | 3255 | |
DetailsRow without styles | 3071 | 3169 | |
DocumentCardTitle with truncation | 1485 | 1496 | |
MenuButton | 1380 | 1381 | |
MenuButton (experiments) | 3421 | 3429 | |
PrimaryButton | 1163 | 1154 | |
PrimaryButton (experiments) | 1833 | 1931 | |
SplitButton | 2925 | 2986 | |
SplitButton (experiments) | 6855 | 6618 | |
Stack | 467 | 459 | |
Stack with Intrinsic children | 1060 | 1071 | |
Stack with Text children | 4133 | 4073 | |
Text | 364 | 370 | |
Toggle | 842 | 839 | |
Toggle (experiments) | 2146 | 2120 | |
button | 62 | 61 |
@ecraig12345 thanks for getting those conflicts resolved! I went through and addressed your questions and suggesstions.
running yarn change locally doesn't show any new change files
Hello @micahgodbolt!
Because this pull request has the AutoMerge
label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.
@msft-github-bot
) and give me an instruction to get started! Learn more here.@ecraig12345 @paulgildea i've reviewed all feedback. Is this close to ready?
More issues (apologies for the giant screenshots):
Failing due to size auditor, which seems a false positive.
Size auditor is broken right now.
@ecraig12345 what's the chance of merging this in soon? website deploy is currently off, so we dont' risk errors/missing items going live
I just pushed one more update to the licenses, so after that it looks good for now. I'll keep reading through the site too.
:tada:@uifabric/webpack-utils@v7.0.11
has been released which incorporates this pull request.:tada:
Handy links:
:tada:@uifabric/variants@v7.1.34
has been released which incorporates this pull request.:tada:
Handy links:
:tada:@uifabric/theme-samples@v7.0.44
has been released which incorporates this pull request.:tada:
Handy links:
:tada:@uifabric/tslint-rules@v7.1.2
has been released which incorporates this pull request.:tada:
Handy links:
:tada:@uifabric/jest-serializer-merge-styles@v7.0.15
has been released which incorporates this pull request.:tada:
Handy links:
:tada:@uifabric/file-type-icons@v7.2.26
has been released which incorporates this pull request.:tada:
Handy links:
:tada:@uifabric/styling@v7.11.0
has been released which incorporates this pull request.:tada:
Handy links:
:tada:@uifabric/utilities@v7.15.3
has been released which incorporates this pull request.:tada:
Handy links:
:tada:@uifabric/test-utilities@v7.0.15
has been released which incorporates this pull request.:tada:
Handy links:
:tada:@uifabric/react-cards@v0.109.45
has been released which incorporates this pull request.:tada:
Handy links:
:tada:@uifabric/icons@v7.3.22
has been released which incorporates this pull request.:tada:
Handy links:
:tada:@uifabric/tsx-editor@v0.11.41
has been released which incorporates this pull request.:tada:
Handy links:
:tada:@uifabric/set-version@v7.0.9
has been released which incorporates this pull request.:tada:
Handy links:
:tada:@uifabric/pr-deploy-site@v7.0.44
has been released which incorporates this pull request.:tada:
Handy links:
:tada:@uifabric/foundation-scenarios@v0.102.48
has been released which incorporates this pull request.:tada:
Handy links:
:tada:@uifabric/azure-themes@v7.0.50
has been released which incorporates this pull request.:tada:
Handy links:
:tada:office-ui-fabric-react@v7.105.3
has been released which incorporates this pull request.:tada:
Handy links:
:tada:@uifabric/react-hooks@v7.0.24
has been released which incorporates this pull request.:tada:
Handy links:
:tada:@uifabric/monaco-editor@v0.5.5
has been released which incorporates this pull request.:tada:
Handy links:
:tada:@uifabric/fluent-theme@v7.1.43
has been released which incorporates this pull request.:tada:
Handy links:
:tada:@uifabric/api-docs@v7.2.40
has been released which incorporates this pull request.:tada:
Handy links:
:tada:@uifabric/migration@v7.0.14
has been released which incorporates this pull request.:tada:
Handy links:
:tada:@uifabric/merge-styles@v7.8.10
has been released which incorporates this pull request.:tada:
Handy links:
:tada:@uifabric/example-data@v7.0.9
has been released which incorporates this pull request.:tada:
Handy links:
:tada:@fluentui/react@v7.105.4
has been released which incorporates this pull request.:tada:
Handy links:
:tada:@uifabric/foundation@v7.5.23
has been released which incorporates this pull request.:tada:
Handy links:
:tada:@uifabric/date-time@v7.8.45
has been released which incorporates this pull request.:tada:
Handy links:
:tada:@uifabric/charting@v1.0.0
has been released which incorporates this pull request.:tada:
Handy links:
:tada:@fluentui/react-focus@v7.1.10
has been released which incorporates this pull request.:tada:
Handy links:
:tada:@uifabric/experiments@v7.22.8
has been released which incorporates this pull request.:tada:
Handy links:
:tada:@uifabric/example-app-base@v7.12.24
has been released which incorporates this pull request.:tada:
Handy links:
:tada:@fluentui/react-compose@v0.2.3
has been released which incorporates this pull request.:tada:
Handy links:
:tada:@fluentui/keyboard-key@v0.1.4
has been released which incorporates this pull request.:tada:
Handy links:
:tada:@fluentui/examples@v0.1.21
has been released which incorporates this pull request.:tada:
Handy links:
:tada:@uifabric/mdl2-theme@v0.1.44
has been released which incorporates this pull request.:tada:
Handy links:
Microsoft Reviewers: Open in CodeFlow