microsoft / fluentui

Fluent UI web represents a collection of utilities, React components, and web components for building web applications.
https://react.fluentui.dev
Other
17.87k stars 2.66k forks source link

Update Fabric website to "Fluent" #12366

Closed micahgodbolt closed 4 years ago

micahgodbolt commented 4 years ago
Microsoft Reviewers: Open in CodeFlow
size-auditor[bot] commented 4 years ago

Asset size changes

Project Bundle Baseline Size New Size Difference
office-ui-fabric-react Grid 167.204 kB 167.241 kB ExceedsBaseline     37 bytes
office-ui-fabric-react Nav 174.72 kB 174.757 kB ExceedsBaseline     37 bytes
office-ui-fabric-react ComboBox 229.238 kB 229.275 kB ExceedsBaseline     37 bytes
office-ui-fabric-react Pivot 172.389 kB 172.426 kB ExceedsBaseline     37 bytes
office-ui-fabric-react Pickers 268.611 kB 268.648 kB ExceedsBaseline     37 bytes
office-ui-fabric-react PersonaPresence 53.203 kB 53.24 kB ExceedsBaseline     37 bytes
office-ui-fabric-react PersonaCoin 108.364 kB 108.401 kB ExceedsBaseline     37 bytes
office-ui-fabric-react Persona 108.364 kB 108.401 kB ExceedsBaseline     37 bytes
office-ui-fabric-react Panel 185.842 kB 185.879 kB ExceedsBaseline     37 bytes
office-ui-fabric-react ContextualMenu 144.749 kB 144.786 kB ExceedsBaseline     37 bytes
office-ui-fabric-react DatePicker 195.759 kB 195.796 kB ExceedsBaseline     37 bytes
office-ui-fabric-react Modal 89.258 kB 89.295 kB ExceedsBaseline     37 bytes
office-ui-fabric-react Rating 70.505 kB 70.542 kB ExceedsBaseline     37 bytes
office-ui-fabric-react MessageBar 175.683 kB 175.72 kB ExceedsBaseline     37 bytes
office-ui-fabric-react DetailsList 207.673 kB 207.71 kB ExceedsBaseline     37 bytes
office-ui-fabric-react Dialog 194.323 kB 194.36 kB ExceedsBaseline     37 bytes
office-ui-fabric-react DocumentCard 201.043 kB 201.08 kB ExceedsBaseline     37 bytes
office-ui-fabric-react Dropdown 217.272 kB 217.309 kB ExceedsBaseline     37 bytes
office-ui-fabric-react Facepile 196.181 kB 196.218 kB ExceedsBaseline     37 bytes
office-ui-fabric-react FloatingPicker 225.776 kB 225.813 kB ExceedsBaseline     37 bytes
office-ui-fabric-react Icon 46.848 kB 46.885 kB ExceedsBaseline     37 bytes
office-ui-fabric-react GroupedList 115.777 kB 115.814 kB ExceedsBaseline     37 bytes
office-ui-fabric-react ColorPicker 84.557 kB 84.594 kB ExceedsBaseline     37 bytes
office-ui-fabric-react CommandBar 187.11 kB 187.147 kB ExceedsBaseline     37 bytes
office-ui-fabric-react Breadcrumb 184.816 kB 184.853 kB ExceedsBaseline     37 bytes
office-ui-fabric-react ShimmeredDetailsList 218.172 kB 218.209 kB ExceedsBaseline     37 bytes
office-ui-fabric-react TeachingBubble 190.712 kB 190.749 kB ExceedsBaseline     37 bytes
office-ui-fabric-react SwatchColorPicker 177.59 kB 177.627 kB ExceedsBaseline     37 bytes
office-ui-fabric-react Styling 41.021 kB 41.058 kB ExceedsBaseline     37 bytes
office-ui-fabric-react Button 179.711 kB 179.748 kB ExceedsBaseline     37 bytes
office-ui-fabric-react Calendar 133.758 kB 133.795 kB ExceedsBaseline     37 bytes
office-ui-fabric-react SpinButton 179.433 kB 179.47 kB ExceedsBaseline     37 bytes
office-ui-fabric-react TextField 72.51 kB 72.547 kB ExceedsBaseline     37 bytes
office-ui-fabric-react Check 48.11 kB 48.147 kB ExceedsBaseline     37 bytes
office-ui-fabric-react Checkbox 62.168 kB 62.205 kB ExceedsBaseline     37 bytes
office-ui-fabric-react ChoiceGroup 58.908 kB 58.945 kB ExceedsBaseline     37 bytes
office-ui-fabric-react SelectedItemsList 215.128 kB 215.165 kB ExceedsBaseline     37 bytes
office-ui-fabric-react ChoiceGroupOption 54.511 kB 54.548 kB ExceedsBaseline     37 bytes
office-ui-fabric-react SearchBox 173.371 kB 173.408 kB ExceedsBaseline     37 bytes
office-ui-fabric-react ActivityItem 66.047 kB 66.084 kB ExceedsBaseline     37 bytes

ExceedsTolerance Over Tolerance (1024 B) ExceedsBaseline Over Baseline BelowBaseline Below Baseline New New Deleted  Removed 1 kB = 1000 B

Baseline commit: 07f9780fe1a3b180a86004c14788e581f59b1ab7 (build)

ecraig12345 commented 4 years ago

@micahgodbolt FYI your build will continue to fail until #12378 is merged, sorry :(

KevinTCoughlin commented 4 years ago

Curious, are Size Auditor's results accurate? I wasn't expecting to see an increase.

ecraig12345 commented 4 years ago

Curious, are Size Auditor's results accurate? I wasn't expecting to see an increase.

Why would it increase? This is just changing some text.

(EDIT: I see what you mean--since the increase is just a few bytes, it could be due to small changes like "Fluent UI" being slightly longer than "Fabric", or possibly some measurement inaccuracy).

micahgodbolt commented 4 years ago

now if people could only stop changing stuff in the website...that'd be greeeeeeeeeeeaaaaaaaaaaaaaaaaaaat :D

msft-github-bot commented 4 years ago

Perf Analysis

No significant results to display.

All results

Scenario Master Ticks PR Ticks Status
BaseButton 772 804
BaseButton (experiments) 946 941
DefaultButton 1008 1040
DefaultButton (experiments) 1837 1839
DetailsRow 3227 3377
DetailsRow (fast icons) 3213 3255
DetailsRow without styles 3071 3169
DocumentCardTitle with truncation 1485 1496
MenuButton 1380 1381
MenuButton (experiments) 3421 3429
PrimaryButton 1163 1154
PrimaryButton (experiments) 1833 1931
SplitButton 2925 2986
SplitButton (experiments) 6855 6618
Stack 467 459
Stack with Intrinsic children 1060 1071
Stack with Text children 4133 4073
Text 364 370
Toggle 842 839
Toggle (experiments) 2146 2120
button 62 61

## Perf Analysis (Fluent)
Perf comparison Status | Scenario | Fluent TPI | Fabric TPI | Ratio | Iterations | Ticks :---: | :--- | ---:| ---:| ---:| ---:| ---: 🔧 | Avatar.Fluent | [0.55](http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/12366/merge/perf-test/fluentui/Avatar.Fluent.html) | 0.48 | 1.15:1 | 2000 | 1103 🦄 | Button.Fluent | [0.1](http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/12366/merge/perf-test/fluentui/Button.Fluent.html) | 0.19 | 0.53:1 | 5000 | 502 🔧 | Checkbox.Fluent | [0.7](http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/12366/merge/perf-test/fluentui/Checkbox.Fluent.html) | 0.41 | 1.71:1 | 1000 | 701 🔧 | Dialog.Fluent | [0.41](http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/12366/merge/perf-test/fluentui/Dialog.Fluent.html) | 0.2 | 2.05:1 | 5000 | 2061 🔧 | Dropdown.Fluent | [3.52](http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/12366/merge/perf-test/fluentui/Dropdown.Fluent.html) | 0.49 | 7.18:1 | 1000 | 3520 🔧 | Icon.Fluent | [0.18](http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/12366/merge/perf-test/fluentui/Icon.Fluent.html) | 0.05 | 3.6:1 | 5000 | 909 🎯 | Image.Fluent | [0.07](http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/12366/merge/perf-test/fluentui/Image.Fluent.html) | 0.1 | 0.7:1 | 5000 | 365 🔧 | Slider.Fluent | [1.53](http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/12366/merge/perf-test/fluentui/Slider.Fluent.html) | 0.43 | 3.56:1 | 1000 | 1533 🔧 | Text.Fluent | [0.08](http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/12366/merge/perf-test/fluentui/Text.Fluent.html) | 0.02 | 4:1 | 5000 | 420 🦄 | Tooltip.Fluent | [0.13](http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/12366/merge/perf-test/fluentui/Tooltip.Fluent.html) | 14.72 | 0.01:1 | 5000 | 636 >🔧 Needs work     🎯 On target     🦄 Amazing
Perf tests with no regressions Scenario | Current PR Ticks | Baseline Ticks | Ratio :--- | ---:| ---:| ---: TreeWith60ListItems.default | [242](http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/12366/merge/perf-test/fluentui/TreeWith60ListItems.default.html) | [217](http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/12366/merge/perf-test/fluentui/TreeWith60ListItems.default_base.html) | 1.12:1 FlexMinimalPerf.default | [313](http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/12366/merge/perf-test/fluentui/FlexMinimalPerf.default.html) | [291](http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/12366/merge/perf-test/fluentui/FlexMinimalPerf.default_base.html) | 1.08:1 LabelMinimalPerf.default | [414](http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/12366/merge/perf-test/fluentui/LabelMinimalPerf.default.html) | [383](http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/12366/merge/perf-test/fluentui/LabelMinimalPerf.default_base.html) | 1.08:1 PopupMinimalPerf.default | [262](http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/12366/merge/perf-test/fluentui/PopupMinimalPerf.default.html) | [246](http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/12366/merge/perf-test/fluentui/PopupMinimalPerf.default_base.html) | 1.07:1 RefMinimalPerf.default | [203](http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/12366/merge/perf-test/fluentui/RefMinimalPerf.default.html) | [189](http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/12366/merge/perf-test/fluentui/RefMinimalPerf.default_base.html) | 1.07:1 CustomToolbarPrototype.default | [3792](http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/12366/merge/perf-test/fluentui/CustomToolbarPrototype.default.html) | [3591](http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/12366/merge/perf-test/fluentui/CustomToolbarPrototype.default_base.html) | 1.06:1 Text.Fluent | [420](http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/12366/merge/perf-test/fluentui/Text.Fluent.html) | [397](http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/12366/merge/perf-test/fluentui/Text.Fluent_base.html) | 1.06:1 BoxMinimalPerf.default | [414](http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/12366/merge/perf-test/fluentui/BoxMinimalPerf.default.html) | [395](http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/12366/merge/perf-test/fluentui/BoxMinimalPerf.default_base.html) | 1.05:1 HeaderSlotsPerf.default | [1910](http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/12366/merge/perf-test/fluentui/HeaderSlotsPerf.default.html) | [1826](http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/12366/merge/perf-test/fluentui/HeaderSlotsPerf.default_base.html) | 1.05:1 LoaderMinimalPerf.default | [1103](http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/12366/merge/perf-test/fluentui/LoaderMinimalPerf.default.html) | [1054](http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/12366/merge/perf-test/fluentui/LoaderMinimalPerf.default_base.html) | 1.05:1 PortalMinimalPerf.default | [314](http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/12366/merge/perf-test/fluentui/PortalMinimalPerf.default.html) | [299](http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/12366/merge/perf-test/fluentui/PortalMinimalPerf.default_base.html) | 1.05:1 ProviderMinimalPerf.default | [684](http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/12366/merge/perf-test/fluentui/ProviderMinimalPerf.default.html) | [651](http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/12366/merge/perf-test/fluentui/ProviderMinimalPerf.default_base.html) | 1.05:1 AttachmentMinimalPerf.default | [969](http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/12366/merge/perf-test/fluentui/AttachmentMinimalPerf.default.html) | [928](http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/12366/merge/perf-test/fluentui/AttachmentMinimalPerf.default_base.html) | 1.04:1 GridMinimalPerf.default | [979](http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/12366/merge/perf-test/fluentui/GridMinimalPerf.default.html) | [945](http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/12366/merge/perf-test/fluentui/GridMinimalPerf.default_base.html) | 1.04:1 HierarchicalTreeMinimalPerf.default | [1153](http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/12366/merge/perf-test/fluentui/HierarchicalTreeMinimalPerf.default.html) | [1106](http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/12366/merge/perf-test/fluentui/HierarchicalTreeMinimalPerf.default_base.html) | 1.04:1 Tooltip.Fluent | [636](http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/12366/merge/perf-test/fluentui/Tooltip.Fluent.html) | [613](http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/12366/merge/perf-test/fluentui/Tooltip.Fluent_base.html) | 1.04:1 AlertMinimalPerf.default | [636](http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/12366/merge/perf-test/fluentui/AlertMinimalPerf.default.html) | [615](http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/12366/merge/perf-test/fluentui/AlertMinimalPerf.default_base.html) | 1.03:1 ChatWithPopoverPerf.default | [612](http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/12366/merge/perf-test/fluentui/ChatWithPopoverPerf.default.html) | [593](http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/12366/merge/perf-test/fluentui/ChatWithPopoverPerf.default_base.html) | 1.03:1 DividerMinimalPerf.default | [1046](http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/12366/merge/perf-test/fluentui/DividerMinimalPerf.default.html) | [1020](http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/12366/merge/perf-test/fluentui/DividerMinimalPerf.default_base.html) | 1.03:1 HeaderMinimalPerf.default | [629](http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/12366/merge/perf-test/fluentui/HeaderMinimalPerf.default.html) | [608](http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/12366/merge/perf-test/fluentui/HeaderMinimalPerf.default_base.html) | 1.03:1 StatusMinimalPerf.default | [713](http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/12366/merge/perf-test/fluentui/StatusMinimalPerf.default.html) | [694](http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/12366/merge/perf-test/fluentui/StatusMinimalPerf.default_base.html) | 1.03:1 TextMinimalPerf.default | [398](http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/12366/merge/perf-test/fluentui/TextMinimalPerf.default.html) | [388](http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/12366/merge/perf-test/fluentui/TextMinimalPerf.default_base.html) | 1.03:1 AccordionMinimalPerf.default | [254](http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/12366/merge/perf-test/fluentui/AccordionMinimalPerf.default.html) | [249](http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/12366/merge/perf-test/fluentui/AccordionMinimalPerf.default_base.html) | 1.02:1 DialogMinimalPerf.default | [2068](http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/12366/merge/perf-test/fluentui/DialogMinimalPerf.default.html) | [2027](http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/12366/merge/perf-test/fluentui/DialogMinimalPerf.default_base.html) | 1.02:1 ItemLayoutMinimalPerf.default | [2247](http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/12366/merge/perf-test/fluentui/ItemLayoutMinimalPerf.default.html) | [2198](http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/12366/merge/perf-test/fluentui/ItemLayoutMinimalPerf.default_base.html) | 1.02:1 ListWith60ListItems.default | [1271](http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/12366/merge/perf-test/fluentui/ListWith60ListItems.default.html) | [1251](http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/12366/merge/perf-test/fluentui/ListWith60ListItems.default_base.html) | 1.02:1 MenuButtonMinimalPerf.default | [1707](http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/12366/merge/perf-test/fluentui/MenuButtonMinimalPerf.default.html) | [1671](http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/12366/merge/perf-test/fluentui/MenuButtonMinimalPerf.default_base.html) | 1.02:1 ProviderMergeThemesPerf.default | [1423](http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/12366/merge/perf-test/fluentui/ProviderMergeThemesPerf.default.html) | [1389](http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/12366/merge/perf-test/fluentui/ProviderMergeThemesPerf.default_base.html) | 1.02:1 Dialog.Fluent | [2061](http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/12366/merge/perf-test/fluentui/Dialog.Fluent.html) | [2025](http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/12366/merge/perf-test/fluentui/Dialog.Fluent_base.html) | 1.02:1 Slider.Fluent | [1533](http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/12366/merge/perf-test/fluentui/Slider.Fluent.html) | [1509](http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/12366/merge/perf-test/fluentui/Slider.Fluent_base.html) | 1.02:1 CardMinimalPerf.default | [409](http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/12366/merge/perf-test/fluentui/CardMinimalPerf.default.html) | [403](http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/12366/merge/perf-test/fluentui/CardMinimalPerf.default_base.html) | 1.01:1 InputMinimalPerf.default | [1086](http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/12366/merge/perf-test/fluentui/InputMinimalPerf.default.html) | [1079](http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/12366/merge/perf-test/fluentui/InputMinimalPerf.default_base.html) | 1.01:1 ListNestedPerf.default | [998](http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/12366/merge/perf-test/fluentui/ListNestedPerf.default.html) | [987](http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/12366/merge/perf-test/fluentui/ListNestedPerf.default_base.html) | 1.01:1 TableMinimalPerf.default | [737](http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/12366/merge/perf-test/fluentui/TableMinimalPerf.default.html) | [730](http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/12366/merge/perf-test/fluentui/TableMinimalPerf.default_base.html) | 1.01:1 TextAreaMinimalPerf.default | [3193](http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/12366/merge/perf-test/fluentui/TextAreaMinimalPerf.default.html) | [3175](http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/12366/merge/perf-test/fluentui/TextAreaMinimalPerf.default_base.html) | 1.01:1 Checkbox.Fluent | [701](http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/12366/merge/perf-test/fluentui/Checkbox.Fluent.html) | [695](http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/12366/merge/perf-test/fluentui/Checkbox.Fluent_base.html) | 1.01:1 ChatMinimalPerf.default | [601](http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/12366/merge/perf-test/fluentui/ChatMinimalPerf.default.html) | [600](http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/12366/merge/perf-test/fluentui/ChatMinimalPerf.default_base.html) | 1:1 CheckboxMinimalPerf.default | [3319](http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/12366/merge/perf-test/fluentui/CheckboxMinimalPerf.default.html) | [3330](http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/12366/merge/perf-test/fluentui/CheckboxMinimalPerf.default_base.html) | 1:1 DropdownManyItemsPerf.default | [1480](http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/12366/merge/perf-test/fluentui/DropdownManyItemsPerf.default.html) | [1478](http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/12366/merge/perf-test/fluentui/DropdownManyItemsPerf.default_base.html) | 1:1 DropdownMinimalPerf.default | [3523](http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/12366/merge/perf-test/fluentui/DropdownMinimalPerf.default.html) | [3517](http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/12366/merge/perf-test/fluentui/DropdownMinimalPerf.default_base.html) | 1:1 EmbedMinimalPerf.default | [5466](http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/12366/merge/perf-test/fluentui/EmbedMinimalPerf.default.html) | [5485](http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/12366/merge/perf-test/fluentui/EmbedMinimalPerf.default_base.html) | 1:1 FormMinimalPerf.default | [1016](http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/12366/merge/perf-test/fluentui/FormMinimalPerf.default.html) | [1012](http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/12366/merge/perf-test/fluentui/FormMinimalPerf.default_base.html) | 1:1 MenuMinimalPerf.default | [2125](http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/12366/merge/perf-test/fluentui/MenuMinimalPerf.default.html) | [2128](http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/12366/merge/perf-test/fluentui/MenuMinimalPerf.default_base.html) | 1:1 TreeMinimalPerf.default | [1283](http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/12366/merge/perf-test/fluentui/TreeMinimalPerf.default.html) | [1287](http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/12366/merge/perf-test/fluentui/TreeMinimalPerf.default_base.html) | 1:1 AnimationMinimalPerf.default | [708](http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/12366/merge/perf-test/fluentui/AnimationMinimalPerf.default.html) | [717](http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/12366/merge/perf-test/fluentui/AnimationMinimalPerf.default_base.html) | 0.99:1 AttachmentSlotsPerf.default | [3763](http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/12366/merge/perf-test/fluentui/AttachmentSlotsPerf.default.html) | [3812](http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/12366/merge/perf-test/fluentui/AttachmentSlotsPerf.default_base.html) | 0.99:1 AvatarMinimalPerf.default | [600](http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/12366/merge/perf-test/fluentui/AvatarMinimalPerf.default.html) | [609](http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/12366/merge/perf-test/fluentui/AvatarMinimalPerf.default_base.html) | 0.99:1 ButtonSlotsPerf.default | [649](http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/12366/merge/perf-test/fluentui/ButtonSlotsPerf.default.html) | [653](http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/12366/merge/perf-test/fluentui/ButtonSlotsPerf.default_base.html) | 0.99:1 CarouselMinimalPerf.default | [2076](http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/12366/merge/perf-test/fluentui/CarouselMinimalPerf.default.html) | [2102](http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/12366/merge/perf-test/fluentui/CarouselMinimalPerf.default_base.html) | 0.99:1 LayoutMinimalPerf.default | [706](http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/12366/merge/perf-test/fluentui/LayoutMinimalPerf.default.html) | [713](http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/12366/merge/perf-test/fluentui/LayoutMinimalPerf.default_base.html) | 0.99:1 ListMinimalPerf.default | [473](http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/12366/merge/perf-test/fluentui/ListMinimalPerf.default.html) | [477](http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/12366/merge/perf-test/fluentui/ListMinimalPerf.default_base.html) | 0.99:1 SegmentMinimalPerf.default | [1149](http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/12366/merge/perf-test/fluentui/SegmentMinimalPerf.default.html) | [1159](http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/12366/merge/perf-test/fluentui/SegmentMinimalPerf.default_base.html) | 0.99:1 TooltipMinimalPerf.default | [895](http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/12366/merge/perf-test/fluentui/TooltipMinimalPerf.default.html) | [907](http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/12366/merge/perf-test/fluentui/TooltipMinimalPerf.default_base.html) | 0.99:1 Avatar.Fluent | [1103](http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/12366/merge/perf-test/fluentui/Avatar.Fluent.html) | [1113](http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/12366/merge/perf-test/fluentui/Avatar.Fluent_base.html) | 0.99:1 IconMinimalPerf.default | [447](http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/12366/merge/perf-test/fluentui/IconMinimalPerf.default.html) | [455](http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/12366/merge/perf-test/fluentui/IconMinimalPerf.default_base.html) | 0.98:1 ListCommonPerf.default | [1089](http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/12366/merge/perf-test/fluentui/ListCommonPerf.default.html) | [1114](http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/12366/merge/perf-test/fluentui/ListCommonPerf.default_base.html) | 0.98:1 ReactionMinimalPerf.default | [2493](http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/12366/merge/perf-test/fluentui/ReactionMinimalPerf.default.html) | [2535](http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/12366/merge/perf-test/fluentui/ReactionMinimalPerf.default_base.html) | 0.98:1 SliderMinimalPerf.default | [1481](http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/12366/merge/perf-test/fluentui/SliderMinimalPerf.default.html) | [1514](http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/12366/merge/perf-test/fluentui/SliderMinimalPerf.default_base.html) | 0.98:1 ToolbarMinimalPerf.default | [1187](http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/12366/merge/perf-test/fluentui/ToolbarMinimalPerf.default.html) | [1211](http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/12366/merge/perf-test/fluentui/ToolbarMinimalPerf.default_base.html) | 0.98:1 Icon.Fluent | [909](http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/12366/merge/perf-test/fluentui/Icon.Fluent.html) | [926](http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/12366/merge/perf-test/fluentui/Icon.Fluent_base.html) | 0.98:1 RadioGroupMinimalPerf.default | [600](http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/12366/merge/perf-test/fluentui/RadioGroupMinimalPerf.default.html) | [621](http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/12366/merge/perf-test/fluentui/RadioGroupMinimalPerf.default_base.html) | 0.97:1 SplitButtonMinimalPerf.default | [12341](http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/12366/merge/perf-test/fluentui/SplitButtonMinimalPerf.default.html) | [12774](http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/12366/merge/perf-test/fluentui/SplitButtonMinimalPerf.default_base.html) | 0.97:1 Button.Fluent | [502](http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/12366/merge/perf-test/fluentui/Button.Fluent.html) | [520](http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/12366/merge/perf-test/fluentui/Button.Fluent_base.html) | 0.97:1 Dropdown.Fluent | [3520](http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/12366/merge/perf-test/fluentui/Dropdown.Fluent.html) | [3634](http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/12366/merge/perf-test/fluentui/Dropdown.Fluent_base.html) | 0.97:1 Image.Fluent | [365](http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/12366/merge/perf-test/fluentui/Image.Fluent.html) | [377](http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/12366/merge/perf-test/fluentui/Image.Fluent_base.html) | 0.97:1 ChatDuplicateMessagesPerf.default | [445](http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/12366/merge/perf-test/fluentui/ChatDuplicateMessagesPerf.default.html) | [464](http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/12366/merge/perf-test/fluentui/ChatDuplicateMessagesPerf.default_base.html) | 0.96:1 ImageMinimalPerf.default | [364](http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/12366/merge/perf-test/fluentui/ImageMinimalPerf.default.html) | [378](http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/12366/merge/perf-test/fluentui/ImageMinimalPerf.default_base.html) | 0.96:1 ButtonMinimalPerf.default | [150](http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/12366/merge/perf-test/fluentui/ButtonMinimalPerf.default.html) | [161](http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/12366/merge/perf-test/fluentui/ButtonMinimalPerf.default_base.html) | 0.93:1 VideoMinimalPerf.default | [927](http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/12366/merge/perf-test/fluentui/VideoMinimalPerf.default.html) | [996](http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/12366/merge/perf-test/fluentui/VideoMinimalPerf.default_base.html) | 0.93:1
micahgodbolt commented 4 years ago

@ecraig12345 thanks for getting those conflicts resolved! I went through and addressed your questions and suggesstions.

micahgodbolt commented 4 years ago

running yarn change locally doesn't show any new change files

msft-github-bot commented 4 years ago

Hello @micahgodbolt!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msft-github-bot) and give me an instruction to get started! Learn more here.
micahgodbolt commented 4 years ago

@ecraig12345 @paulgildea i've reviewed all feedback. Is this close to ready?

ecraig12345 commented 4 years ago

More issues (apologies for the giant screenshots):

  • [ ] SiteDefinition.tsx: update siteLogoSource to point to a logo which says "Fluent UI" (only used for internal or PR deploy, but still good to update) image
  • [x] HomePage.base.tsx: "Together, we've created UI Fabric" image
  • [x] Version selector (note that 5 and 6 entries should probably still say fabric) image
  • [x] "Who at Microsoft uses Fabric?" + Fabric in next paragraph image
micahgodbolt commented 4 years ago

Failing due to size auditor, which seems a false positive.

ecraig12345 commented 4 years ago

Size auditor is broken right now.

micahgodbolt commented 4 years ago

@ecraig12345 what's the chance of merging this in soon? website deploy is currently off, so we dont' risk errors/missing items going live

ecraig12345 commented 4 years ago

I just pushed one more update to the licenses, so after that it looks good for now. I'll keep reading through the site too.

msft-github-bot commented 4 years ago

:tada:@uifabric/webpack-utils@v7.0.11 has been released which incorporates this pull request.:tada:

Handy links:

msft-github-bot commented 4 years ago

:tada:@uifabric/variants@v7.1.34 has been released which incorporates this pull request.:tada:

Handy links:

msft-github-bot commented 4 years ago

:tada:@uifabric/theme-samples@v7.0.44 has been released which incorporates this pull request.:tada:

Handy links:

msft-github-bot commented 4 years ago

:tada:@uifabric/tslint-rules@v7.1.2 has been released which incorporates this pull request.:tada:

Handy links:

msft-github-bot commented 4 years ago

:tada:@uifabric/jest-serializer-merge-styles@v7.0.15 has been released which incorporates this pull request.:tada:

Handy links:

msft-github-bot commented 4 years ago

:tada:@uifabric/file-type-icons@v7.2.26 has been released which incorporates this pull request.:tada:

Handy links:

msft-github-bot commented 4 years ago

:tada:@uifabric/styling@v7.11.0 has been released which incorporates this pull request.:tada:

Handy links:

msft-github-bot commented 4 years ago

:tada:@uifabric/utilities@v7.15.3 has been released which incorporates this pull request.:tada:

Handy links:

msft-github-bot commented 4 years ago

:tada:@uifabric/test-utilities@v7.0.15 has been released which incorporates this pull request.:tada:

Handy links:

msft-github-bot commented 4 years ago

:tada:@uifabric/react-cards@v0.109.45 has been released which incorporates this pull request.:tada:

Handy links:

msft-github-bot commented 4 years ago

:tada:@uifabric/icons@v7.3.22 has been released which incorporates this pull request.:tada:

Handy links:

msft-github-bot commented 4 years ago

:tada:@uifabric/tsx-editor@v0.11.41 has been released which incorporates this pull request.:tada:

Handy links:

msft-github-bot commented 4 years ago

:tada:@uifabric/set-version@v7.0.9 has been released which incorporates this pull request.:tada:

Handy links:

msft-github-bot commented 4 years ago

:tada:@uifabric/pr-deploy-site@v7.0.44 has been released which incorporates this pull request.:tada:

Handy links:

msft-github-bot commented 4 years ago

:tada:@uifabric/foundation-scenarios@v0.102.48 has been released which incorporates this pull request.:tada:

Handy links:

msft-github-bot commented 4 years ago

:tada:@uifabric/azure-themes@v7.0.50 has been released which incorporates this pull request.:tada:

Handy links:

msft-github-bot commented 4 years ago

:tada:office-ui-fabric-react@v7.105.3 has been released which incorporates this pull request.:tada:

Handy links:

msft-github-bot commented 4 years ago

:tada:@uifabric/react-hooks@v7.0.24 has been released which incorporates this pull request.:tada:

Handy links:

msft-github-bot commented 4 years ago

:tada:@uifabric/monaco-editor@v0.5.5 has been released which incorporates this pull request.:tada:

Handy links:

msft-github-bot commented 4 years ago

:tada:@uifabric/fluent-theme@v7.1.43 has been released which incorporates this pull request.:tada:

Handy links:

msft-github-bot commented 4 years ago

:tada:@uifabric/api-docs@v7.2.40 has been released which incorporates this pull request.:tada:

Handy links:

msft-github-bot commented 4 years ago

:tada:@uifabric/migration@v7.0.14 has been released which incorporates this pull request.:tada:

Handy links:

msft-github-bot commented 4 years ago

:tada:@uifabric/merge-styles@v7.8.10 has been released which incorporates this pull request.:tada:

Handy links:

msft-github-bot commented 4 years ago

:tada:@uifabric/example-data@v7.0.9 has been released which incorporates this pull request.:tada:

Handy links:

msft-github-bot commented 4 years ago

:tada:@fluentui/react@v7.105.4 has been released which incorporates this pull request.:tada:

Handy links:

msft-github-bot commented 4 years ago

:tada:@uifabric/foundation@v7.5.23 has been released which incorporates this pull request.:tada:

Handy links:

msft-github-bot commented 4 years ago

:tada:@uifabric/date-time@v7.8.45 has been released which incorporates this pull request.:tada:

Handy links:

msft-github-bot commented 4 years ago

:tada:@uifabric/charting@v1.0.0 has been released which incorporates this pull request.:tada:

Handy links:

msft-github-bot commented 4 years ago

:tada:@fluentui/react-focus@v7.1.10 has been released which incorporates this pull request.:tada:

Handy links:

msft-github-bot commented 4 years ago

:tada:@uifabric/experiments@v7.22.8 has been released which incorporates this pull request.:tada:

Handy links:

msft-github-bot commented 4 years ago

:tada:@uifabric/example-app-base@v7.12.24 has been released which incorporates this pull request.:tada:

Handy links:

msft-github-bot commented 4 years ago

:tada:@fluentui/react-compose@v0.2.3 has been released which incorporates this pull request.:tada:

Handy links:

msft-github-bot commented 4 years ago

:tada:@fluentui/keyboard-key@v0.1.4 has been released which incorporates this pull request.:tada:

Handy links:

msft-github-bot commented 4 years ago

:tada:@fluentui/examples@v0.1.21 has been released which incorporates this pull request.:tada:

Handy links:

msft-github-bot commented 4 years ago

:tada:@uifabric/mdl2-theme@v0.1.44 has been released which incorporates this pull request.:tada:

Handy links: