search

microsoft / fluentui

Fluent UI web represents a collection of utilities, React components, and web components for building web applications.
https://react.fluentui.dev
Other
18.43k stars 2.72k forks source link

CRA template test is using wrong library version #18685

Closed ecraig12345 closed 3 years ago

ecraig12345 commented 3 years ago

Two closely related problems: - packages/cra-template/template.json is still specifying a dep on @fluentui/react@7. We should bump this, and bump the template package's version to 8 (this should have happened in the initial publish). Turns out to be the root cause of #18662, so tracking it there.

packages/cra-template/scripts/test.ts is not using the local versions of dependencies, making the test completely invalid/pointless. It needs to be expanded to use similar logic to packages/fluentui/project-tests/src/createReactApp.ts which gzips all the local packages and uses a version of the template with updated deps.

ecraig12345 commented 3 years ago

@miroslavstastny If you have time to fix this as part of shield, that would be really great--it's a pretty straightforward fix (both the immediate fix and the test, since the test code already exists elsewhere) and high impact for new library users. If not I'll try to make time or see if anyone from the build team has time.

ecraig12345 commented 3 years ago

Actually I made a PR to fix the issue itself, and fixing the test can be done later.