search

microsoft / fluentui

Fluent UI web represents a collection of utilities, React components, and web components for building web applications.
https://react.fluentui.dev
Other
18.53k stars 2.74k forks source link

SearchBox clear button doesn't give hover feedback in high contrast mode #20965

Closed molinger closed 2 years ago

molinger commented 2 years ago

Environment Information

Please provide a reproduction of the bug in a codepen:

  1. Enable high contrast mode. I used the default Night Sky theme.
  2. Go to https://codepen.io/molinger/pen/eYGZypx
  3. Hover over the clear button in the search box.

Actual behavior:

No feedback is given.

Expected behavior:

Some feedback is given (e.g. button has outline or color changes).

Priorities and help requested:

Are you willing to submit a PR to fix? Yes

Requested priority: Normal

molinger commented 2 years ago

This also impacts the expand buttons on GroupedList. Let me know if I should file a separate issue for that.

gouttierre commented 2 years ago

@molinger - I’ve added this to our projects for review but it’s low on our priority list as we’re likely not going to get to it for a while as we’re currently focused on larger coherence work items and enhancements to our performance. However, I see you are willing to submit a PR for this fix. If you have the solution at hand, would you mind sharing it with us? Thanks.

msft-fluent-ui-bot commented 2 years ago

This issue has been automatically marked as stale because it has marked as requiring author feedback but has not had any activity for 4 days. It will be closed if no further activity occurs within 3 days of this comment. Thank you for your contributions to Fluent UI!