search

microsoft / fluentui

Fluent UI web represents a collection of utilities, React components, and web components for building web applications.
https://react.fluentui.dev
Other
18.51k stars 2.73k forks source link

Update peerDependencies for @fluentui/react-northstar #21624

Closed dhruvit-r closed 2 years ago

dhruvit-r commented 2 years ago

Environment Information

Describe the issue:

https://github.com/microsoft/fluentui/blob/master/packages/fluentui/react-northstar/package.json#L63

@fluentui/react-northstar has a few outdated peerDependencies. react is pinned to ^16.8.0 and react-dom is pinned to ^16.8.0. React 17 has been released with very few breaking changes, so this'll probably be a trivial update to the packaje.json file.

Actual behavior:

Peer Dependencies are not up to date.

Expected behavior:

Peer Dependencies should be up to date.

Priorities and help requested (not applicable if asking question):

Are you willing to submit a PR to fix?: Yes if it's a simple update to package.json and tests pass

Requested priority: Low

Products/sites affected: Not Applicable

gouttierre commented 2 years ago

@dhruvit-r - Thanks for filing this issue with us. To set expectations, the developers will review this issue once capacity allows.

@jurokapsiar- Would your team be able to review this issue when bandwidth opens up? Thanks

jurokapsiar commented 2 years ago

Duplicate of #21082