search

microsoft / fluentui

Fluent UI web represents a collection of utilities, React components, and web components for building web applications.
https://react.fluentui.dev
Other
18.34k stars 2.72k forks source link

NormalPeoplePicker required attribute #22528

Open tpalacino opened 2 years ago

tpalacino commented 2 years ago

Describe the feature that you would like added

I would like to have a "required" and "onGetErrorMessage" attributes be added

What component or utility would this be added to

NormalPeoplePicker (ideally it would be on the BasePicker so all pickers would have it)

Have you discussed this feature with our team, and if so, who

No

Additional context/screenshots

The expected behavior would be similar to the same attributes of the ComboBox.

gouttierre commented 2 years ago

I’ve added this to our backlog for review but it’s low on our priority list as we’re likely not going to get to it for a while as we’re currently focused on larger coherence work items and enhancements to our performance. In the meantime, if you want to contribute towards this request, please share your PR and our dev team will review it.

tpalacino commented 2 years ago

I've implemented the label, required, errorMessage, and onGetErrorMessage functionality in the BasePicker and BasePickerListBelow but the steps of the Full development workflow walkthrough are failing on aspects of the code that I did not change.

Since the same errors occur in the same files when I attempt to run those build commands on the current version of the master branch in the microsoft/fluentui repo I went ahead with generating a change file and creating the PR # 23362

tpalacino commented 2 years ago

@gouttierre Can you help me understand what to do next?

I made the code updates and submitted the PR. Two of the automated validations are failing. One issue should not actually be treated as a failure IMO, and I have shared some details in the PR comments explaining why I think that. Despite recent activity from @ling1726, I have yet to receive have any guidance on how to resolve the issues.

tpalacino commented 2 years ago

Is there anybody that has contributed to this project before that can help me understand how to proceed?

tpalacino commented 2 years ago

@gouttierre I've done everything I can for this. How long does it normally take to get a response from anybody at all?

JustSlone commented 1 year ago

hey @tpalacino sorry this fell through the cracks, are you still interested in contributing here? Thanks!

tpalacino commented 1 year ago

Yes. I think this is a solid addition

JustSlone commented 1 year ago

@micahgodbolt, can you, or someone from coastal, work with @tpalacino on this contribution?

@tpalacino this is scheduled for Oct 31- Nov 13th iteration, folks should have time to dig in then.

tpalacino commented 1 year ago

@micahgodbolt I am unable to make any sense of why the Sizer step is failing the build on my PR. Can you offer any guidance?

msft-fluent-ui-bot commented 1 year ago

Because this issue has not had activity for over 180 days, we're automatically closing it for house-keeping purposes.

Still require assistance? Please, create a new issue with up-to date details.

tpalacino commented 1 year ago

Can I please have some communication from a human on this? I have repeatedly tried to get assistance with getting the PR reviewed and approved.

khmakoto commented 1 year ago

@tpalacino I've reopened the issue and I'll try to take a look at your PR as soon as possible.

tpalacino commented 1 year ago

Awesome. Thanks.

tpalacino commented 1 year ago

@khmakoto any update on this?

tpalacino commented 11 months ago

@khmakoto I understand that the primary focus is v9 but this update does a lot to unify the developer experience of the normal people picker and other user input components. It'd be awesome to have this functionality merged.