microsoft / fluentui

Fluent UI web represents a collection of utilities, React components, and web components for building web applications.
https://react.fluentui.dev
Other
18.52k stars 2.73k forks source link

[Feature]: ForwardRef on createComponent #22569

Closed marwan38 closed 2 years ago

marwan38 commented 2 years ago

Library

React Northstar / v0 (@fluentui/react-northstar)

Describe the feature that you would like added

Currently, the exposed createComponent made for consumers to create their own components without touching the internals of fluentui does not forward the prop down the render function. I'm not sure if this was a missed implementation or it was purposely done. If it's the former then it should be added and if it's the latter than I am intrigued by this design decision.

I am happy to create a PR and allow those components to have a ref, just let me know.

Have you discussed this feature with our team

No response

Additional context

Northstar consumer.

Validations

msft-fluent-ui-bot commented 2 years ago

Because this issue has not had activity for over 150 days, we're automatically closing it for house-keeping purposes.

Still require assistance? Please, create a new issue with up-to date details.