microsoft / fluentui

Fluent UI web represents a collection of utilities, React components, and web components for building web applications.
https://react.fluentui.dev
Other
18.52k stars 2.73k forks source link

FormDatePicker having JS console error and Stroybook error when errorMessage props is passed in #24203

Closed aubreyquinn closed 1 year ago

aubreyquinn commented 2 years ago

Environment Information

System: OS: Windows 10 10.0.22000 Browsers: Edge: Spartan (44.22000.120.0), Chromium (103.0.1264.77) Internet Explorer: 11.0.22000.120

Describe the issue:

FormDatePicker having JS console error and Stroybook error when errorMessage props is passed in

_Warning: Received true for a non-boolean attribute error.

If you want to write it to the DOM, pass a string instead: error="true" or error={value.toString()}. in div (created by Datepicker) in Datepicker (created by FormDatepicker) in div (created by FormDatepicker) in FormDatepicker (created by FormExampleDatepicker) in form (created by Form) in Form (created by FormExampleDatepicker) in FormExampleDatepicker in div (created by SandboxApp) in KnobProvider (created by SandboxApp) in div (created by Provider) in RendererProvider (created by Provider) in Provider (created by Provider) in Provider (created by SandboxApp) in SandboxApp_

error-date-picker

Expected behavior:

should be able to pass in the errorMessage props without any errors in Storybook

If applicable, please provide a codepen repro:

https://codesandbox.io/s/formdatepicker-with-error-message-forked-dhiogy

Priorities and help requested (not applicable if asking question):

Are you willing to submit a PR to fix? (Yes, No)

Requested priority: Normal

Products/sites affected: Teams - Collaboration Manager

msft-fluent-ui-bot commented 1 year ago

Because this issue has not had activity for over 180 days, we're automatically closing it for house-keeping purposes.

Still require assistance? Please, create a new issue with up-to date details.