microsoft / fluentui

Fluent UI web represents a collection of utilities, React components, and web components for building web applications.
https://react.fluentui.dev
Other
18.52k stars 2.73k forks source link

[Bug]: during v9 release react-northstar package.json was not update - causing broken master #25637

Closed Hotell closed 1 year ago

Hotell commented 1 year ago

Library

React Components / v9 (@fluentui/react-components)

Reproduction

https://github.com/microsoft/fluentui/pull/25636

Bug Description

Actual Behavior

v9 release was triggered bump to v9 package which is used as dependency in react-northstar. This bump was not reflected in react-northstar package.json, thus release failed and we got master in invalid state.

Expected Behavior

react-northstar package.json should be updated during release if appropriate

Requested priority

High

Products/sites affected

No response

Are you willing to submit a PR to fix?

yes

Validations

ling1726 commented 1 year ago

@Hotell duplicate of #25316 ?

Hotell commented 1 year ago

ah indeed ! ty