search

microsoft / fluentui

Fluent UI web represents a collection of utilities, React components, and web components for building web applications.
https://react.fluentui.dev
Other
17.87k stars 2.66k forks source link

fix(react-infobutton): Add aria-owns to InfoLabel #27834

Closed sopranopillow closed 1 year ago

sopranopillow commented 1 year ago

Previous Behavior

aria-owns is not set, therefore the popup is not linked to the trigger.

New Behavior

aria-owns is now set by InfoLabel and a Do has been added advising to add aria-owns to the parent of the trigger.

codesandbox-ci[bot] commented 1 year ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 7b5023060d29a7101513ef818c360a9b25c4543c:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration
size-auditor[bot] commented 1 year ago

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 989ead3c07d6df61441f9c6ca8102634e40dc48d (build)

fabricteam commented 1 year ago

📊 Bundle size report

Package & Exports Baseline (minified/GZIP) PR Change
react-infobutton
InfoLabel		 131.26 kB
40 kB		 131.447 kB
40.071 kB		 187 B
71 B
Unchanged fixtures | Package & Exports | Size (minified/GZIP) | | ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | ----------------------------: | | react-components
react-components: Button, FluentProvider & webLightTheme | `64.855 kB`
`17.852 kB` | | react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover | `203.937 kB`
`57.086 kB` | | react-components
react-components: FluentProvider & webLightTheme | `36.086 kB`
`11.9 kB` | | react-infobutton
InfoButton | `127.977 kB`
`39.012 kB` | | react-portal-compat
PortalCompatProvider | `6.446 kB`
`2.186 kB` |

🤖 This report was generated against 989ead3c07d6df61441f9c6ca8102634e40dc48d

fabricteam commented 1 year ago

Perf Analysis (@fluentui/react-components)

Scenario Render type Master Ticks PR Ticks Iterations Status
FluentProviderWithTheme virtual-rerender-with-unmount 121 133 10 Possible regression
All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 858 864 5000
Button mount 461 465 5000
Field mount 1542 1589 5000
FluentProvider mount 1084 1121 5000
FluentProviderWithTheme mount 131 147 10
FluentProviderWithTheme virtual-rerender 108 119 10
FluentProviderWithTheme virtual-rerender-with-unmount 121 133 10 Possible regression
InfoButton mount 24 23 5000
MakeStyles mount 1353 1363 50000
Persona mount 2342 2353 5000
SpinButton mount 1917 1854 5000

fabricteam commented 1 year ago

🕵 fluentuiv9 No visual regressions between this PR and main

msft-fluent-ui-bot commented 1 year ago

:tada:@fluentui/react-combobox@v9.3.1 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot commented 1 year ago

:tada:@fluentui/react-components@v9.20.1 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot commented 1 year ago

:tada:@fluentui/react-context-selector@v9.1.20 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot commented 1 year ago

:tada:@fluentui/react-data-grid-react-window@v9.0.0-beta.25 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot commented 1 year ago

:tada:@fluentui/react-datepicker-compat@v0.1.1 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot commented 1 year ago

:tada:@fluentui/react-dialog@v9.5.5 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot commented 1 year ago

:tada:@fluentui/react-divider@v9.2.12 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot commented 1 year ago

:tada:@fluentui/react-field@v9.1.3 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot commented 1 year ago

:tada:@fluentui/react-image@v9.1.9 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot commented 1 year ago

:tada:@fluentui/react-infobutton@v9.0.0-beta.30 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot commented 1 year ago

:tada:@fluentui/react-input@v9.4.13 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot commented 1 year ago

:tada:@fluentui/react-jsx-runtime@v9.0.0-alpha.4 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot commented 1 year ago

:tada:@fluentui/react-label@v9.1.12 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot commented 1 year ago

:tada:@fluentui/react-link@v9.0.38 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot commented 1 year ago

:tada:@fluentui/react-menu@v9.7.12 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot commented 1 year ago

:tada:@fluentui/react-migration-v8-v9@v9.2.12 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot commented 1 year ago

:tada:@fluentui/react-overflow@v9.0.17 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot commented 1 year ago

:tada:@fluentui/react-persona@v9.2.11 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot commented 1 year ago

:tada:@fluentui/react-popover@v9.5.12 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot commented 1 year ago

:tada:@fluentui/react-portal-compat@v9.0.56 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot commented 1 year ago

:tada:@fluentui/react-portal@v9.2.8 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot commented 1 year ago

:tada:@fluentui/react-positioning@v9.5.12 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot commented 1 year ago

:tada:@fluentui/react-progress@v9.1.13 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot commented 1 year ago

:tada:@fluentui/react-provider@v9.6.1 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot commented 1 year ago

:tada:@fluentui/react-radio@v9.1.13 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot commented 1 year ago

:tada:@fluentui/react-select@v9.1.13 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot commented 1 year ago

:tada:@fluentui/react-skeleton@v9.0.1 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot commented 1 year ago

:tada:@fluentui/react-slider@v9.1.13 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot commented 1 year ago

:tada:@fluentui/react-spinbutton@v9.2.13 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot commented 1 year ago

:tada:@fluentui/react-spinner@v9.1.12 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot commented 1 year ago

:tada:@fluentui/react-switch@v9.1.13 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot commented 1 year ago

:tada:@fluentui/react-table@v9.2.9 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot commented 1 year ago

:tada:@fluentui/react-tabs@v9.3.13 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot commented 1 year ago

:tada:@fluentui/react-tabster@v9.7.1 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot commented 1 year ago

:tada:@fluentui/react-text@v9.3.9 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot commented 1 year ago

:tada:@fluentui/react-textarea@v9.3.13 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot commented 1 year ago

:tada:@fluentui/react-toolbar@v9.1.13 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot commented 1 year ago

:tada:@fluentui/react-tooltip@v9.2.12 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot commented 1 year ago

:tada:@fluentui/react-tree@v9.0.0-beta.14 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot commented 1 year ago

:tada:@fluentui/react-virtualizer@v9.0.0-alpha.20 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot commented 1 year ago

:tada:@fluentui/babel-preset-global-context@v9.0.0-beta.27 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot commented 1 year ago

:tada:@fluentui/global-context@v9.0.0-beta.27 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot commented 1 year ago

:tada:@fluentui/react-accordion@v9.1.12 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot commented 1 year ago

:tada:@fluentui/react-alert@v9.0.0-beta.47 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot commented 1 year ago

:tada:@fluentui/react-aria@v9.3.20 has been released which incorporates this pull request.:tada:

Handy links:

  • © Githubissues.
  • Githubissues is a development platform for aggregating issues.