search

microsoft / fluentui

Fluent UI web represents a collection of utilities, React components, and web components for building web applications.
https://react.fluentui.dev
Other
17.87k stars 2.66k forks source link

fix(react-datepicker-compat): Error handling story now doesn't use Date.now to avoid SSR errors #27988

Closed sopranopillow closed 1 year ago

sopranopillow commented 1 year ago

Previous Behavior

Error handling story uses Date.now()

New Behavior

Error handling story doesn't use Date.now() instead it uses a specific date.

Related Issue(s)

sopranopillow commented 1 year ago

@layershifter I was not able to repro the steps you gave in the original issue, in my local machine everything works. I am guessing that the error comes from Date.now() and therefore the server timezone/time messes up with that. Let me know if maybe I'm thinking of the wrong thing here, thanks!

For some more clarification, I cloned your PR and went through the steps you provided.

codesandbox-ci[bot] commented 1 year ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 3a6cfb4c7941f9c285e727578643ab15dc132a5a:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration
fabricteam commented 1 year ago

📊 Bundle size report

Unchanged fixtures | Package & Exports | Size (minified/GZIP) | | -------------------------------------------------------------------------------------------------------------------- | ----------------------------: | | react-datepicker-compat
DatePicker Compat | `221.446 kB`
`58.861 kB` |

🤖 This report was generated against 0e26a2c598d52a6399af2b5e73deffad3649f4b9

size-auditor[bot] commented 1 year ago

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 0e26a2c598d52a6399af2b5e73deffad3649f4b9 (build)

fabricteam commented 1 year ago

🕵 fluentuiv9 No visual regressions between this PR and main

msft-fluent-ui-bot commented 1 year ago

:tada:@fluentui/babel-preset-global-context@v9.0.0-beta.28 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot commented 1 year ago

:tada:@fluentui/react-checkbox@v9.1.16 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot commented 1 year ago

:tada:@fluentui/react-combobox@v9.3.4 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot commented 1 year ago

:tada:@fluentui/react-context-selector@v9.1.21 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot commented 1 year ago

:tada:@fluentui/react-datepicker-compat@v0.1.4 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot commented 1 year ago

:tada:@fluentui/react-divider@v9.2.14 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot commented 1 year ago

:tada:@fluentui/react-field@v9.1.5 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot commented 1 year ago

:tada:@fluentui/react-image@v9.1.11 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot commented 1 year ago

:tada:@fluentui/react-infobutton@v9.0.0-beta.33 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot commented 1 year ago

:tada:@fluentui/react-input@v9.4.15 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot commented 1 year ago

:tada:@fluentui/react-jsx-runtime@v9.0.0-alpha.5 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot commented 1 year ago

:tada:@fluentui/react-label@v9.1.14 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot commented 1 year ago

:tada:@fluentui/react-link@v9.0.41 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot commented 1 year ago

:tada:@fluentui/react-menu@v9.7.15 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot commented 1 year ago

:tada:@fluentui/react-overflow@v9.0.18 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot commented 1 year ago

:tada:@fluentui/react-persona@v9.2.14 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot commented 1 year ago

:tada:@fluentui/react-popover@v9.5.15 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot commented 1 year ago

:tada:@fluentui/react-portal@v9.2.11 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot commented 1 year ago

:tada:@fluentui/react-positioning@v9.5.14 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot commented 1 year ago

:tada:@fluentui/react-provider@v9.7.1 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot commented 1 year ago

:tada:@fluentui/react-progress@v9.1.15 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot commented 1 year ago

:tada:@fluentui/react-radio@v9.1.16 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot commented 1 year ago

:tada:@fluentui/react-select@v9.1.15 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot commented 1 year ago

:tada:@fluentui/react-skeleton@v9.0.3 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot commented 1 year ago

:tada:@fluentui/react-slider@v9.1.16 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot commented 1 year ago

:tada:@fluentui/react-spinbutton@v9.2.15 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot commented 1 year ago

:tada:@fluentui/react-spinner@v9.2.1 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot commented 1 year ago

:tada:@fluentui/react-switch@v9.1.16 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot commented 1 year ago

:tada:@fluentui/react-table@v9.2.12 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot commented 1 year ago

:tada:@fluentui/react-tabs@v9.3.16 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot commented 1 year ago

:tada:@fluentui/react-tabster@v9.7.4 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot commented 1 year ago

:tada:@fluentui/react-text@v9.3.11 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot commented 1 year ago

:tada:@fluentui/react-textarea@v9.3.15 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot commented 1 year ago

:tada:@fluentui/react-toolbar@v9.1.16 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot commented 1 year ago

:tada:@fluentui/react-tooltip@v9.2.15 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot commented 1 year ago

:tada:@fluentui/react-tree@v9.0.0-beta.17 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot commented 1 year ago

:tada:@fluentui/react-virtualizer@v9.0.0-alpha.21 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot commented 1 year ago

:tada:@fluentui/global-context@v9.0.0-beta.28 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot commented 1 year ago

:tada:@fluentui/react-accordion@v9.1.15 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot commented 1 year ago

:tada:@fluentui/react-alert@v9.0.0-beta.50 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot commented 1 year ago

:tada:@fluentui/react-aria@v9.3.21 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot commented 1 year ago

:tada:@fluentui/react-avatar@v9.5.4 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot commented 1 year ago

:tada:@fluentui/react-badge@v9.1.14 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot commented 1 year ago

:tada:@fluentui/react-button@v9.3.15 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot commented 1 year ago

:tada:@fluentui/react-card@v9.0.13 has been released which incorporates this pull request.:tada:

Handy links:

  • © Githubissues.
  • Githubissues is a development platform for aggregating issues.