microsoft / fluentui

Fluent UI web represents a collection of utilities, React components, and web components for building web applications.
https://react.fluentui.dev
Other
18.59k stars 2.75k forks source link

[Bug]: DialogOpenChangeData not reachable in imports but present as an export in library #28462

Closed jatin-tarachandani closed 1 year ago

jatin-tarachandani commented 1 year ago

Library

React Components / v9 (@fluentui/react-components)

System Info

System:
    OS: macOS 12.5.1
    CPU: (16) x64 Intel(R) Core(TM) i9-9980HK CPU @ 2.40GHz
    Memory: 74.91 MB / 32.00 GB
    Shell: 5.8.1 - /bin/zsh
  Browsers:
    Chrome: 114.0.5735.198
    Edge: 114.0.1823.67
    Safari: 15.6.1

Are you reporting Accessibility issue?

None

Reproduction

codesandbox.io/jovial-gould-nfydg8

Bug Description

Actual Behavior

When attempting to import and use as shown in the examples on the documentation website https://react.fluentui.dev/?path=/docs/components-dialog--default, it says "export 'DialogOpenChangeData' (imported as 'reactComponents') was not found in '@fluentui/react-components'" in the codesandbox link which is a direct copy of the code on the documentation website, the import is not being recognised.

Expected Behavior

The export of DialogOpenChangeData (which is present in my installation of the library) should be imported and usable.

Logs

No response

Requested priority

Blocking

Products/sites affected

No response

Are you willing to submit a PR to fix?

no

Validations

jatin-tarachandani commented 1 year ago

Apologies: The issue is with react-components library, not react-northstar

behowell commented 1 year ago

Hi @jatin-tarachandani , your repro link is a 404. Can you update the repro link?

I tried opening the Trigger Outside Dialog example in codesandbox, which imports DialogOpenChangeData, and it compiles without issue: https://codesandbox.io/s/z6l97l?file=/example.tsx

layershifter commented 1 year ago

As @behowell wrote, it's exported in @fluentui/react-components:

https://github.com/microsoft/fluentui/blob/99e835ade7328fcb47114f5d5d293c36c2665ae1/packages/react-components/react-components/src/index.ts#L809