Adds Tests For Fluent Button Web Component

microsoft / fluentui

Fluent UI web represents a collection of utilities, React components, and web components for building web applications.

https://react.fluentui.dev

Other

17.87k stars 2.66k forks source link

Adds Tests For Fluent Button Web Component #28849

Closed halerankin closed 2 weeks ago

halerankin commented 9 months ago

Adds Playwright tests for Fluent Button web component.

fabricteam commented 9 months ago

🕵 fluentui-web-components-v3 No visual regressions between this PR and main

fabricteam commented 9 months ago

📊 Bundle size report

_{🤖 This report was generated against fa0748a5d83e8c6b544c692e0346602f94980a4c}

size-auditor[bot] commented 9 months ago

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: e9c7c3b41d74ab6edf37ce7e743bd27b98008368 (build)

codesandbox-ci[bot] commented 9 months ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 5e832244260e59afcc35d783636155ff84930a1e:

Sandbox	Source
@fluentui/react 8 starter	Configuration
@fluentui/react-components 9 starter	Configuration

halerankin commented 9 months ago

Note: I'm getting flaky tests. I'll review and make adjustments,

levithomason commented 9 months ago

The build appears to have passed, but it seems 3 tests failed? They are marked as "flaky" in the logs: https://uifabric.visualstudio.com/fabricpublic/_build/results?buildId=315660&view=logs&j=258ec178-2d8b-5611-7b9b-60c5c95dae55&t=254ee48e-1503-524f-f75e-e2c69d0380f5&l=1501

Tests

Flaky Tests

Side note, I would highly encourage that we consider only 0 flaky tests to be a pass. Otherwise, we'll end up with many flaky tests and low confidence.

JustSlone commented 2 weeks ago

@halerankin closing as that is the only way to stop notifying reviewers. Please update your PR to point to master following this guide: https://github.com/microsoft/fluentui/pull/31361 and reopen when it's updated. Thanks!