microsoft / fluentui

Fluent UI web represents a collection of utilities, React components, and web components for building web applications.
https://react.fluentui.dev
Other
18.28k stars 2.71k forks source link

[Bug]: Theme Designer - Default text colours (neutral foregrounds & black) are incorrect #29853

Open JamesBurnside opened 9 months ago

JamesBurnside commented 9 months ago

Library

React / v8 (@fluentui/react)

System Info

On site: https://fluentuipr.z22.web.core.windows.net/heads/master/theming-designer/index.html

Are you reporting Accessibility issue?

yes

Reproduction

https://fluentuipr.z22.web.core.windows.net/heads/master/theming-designer/index.html

Bug Description

This is the same as #10958 and the fix in that issue is not actively working and theme generator produces non-ally compliant results.

Video:

https://github.com/microsoft/fluentui/assets/2684369/2b45bbb5-713f-4007-8345-50f537d063b1

Actual Behavior

Replace the default text color in the theme generator with the same value. The result is different to the default and not ally compliant.

Expected Behavior

Theme generator should produce the same, a11y compliant, result as the defaults when the site first loads.

Logs

No response

Requested priority

High

Products/sites affected

No response

Are you willing to submit a PR to fix?

yes

Validations

mark-wiemer commented 1 month ago

keep open

mark-wiemer commented 1 month ago

I can still repro this and I'm struggling overall to create an accessible dark theme with the existing tools, ref also #25794