microsoft / fluentui

Fluent UI web represents a collection of utilities, React components, and web components for building web applications.
https://react.fluentui.dev
Other
18.43k stars 2.72k forks source link

Incorrect scaling ratio in Horizontal bar chart #30129

Open krkshitij opened 10 months ago

krkshitij commented 10 months ago

Actual Behavior

The scaling ratio is defined in the HorizontalBarChart as follows:

const scalingRatio = sumOfPercent !== 0 ? (sumOfPercent - totalMarginPercent) / 100 : 1;

Expected Behavior

The total width required for rendering all the bar segments without any gaps is derived by subtracting the total width of all the gaps (totalMarginPercent) from 100. The scaling ratio is correctly defined in both the MultiStackedBarChart and the StackedBarChart as follows:

const scalingRatio = sumOfPercent !== 0 ? sumOfPercent / (100 - totalMarginPercent) : 1;
2div commented 10 months ago

Hi , I would like to handle this task. Can you provide guide how to start ? Thank you

krkshitij commented 10 months ago

@2div Thank you for expressing your interest in contributing to the Fluent Charting library. You can join our public Discord channel https://aka.ms/FluentCharting/discord and we can continue discussing there.

2div commented 10 months ago

@krkshitij Thank you for your response. i will join

krkshitij commented 3 months ago

keep open