microsoft / fluentui

Fluent UI web represents a collection of utilities, React components, and web components for building web applications.
https://react.fluentui.dev
Other
17.87k stars 2.66k forks source link

Web Components V3 - Popover dev spec #30271

Closed bearcat-msft closed 2 weeks ago

bearcat-msft commented 4 months ago

Popover

A popover is a small surface that appears when someone interacts with a component to give nonessential, contextual information without blocking them.

Popovers can have structured content and interactive components. If you need to show a more complex layout or block the page behind, try a dialog. For unstructured plain text, try a tooltip.

fabricteam commented 4 months ago

📊 Bundle size report

🤖 This report was generated against 12da47698c9121c0345c2f0db481cbae7a91b66e

fabricteam commented 4 months ago

🕵 fluentui-web-components-v3 No visual regressions between this PR and main

size-auditor[bot] commented 4 months ago

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 12da47698c9121c0345c2f0db481cbae7a91b66e (build)

codesandbox-ci[bot] commented 4 months ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 48724f7888840d3299470e4346f81a790aa2c4f4:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration
Hotell commented 4 months ago

looks like bad merge/rebase ?

would you mind removing reviewers that are not intended to review this PR ? ty

image
bearcat-msft commented 4 months ago

looks like bad merge/rebase ?

would you mind removing reviewers that are not intended to review this PR ? ty

image

No problem, thanks for the heads up.

JustSlone commented 2 weeks ago

@bearcat-msft closing as that is the only way to stop notifying reviewers. Please update your PR to point to master following this guide: https://github.com/microsoft/fluentui/pull/31361 and reopen when it's updated. Thanks!