microsoft / fluentui

Fluent UI web represents a collection of utilities, React components, and web components for building web applications.
https://react.fluentui.dev
Other
18.6k stars 2.75k forks source link

[Bug]: v9 bundleIcon does not pass down primaryFill #30272

Closed ReillyBova closed 5 months ago

ReillyBova commented 10 months ago

System Info

Relevant packages: 

    "@fluentui/react-components": "9.44.1",
    "@fluentui/react-icons": "2.0.224",

Are you reporting Accessibility issue?

None

Reproduction

See repro from docs

Bug Description

Actual Behavior

The bundleIcon util documented here does not behave as expected.

In particular, it does not pass down the primaryFill prop to the internally rendered icon, which is a real issue.

Additionally, the documentation linked above has other problems: "iconClass" appears meaningless, and the node is missing the filled prop required to default to the filled variant on no-hover.

As a bit of feedback to the component design / dev team, we are finding the v9 icon system a bit cumbersome to work with compared to previous Fluent libraries that we've worked with. In particular, it'd be very helpful if a pre-bundled version of each icon was available to import directly from the fluent-icons library.

Expected Behavior

The color passed via primaryFill prop to the root export of bundleIcon should apply to the rendered icon. In the docs example, a purple filled icon should be visible, but I am seeing a regular icon with the active font color applied.

Logs

No response

Requested priority

Blocking

Products/sites affected

Viva Insights

Are you willing to submit a PR to fix?

yes

Validations

ReillyBova commented 10 months ago

Here is a PR: https://github.com/microsoft/fluentui-system-icons/pull/679

micahgodbolt commented 10 months ago

this can be closed as soon as we pull in the latest icons

microsoft-github-policy-service[bot] commented 5 months ago

Because this issue has not had activity for over 150 days, we're automatically closing it for house-keeping purposes.

Still require assistance? Please, create a new issue with up-to date details.