Closed ReillyBova closed 5 months ago
this can be closed as soon as we pull in the latest icons
Because this issue has not had activity for over 150 days, we're automatically closing it for house-keeping purposes.
Still require assistance? Please, create a new issue with up-to date details.
System Info
Are you reporting Accessibility issue?
None
Reproduction
See repro from docs
Bug Description
Actual Behavior
The bundleIcon util documented here does not behave as expected.
In particular, it does not pass down the
primaryFill
prop to the internally rendered icon, which is a real issue.Additionally, the documentation linked above has other problems: "iconClass" appears meaningless, and the node is missing the
filled
prop required to default to the filled variant on no-hover.As a bit of feedback to the component design / dev team, we are finding the v9 icon system a bit cumbersome to work with compared to previous Fluent libraries that we've worked with. In particular, it'd be very helpful if a pre-bundled version of each icon was available to import directly from the fluent-icons library.
Expected Behavior
The color passed via primaryFill prop to the root export of bundleIcon should apply to the rendered icon. In the docs example, a purple filled icon should be visible, but I am seeing a regular icon with the active font color applied.
Logs
No response
Requested priority
Blocking
Products/sites affected
Viva Insights
Are you willing to submit a PR to fix?
yes
Validations