microsoft / fluentui

Fluent UI web represents a collection of utilities, React components, and web components for building web applications.
https://react.fluentui.dev
Other
18.41k stars 2.72k forks source link

[NeutralColor]: Add possibility to change all Neutral Color/Greys with createLightTheme/createDarkTheme #30459

Open rgcircum opened 8 months ago

rgcircum commented 8 months ago

Library

React Components / v9 (@fluentui/react-components)

Describe the feature that you would like added

Add possibility to change all Neutral Color/Greys with createLightTheme/createDarkTheme.

Actually, method createLightTheme/createDarkTheme do not provided any possibility to change Neutral colors (like Fluent UI8).

It's a problem if the brand color contains a colored grey + primary color.

The only current way i finded, is create a complete Fluent UI 8 theme (https://codepen.io/pen) and use createV9Theme from @fluentui/react-migration-v8-v9 package

It's not a good way.

Possible solution :

Pass a greys Ramp to method.

createLightTheme: (brand: BrandVariants, greys? : Greys) => Theme

PS : For me it'a bug, i have marked this as feature

Have you discussed this feature with our team

No response

Additional context

No response

Validations

Priority

Normal

rgcircum commented 4 months ago

@ValentinaKozlova you have any news for this ?

ValentinaKozlova commented 4 months ago

@ValentinaKozlova you have any news for this ?

Not yet. It needs PM review

tudorpopams commented 4 months ago

@brandonthomas @EdDaWord do you have any plans for this feature in the token pipeline?

rgcircum commented 2 months ago

@ValentinaKozlova @brandonthomas @EdDaWord you have any news for this ?

We still can't create a dark theme with anything other than black. For example, we can't create a theme like this one: https://colorswall.com/en/palette/34772 or https://colorswall.com/fr/palette/1330