search

microsoft / fluentui

Fluent UI web represents a collection of utilities, React components, and web components for building web applications.
https://react.fluentui.dev
Other
18.16k stars 2.7k forks source link

[Feature]: Icon map as global object or UMD #30785

Open gabbsmo opened 4 months ago

gabbsmo commented 4 months ago

Library

React Components / v9 (@fluentui/react-components)

Describe the feature that you would like added

The icon map is currently available as: amd module, commonjs module, es module and typescript. This makes it hard to integrate into legacy web applications that need updated look and feel but do not use a module bundler.

One idea is to bundle the icon map as a global object, i.e. window.fabric.fileTypesIconMap. Another common pattern in the JavaScript community is the Universal Module Definition (UMD) that exports to either a amd, cjs or global object, depending on what module api is available in the environment.

Have you discussed this feature with our team

No response

Additional context

No response

Validations

Priority

None

tudorpopams commented 4 months ago

@Hotell do you have any insight about this? Would it be something feasible for us to do?

Hotell commented 3 months ago

@gabbsmo what type of icon map are you referring ? this seems to be v8 related -> @fluentui/react-file-type-icons can you verify ?

gabbsmo commented 3 months ago

You are right, it is that npm package.

microsoft-github-policy-service[bot] commented 2 months ago

no assignees

Gentle ping that this issue needs attention.