microsoft / fluentui

Fluent UI web represents a collection of utilities, React components, and web components for building web applications.
https://react.fluentui.dev
Other
17.75k stars 2.65k forks source link

feat(test-ssr): add custom esbuild-plugin to properly resolve TS path aliases which stopped working starting esbuild 0.19 #31227

Closed Hotell closed 2 weeks ago

Hotell commented 2 weeks ago

Previous Behavior

Esbuild stopped resolving TS path aliases since version 0.19 (BREAKING CHANGE)

https://github.com/evanw/esbuild/blob/main/CHANGELOG.md#0190 /

image

With this in place our SSR test are working by "accident" ( lage scheduling build task prior to executing test-ssr ), and following pipeline issues might start happening at any time (https://github.com/microsoft/fluentui/pull/29327).

This issue started to appear in one of PR's that removes a deprecated package from the repo https://github.com/microsoft/fluentui/pull/31007

New Behavior

More context

Even if we added build task as pre-requirement for test-ssr pipeline issues would appear sooner than later.

So we can either:

Ideal solution is to have both so until that type-checking epic is done

Related Issue(s)

fabricteam commented 2 weeks ago

📊 Bundle size report

✅ No changes found

codesandbox-ci[bot] commented 2 weeks ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.