microsoft / fluentui

Fluent UI web represents a collection of utilities, React components, and web components for building web applications.
https://react.fluentui.dev
Other
17.75k stars 2.65k forks source link

bugfix(react-dialog): remove triple slash ref #31230

Closed bsunderhus closed 2 weeks ago

bsunderhus commented 2 weeks ago

Previous Behavior

New Behavior

  1. removes triple slash reference from e2e tests

Related Issue(s)

codesandbox-ci[bot] commented 2 weeks ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

fabricteam commented 2 weeks ago

Perf Analysis (@fluentui/react-components)

Scenario Render type Master Ticks PR Ticks Iterations Status
FluentProviderWithTheme virtual-rerender 38 32 10 Possible regression
FluentProviderWithTheme virtual-rerender-with-unmount 72 76 10 Possible regression
All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 625 651 5000
Button mount 307 302 5000
Field mount 1105 1109 5000
FluentProvider mount 742 707 5000
FluentProviderWithTheme mount 82 76 10
FluentProviderWithTheme virtual-rerender 38 32 10 Possible regression
FluentProviderWithTheme virtual-rerender-with-unmount 72 76 10 Possible regression
MakeStyles mount 871 858 50000
Persona mount 1758 1756 5000
SpinButton mount 1387 1409 5000
SwatchPicker mount 1523 1548 5000

fabricteam commented 2 weeks ago

📊 Bundle size report

✅ No changes found

Hotell commented 2 weeks ago

admin merged - VR pipelines are failing because internal issues with the tool. this PR is needed to unblock master and doesn't affect VR test outcome in any way