feat(workspace-plugin): catch potential issues with running formatFiles on CI and add skipFormat config for tsConfigBaseAllGenerator - Githubissues

microsoft / fluentui

Fluent UI web represents a collection of utilities, React components, and web components for building web applications.

https://react.fluentui.dev

Other

17.75k stars 2.65k forks source link

feat(workspace-plugin): catch potential issues with running formatFiles on CI and add skipFormat config for tsConfigBaseAllGenerator #31233

Closed Hotell closed 2 weeks ago

Hotell commented 2 weeks ago

Previous Behavior

Intermittent issues are still occurring on CI https://uifabric.visualstudio.com/fabricpublic/_build/results?buildId=341231&view=logs&j=e51d397b-0a7b-5b89-4b48-0052e021371d&t=88c41216-94ff-5ca8-d686-48ce16c1eefc

New Behavior

nx formatFiles is using prettier v3 api (which is async) but we are on prettier v2 which is sync.

While unnecessary await shouldn't cause issues it seems it does.

This PR:

mitigates formatFiles calls within split in two generator to 1
extends tsConfigBaseAllGenerator api with skipFormatting config

Related Issue(s)

Follows https://github.com/microsoft/fluentui/pull/31217

fabricteam commented 2 weeks ago

📊 Bundle size report

✅ No changes found

codesandbox-ci[bot] commented 2 weeks ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.