Closed imatiach-msft closed 1 week ago
This pull request is automatically built and testable in CodeSandbox.
To see build info of the built libraries, click here or the icon next to each commit SHA.
Looks good to me. @smhigley what do you think?
is there anything special I need to do to make these github actions run:
/azp run
is there anything special I need to do to make these github actions run:
They have to be run by a core team member. I just kicked em off for you.
Package & Exports | Baseline (minified/GZIP) | PR | Change |
---|---|---|---|
react DetailsList |
229.3 kB 65.63 kB |
229.317 kB 65.63 kB |
17 B |
react Fluent UI React (entire library) |
1.012 MB 281.033 kB |
1.012 MB 281.033 kB |
17 B |
react ShimmeredDetailsList |
240.075 kB 68.397 kB |
240.092 kB 68.397 kB |
17 B |
🤖 This report was generated against cd78d70a00dbeae15585494c8853a5a2730a9f7d
@fluentui/react
)No significant results to display.
Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
---|---|---|---|---|---|
BaseButton | mount | 656 | 653 | 5000 | |
Breadcrumb | mount | 1756 | 1757 | 1000 | |
Checkbox | mount | 1696 | 1728 | 5000 | |
CheckboxBase | mount | 1503 | 1503 | 5000 | |
ChoiceGroup | mount | 3028 | 3007 | 5000 | |
ComboBox | mount | 662 | 679 | 1000 | |
CommandBar | mount | 6881 | 6908 | 1000 | |
ContextualMenu | mount | 16305 | 16115 | 1000 | |
DefaultButton | mount | 795 | 805 | 5000 | |
DetailsRow | mount | 2262 | 2266 | 5000 | |
DetailsRowFast | mount | 2293 | 2284 | 5000 | |
DetailsRowNoStyles | mount | 2065 | 2051 | 5000 | |
Dialog | mount | 2809 | 2644 | 1000 | |
DocumentCardTitle | mount | 239 | 229 | 1000 | |
Dropdown | mount | 2050 | 2036 | 5000 | |
FocusTrapZone | mount | 1186 | 1182 | 5000 | |
FocusZone | mount | 1114 | 1083 | 5000 | |
GroupedList | mount | 38330 | 43200 | 2 | |
GroupedList | virtual-rerender | 20521 | 20705 | 2 | |
GroupedList | virtual-rerender-with-unmount | 50976 | 51730 | 2 | |
GroupedListV2 | mount | 246 | 219 | 2 | |
GroupedListV2 | virtual-rerender | 209 | 223 | 2 | |
GroupedListV2 | virtual-rerender-with-unmount | 218 | 218 | 2 | |
IconButton | mount | 1142 | 1132 | 5000 | |
Label | mount | 345 | 335 | 5000 | |
Layer | mount | 2790 | 2724 | 5000 | |
Link | mount | 401 | 413 | 5000 | |
MenuButton | mount | 998 | 991 | 5000 | |
MessageBar | mount | 21791 | 21805 | 5000 | |
Nav | mount | 2062 | 2051 | 1000 | |
OverflowSet | mount | 793 | 787 | 5000 | |
Panel | mount | 2078 | 1807 | 1000 | |
Persona | mount | 766 | 745 | 1000 | |
Pivot | mount | 898 | 911 | 1000 | |
PrimaryButton | mount | 942 | 925 | 5000 | |
Rating | mount | 4735 | 4710 | 5000 | |
SearchBox | mount | 947 | 905 | 5000 | |
Shimmer | mount | 1927 | 1889 | 5000 | |
Slider | mount | 1376 | 1361 | 5000 | |
SpinButton | mount | 3041 | 3023 | 5000 | |
Spinner | mount | 408 | 388 | 5000 | |
SplitButton | mount | 1916 | 1931 | 5000 | |
Stack | mount | 406 | 408 | 5000 | |
StackWithIntrinsicChildren | mount | 864 | 887 | 5000 | |
StackWithTextChildren | mount | 2625 | 2650 | 5000 | |
SwatchColorPicker | mount | 6492 | 6517 | 5000 | |
TagPicker | mount | 1486 | 1447 | 5000 | |
Text | mount | 385 | 375 | 5000 | |
TextField | mount | 961 | 960 | 5000 | |
ThemeProvider | mount | 874 | 859 | 5000 | |
ThemeProvider | virtual-rerender | 593 | 585 | 5000 | |
ThemeProvider | virtual-rerender-with-unmount | 1326 | 1304 | 5000 | |
Toggle | mount | 589 | 629 | 5000 | |
buttonNative | mount | 200 | 204 | 5000 |
@smhigley gentle ping on this PR, thank you!
Previous Behavior
Currently for draggable columns in the DetailsList DetailsHeader the aria-role or aria-hidden is not defined, which does not conform to accessibility standards.
New Behavior
For the DetailsHeader in the DetailsList, if draggable columns are defined and a dropHint is rendered, set the drop hint to have aria-hidden=true to avoid triggering accessibility issue in accessibility insights.
Related Issue(s)
See issue: https://github.com/microsoft/fluentui/issues/31213