search

microsoft / fluentui

Fluent UI web represents a collection of utilities, React components, and web components for building web applications.
https://react.fluentui.dev
Other
17.79k stars 2.65k forks source link

feat(react-nav-preview): Flagship Nav example #31246

Closed mltejera closed 2 weeks ago

mltejera commented 3 weeks ago

Adds styles for the nav component that will be turned into composed components and re-exported over the course of the next few weeks. Updated content to present a more realistic scenario.

Before: image

After: image

fabricteam commented 3 weeks ago

📊 Bundle size report

✅ No changes found

codesandbox-ci[bot] commented 3 weeks ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

lydsmit commented 3 weeks ago

Hello world!

Hotell commented 3 weeks ago

after running the initial release generator, I'd suggest to do that in separate PR as it's not a good practice to combine adding features with initial release.

tip: also please use github re-request review next time if you submitted changes based on the feedback, otherwise it wont show in peoples github inbox , thus will not be able to look it up. image

mltejera commented 2 weeks ago

after running the initial release generator, I'd suggest to do that in separate PR as it's not a good practice to combine adding features with initial release.

tip: also please use github re-request review next time if you submitted changes based on the feedback, otherwise it wont show in peoples github inbox , thus will not be able to look it up. image

Agreed that separation is good practice. I don't think I'm adding any features in this PR though? Just doing some pixel pushing and creating a realistic example.