search

microsoft / fluentui

Fluent UI web represents a collection of utilities, React components, and web components for building web applications.
https://react.fluentui.dev
Other
17.75k stars 2.65k forks source link

(chore)Docs: Text updates to the new dev docs #31260

Closed mltejera closed 1 week ago

mltejera commented 2 weeks ago

Updating some docs after getting feedback from a new engineer to the team.

codesandbox-ci[bot] commented 2 weeks ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

fabricteam commented 2 weeks ago

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 619 639 5000
Button mount 304 298 5000
Field mount 1116 1104 5000
FluentProvider mount 706 702 5000
FluentProviderWithTheme mount 85 92 10
FluentProviderWithTheme virtual-rerender 42 34 10
FluentProviderWithTheme virtual-rerender-with-unmount 72 72 10
MakeStyles mount 868 876 50000
Persona mount 1769 1730 5000
SpinButton mount 1406 1400 5000
SwatchPicker mount 1493 1526 5000

fabricteam commented 2 weeks ago

🕵 fluentuiv8 No visual regressions between this PR and main

fabricteam commented 2 weeks ago

Perf Analysis (@fluentui/react-northstar)

:warning: 1 potential perf regressions detected

Potential regressions comparing to master

Scenario Current PR Ticks Baseline Ticks Ratio Regression Analysis
AccordionMinimalPerf.default 77 85 0.91:1 analysis
Perf tests with no regressions Scenario | Current PR Ticks | Baseline Ticks | Ratio :--- | ---:| ---:| ---: ButtonMinimalPerf.default | [101](https://fluentuipr.z22.web.core.windows.net/pull/31260/perf-test-northstar/ButtonMinimalPerf.default.html) | [87](https://fluentuipr.z22.web.core.windows.net/pull/31260/perf-test-northstar/ButtonMinimalPerf.default_base.html) | 1.16:1 PortalMinimalPerf.default | [95](https://fluentuipr.z22.web.core.windows.net/pull/31260/perf-test-northstar/PortalMinimalPerf.default.html) | [83](https://fluentuipr.z22.web.core.windows.net/pull/31260/perf-test-northstar/PortalMinimalPerf.default_base.html) | 1.14:1 FormMinimalPerf.default | [231](https://fluentuipr.z22.web.core.windows.net/pull/31260/perf-test-northstar/FormMinimalPerf.default.html) | [205](https://fluentuipr.z22.web.core.windows.net/pull/31260/perf-test-northstar/FormMinimalPerf.default_base.html) | 1.13:1 DividerMinimalPerf.default | [212](https://fluentuipr.z22.web.core.windows.net/pull/31260/perf-test-northstar/DividerMinimalPerf.default.html) | [196](https://fluentuipr.z22.web.core.windows.net/pull/31260/perf-test-northstar/DividerMinimalPerf.default_base.html) | 1.08:1 AttachmentMinimalPerf.default | [89](https://fluentuipr.z22.web.core.windows.net/pull/31260/perf-test-northstar/AttachmentMinimalPerf.default.html) | [83](https://fluentuipr.z22.web.core.windows.net/pull/31260/perf-test-northstar/AttachmentMinimalPerf.default_base.html) | 1.07:1 FlexMinimalPerf.default | [158](https://fluentuipr.z22.web.core.windows.net/pull/31260/perf-test-northstar/FlexMinimalPerf.default.html) | [148](https://fluentuipr.z22.web.core.windows.net/pull/31260/perf-test-northstar/FlexMinimalPerf.default_base.html) | 1.07:1 TextMinimalPerf.default | [210](https://fluentuipr.z22.web.core.windows.net/pull/31260/perf-test-northstar/TextMinimalPerf.default.html) | [196](https://fluentuipr.z22.web.core.windows.net/pull/31260/perf-test-northstar/TextMinimalPerf.default_base.html) | 1.07:1 TreeWith60ListItems.default | [89](https://fluentuipr.z22.web.core.windows.net/pull/31260/perf-test-northstar/TreeWith60ListItems.default.html) | [83](https://fluentuipr.z22.web.core.windows.net/pull/31260/perf-test-northstar/TreeWith60ListItems.default_base.html) | 1.07:1 VideoMinimalPerf.default | [461](https://fluentuipr.z22.web.core.windows.net/pull/31260/perf-test-northstar/VideoMinimalPerf.default.html) | [434](https://fluentuipr.z22.web.core.windows.net/pull/31260/perf-test-northstar/VideoMinimalPerf.default_base.html) | 1.06:1 AttachmentSlotsPerf.default | [656](https://fluentuipr.z22.web.core.windows.net/pull/31260/perf-test-northstar/AttachmentSlotsPerf.default.html) | [626](https://fluentuipr.z22.web.core.windows.net/pull/31260/perf-test-northstar/AttachmentSlotsPerf.default_base.html) | 1.05:1 MenuMinimalPerf.default | [521](https://fluentuipr.z22.web.core.windows.net/pull/31260/perf-test-northstar/MenuMinimalPerf.default.html) | [497](https://fluentuipr.z22.web.core.windows.net/pull/31260/perf-test-northstar/MenuMinimalPerf.default_base.html) | 1.05:1 ReactionMinimalPerf.default | [221](https://fluentuipr.z22.web.core.windows.net/pull/31260/perf-test-northstar/ReactionMinimalPerf.default.html) | [210](https://fluentuipr.z22.web.core.windows.net/pull/31260/perf-test-northstar/ReactionMinimalPerf.default_base.html) | 1.05:1 StatusMinimalPerf.default | [411](https://fluentuipr.z22.web.core.windows.net/pull/31260/perf-test-northstar/StatusMinimalPerf.default.html) | [393](https://fluentuipr.z22.web.core.windows.net/pull/31260/perf-test-northstar/StatusMinimalPerf.default_base.html) | 1.05:1 BoxMinimalPerf.default | [199](https://fluentuipr.z22.web.core.windows.net/pull/31260/perf-test-northstar/BoxMinimalPerf.default.html) | [192](https://fluentuipr.z22.web.core.windows.net/pull/31260/perf-test-northstar/BoxMinimalPerf.default_base.html) | 1.04:1 ButtonOverridesMissPerf.default | [649](https://fluentuipr.z22.web.core.windows.net/pull/31260/perf-test-northstar/ButtonOverridesMissPerf.default.html) | [622](https://fluentuipr.z22.web.core.windows.net/pull/31260/perf-test-northstar/ButtonOverridesMissPerf.default_base.html) | 1.04:1 LayoutMinimalPerf.default | [210](https://fluentuipr.z22.web.core.windows.net/pull/31260/perf-test-northstar/LayoutMinimalPerf.default.html) | [202](https://fluentuipr.z22.web.core.windows.net/pull/31260/perf-test-northstar/LayoutMinimalPerf.default_base.html) | 1.04:1 ListNestedPerf.default | [329](https://fluentuipr.z22.web.core.windows.net/pull/31260/perf-test-northstar/ListNestedPerf.default.html) | [317](https://fluentuipr.z22.web.core.windows.net/pull/31260/perf-test-northstar/ListNestedPerf.default_base.html) | 1.04:1 RefMinimalPerf.default | [113](https://fluentuipr.z22.web.core.windows.net/pull/31260/perf-test-northstar/RefMinimalPerf.default.html) | [109](https://fluentuipr.z22.web.core.windows.net/pull/31260/perf-test-northstar/RefMinimalPerf.default_base.html) | 1.04:1 SkeletonMinimalPerf.default | [199](https://fluentuipr.z22.web.core.windows.net/pull/31260/perf-test-northstar/SkeletonMinimalPerf.default.html) | [192](https://fluentuipr.z22.web.core.windows.net/pull/31260/perf-test-northstar/SkeletonMinimalPerf.default_base.html) | 1.04:1 AlertMinimalPerf.default | [165](https://fluentuipr.z22.web.core.windows.net/pull/31260/perf-test-northstar/AlertMinimalPerf.default.html) | [160](https://fluentuipr.z22.web.core.windows.net/pull/31260/perf-test-northstar/AlertMinimalPerf.default_base.html) | 1.03:1 GridMinimalPerf.default | [196](https://fluentuipr.z22.web.core.windows.net/pull/31260/perf-test-northstar/GridMinimalPerf.default.html) | [191](https://fluentuipr.z22.web.core.windows.net/pull/31260/perf-test-northstar/GridMinimalPerf.default_base.html) | 1.03:1 ListCommonPerf.default | [384](https://fluentuipr.z22.web.core.windows.net/pull/31260/perf-test-northstar/ListCommonPerf.default.html) | [374](https://fluentuipr.z22.web.core.windows.net/pull/31260/perf-test-northstar/ListCommonPerf.default_base.html) | 1.03:1 ListWith60ListItems.default | [373](https://fluentuipr.z22.web.core.windows.net/pull/31260/perf-test-northstar/ListWith60ListItems.default.html) | [363](https://fluentuipr.z22.web.core.windows.net/pull/31260/perf-test-northstar/ListWith60ListItems.default_base.html) | 1.03:1 SegmentMinimalPerf.default | [198](https://fluentuipr.z22.web.core.windows.net/pull/31260/perf-test-northstar/SegmentMinimalPerf.default.html) | [192](https://fluentuipr.z22.web.core.windows.net/pull/31260/perf-test-northstar/SegmentMinimalPerf.default_base.html) | 1.03:1 TableManyItemsPerf.default | [1148](https://fluentuipr.z22.web.core.windows.net/pull/31260/perf-test-northstar/TableManyItemsPerf.default.html) | [1114](https://fluentuipr.z22.web.core.windows.net/pull/31260/perf-test-northstar/TableManyItemsPerf.default_base.html) | 1.03:1 ChatMinimalPerf.default | [465](https://fluentuipr.z22.web.core.windows.net/pull/31260/perf-test-northstar/ChatMinimalPerf.default.html) | [454](https://fluentuipr.z22.web.core.windows.net/pull/31260/perf-test-northstar/ChatMinimalPerf.default_base.html) | 1.02:1 HeaderSlotsPerf.default | [461](https://fluentuipr.z22.web.core.windows.net/pull/31260/perf-test-northstar/HeaderSlotsPerf.default.html) | [450](https://fluentuipr.z22.web.core.windows.net/pull/31260/perf-test-northstar/HeaderSlotsPerf.default_base.html) | 1.02:1 ImageMinimalPerf.default | [223](https://fluentuipr.z22.web.core.windows.net/pull/31260/perf-test-northstar/ImageMinimalPerf.default.html) | [219](https://fluentuipr.z22.web.core.windows.net/pull/31260/perf-test-northstar/ImageMinimalPerf.default_base.html) | 1.02:1 ItemLayoutMinimalPerf.default | [711](https://fluentuipr.z22.web.core.windows.net/pull/31260/perf-test-northstar/ItemLayoutMinimalPerf.default.html) | [698](https://fluentuipr.z22.web.core.windows.net/pull/31260/perf-test-northstar/ItemLayoutMinimalPerf.default_base.html) | 1.02:1 ToolbarMinimalPerf.default | [557](https://fluentuipr.z22.web.core.windows.net/pull/31260/perf-test-northstar/ToolbarMinimalPerf.default.html) | [545](https://fluentuipr.z22.web.core.windows.net/pull/31260/perf-test-northstar/ToolbarMinimalPerf.default_base.html) | 1.02:1 TooltipMinimalPerf.default | [1270](https://fluentuipr.z22.web.core.windows.net/pull/31260/perf-test-northstar/TooltipMinimalPerf.default.html) | [1243](https://fluentuipr.z22.web.core.windows.net/pull/31260/perf-test-northstar/TooltipMinimalPerf.default_base.html) | 1.02:1 ChatWithPopoverPerf.default | [198](https://fluentuipr.z22.web.core.windows.net/pull/31260/perf-test-northstar/ChatWithPopoverPerf.default.html) | [196](https://fluentuipr.z22.web.core.windows.net/pull/31260/perf-test-northstar/ChatWithPopoverPerf.default_base.html) | 1.01:1 CheckboxMinimalPerf.default | [1159](https://fluentuipr.z22.web.core.windows.net/pull/31260/perf-test-northstar/CheckboxMinimalPerf.default.html) | [1144](https://fluentuipr.z22.web.core.windows.net/pull/31260/perf-test-northstar/CheckboxMinimalPerf.default_base.html) | 1.01:1 DialogMinimalPerf.default | [449](https://fluentuipr.z22.web.core.windows.net/pull/31260/perf-test-northstar/DialogMinimalPerf.default.html) | [446](https://fluentuipr.z22.web.core.windows.net/pull/31260/perf-test-northstar/DialogMinimalPerf.default_base.html) | 1.01:1 HeaderMinimalPerf.default | [207](https://fluentuipr.z22.web.core.windows.net/pull/31260/perf-test-northstar/HeaderMinimalPerf.default.html) | [204](https://fluentuipr.z22.web.core.windows.net/pull/31260/perf-test-northstar/HeaderMinimalPerf.default_base.html) | 1.01:1 InputMinimalPerf.default | [553](https://fluentuipr.z22.web.core.windows.net/pull/31260/perf-test-northstar/InputMinimalPerf.default.html) | [548](https://fluentuipr.z22.web.core.windows.net/pull/31260/perf-test-northstar/InputMinimalPerf.default_base.html) | 1.01:1 SliderMinimalPerf.default | [737](https://fluentuipr.z22.web.core.windows.net/pull/31260/perf-test-northstar/SliderMinimalPerf.default.html) | [727](https://fluentuipr.z22.web.core.windows.net/pull/31260/perf-test-northstar/SliderMinimalPerf.default_base.html) | 1.01:1 SplitButtonMinimalPerf.default | [2222](https://fluentuipr.z22.web.core.windows.net/pull/31260/perf-test-northstar/SplitButtonMinimalPerf.default.html) | [2209](https://fluentuipr.z22.web.core.windows.net/pull/31260/perf-test-northstar/SplitButtonMinimalPerf.default_base.html) | 1.01:1 TextAreaMinimalPerf.default | [291](https://fluentuipr.z22.web.core.windows.net/pull/31260/perf-test-northstar/TextAreaMinimalPerf.default.html) | [287](https://fluentuipr.z22.web.core.windows.net/pull/31260/perf-test-northstar/TextAreaMinimalPerf.default_base.html) | 1.01:1 TreeMinimalPerf.default | [473](https://fluentuipr.z22.web.core.windows.net/pull/31260/perf-test-northstar/TreeMinimalPerf.default.html) | [468](https://fluentuipr.z22.web.core.windows.net/pull/31260/perf-test-northstar/TreeMinimalPerf.default_base.html) | 1.01:1 ButtonSlotsPerf.default | [308](https://fluentuipr.z22.web.core.windows.net/pull/31260/perf-test-northstar/ButtonSlotsPerf.default.html) | [307](https://fluentuipr.z22.web.core.windows.net/pull/31260/perf-test-northstar/ButtonSlotsPerf.default_base.html) | 1:1 CardMinimalPerf.default | [306](https://fluentuipr.z22.web.core.windows.net/pull/31260/perf-test-northstar/CardMinimalPerf.default.html) | [307](https://fluentuipr.z22.web.core.windows.net/pull/31260/perf-test-northstar/CardMinimalPerf.default_base.html) | 1:1 DropdownMinimalPerf.default | [1431](https://fluentuipr.z22.web.core.windows.net/pull/31260/perf-test-northstar/DropdownMinimalPerf.default.html) | [1428](https://fluentuipr.z22.web.core.windows.net/pull/31260/perf-test-northstar/DropdownMinimalPerf.default_base.html) | 1:1 LoaderMinimalPerf.default | [195](https://fluentuipr.z22.web.core.windows.net/pull/31260/perf-test-northstar/LoaderMinimalPerf.default.html) | [195](https://fluentuipr.z22.web.core.windows.net/pull/31260/perf-test-northstar/LoaderMinimalPerf.default_base.html) | 1:1 MenuButtonMinimalPerf.default | [958](https://fluentuipr.z22.web.core.windows.net/pull/31260/perf-test-northstar/MenuButtonMinimalPerf.default.html) | [962](https://fluentuipr.z22.web.core.windows.net/pull/31260/perf-test-northstar/MenuButtonMinimalPerf.default_base.html) | 1:1 PopupMinimalPerf.default | [347](https://fluentuipr.z22.web.core.windows.net/pull/31260/perf-test-northstar/PopupMinimalPerf.default.html) | [348](https://fluentuipr.z22.web.core.windows.net/pull/31260/perf-test-northstar/PopupMinimalPerf.default_base.html) | 1:1 TableMinimalPerf.default | [251](https://fluentuipr.z22.web.core.windows.net/pull/31260/perf-test-northstar/TableMinimalPerf.default.html) | [251](https://fluentuipr.z22.web.core.windows.net/pull/31260/perf-test-northstar/TableMinimalPerf.default_base.html) | 1:1 CustomToolbarPrototype.default | [1491](https://fluentuipr.z22.web.core.windows.net/pull/31260/perf-test-northstar/CustomToolbarPrototype.default.html) | [1487](https://fluentuipr.z22.web.core.windows.net/pull/31260/perf-test-northstar/CustomToolbarPrototype.default_base.html) | 1:1 AnimationMinimalPerf.default | [300](https://fluentuipr.z22.web.core.windows.net/pull/31260/perf-test-northstar/AnimationMinimalPerf.default.html) | [304](https://fluentuipr.z22.web.core.windows.net/pull/31260/perf-test-northstar/AnimationMinimalPerf.default_base.html) | 0.99:1 EmbedMinimalPerf.default | [1839](https://fluentuipr.z22.web.core.windows.net/pull/31260/perf-test-northstar/EmbedMinimalPerf.default.html) | [1861](https://fluentuipr.z22.web.core.windows.net/pull/31260/perf-test-northstar/EmbedMinimalPerf.default_base.html) | 0.99:1 RadioGroupMinimalPerf.default | [255](https://fluentuipr.z22.web.core.windows.net/pull/31260/perf-test-northstar/RadioGroupMinimalPerf.default.html) | [258](https://fluentuipr.z22.web.core.windows.net/pull/31260/perf-test-northstar/RadioGroupMinimalPerf.default_base.html) | 0.99:1 DatepickerMinimalPerf.default | [3564](https://fluentuipr.z22.web.core.windows.net/pull/31260/perf-test-northstar/DatepickerMinimalPerf.default.html) | [3626](https://fluentuipr.z22.web.core.windows.net/pull/31260/perf-test-northstar/DatepickerMinimalPerf.default_base.html) | 0.98:1 DropdownManyItemsPerf.default | [387](https://fluentuipr.z22.web.core.windows.net/pull/31260/perf-test-northstar/DropdownManyItemsPerf.default.html) | [396](https://fluentuipr.z22.web.core.windows.net/pull/31260/perf-test-northstar/DropdownManyItemsPerf.default_base.html) | 0.98:1 LabelMinimalPerf.default | [212](https://fluentuipr.z22.web.core.windows.net/pull/31260/perf-test-northstar/LabelMinimalPerf.default.html) | [217](https://fluentuipr.z22.web.core.windows.net/pull/31260/perf-test-northstar/LabelMinimalPerf.default_base.html) | 0.98:1 ListMinimalPerf.default | [311](https://fluentuipr.z22.web.core.windows.net/pull/31260/perf-test-northstar/ListMinimalPerf.default.html) | [316](https://fluentuipr.z22.web.core.windows.net/pull/31260/perf-test-northstar/ListMinimalPerf.default_base.html) | 0.98:1 AvatarMinimalPerf.default | [114](https://fluentuipr.z22.web.core.windows.net/pull/31260/perf-test-northstar/AvatarMinimalPerf.default.html) | [117](https://fluentuipr.z22.web.core.windows.net/pull/31260/perf-test-northstar/AvatarMinimalPerf.default_base.html) | 0.97:1 RosterPerf.default | [1565](https://fluentuipr.z22.web.core.windows.net/pull/31260/perf-test-northstar/RosterPerf.default.html) | [1618](https://fluentuipr.z22.web.core.windows.net/pull/31260/perf-test-northstar/RosterPerf.default_base.html) | 0.97:1 ProviderMergeThemesPerf.default | [635](https://fluentuipr.z22.web.core.windows.net/pull/31260/perf-test-northstar/ProviderMergeThemesPerf.default.html) | [654](https://fluentuipr.z22.web.core.windows.net/pull/31260/perf-test-northstar/ProviderMergeThemesPerf.default_base.html) | 0.97:1 IconMinimalPerf.default | [387](https://fluentuipr.z22.web.core.windows.net/pull/31260/perf-test-northstar/IconMinimalPerf.default.html) | [399](https://fluentuipr.z22.web.core.windows.net/pull/31260/perf-test-northstar/IconMinimalPerf.default_base.html) | 0.97:1 ChatDuplicateMessagesPerf.default | [152](https://fluentuipr.z22.web.core.windows.net/pull/31260/perf-test-northstar/ChatDuplicateMessagesPerf.default.html) | [158](https://fluentuipr.z22.web.core.windows.net/pull/31260/perf-test-northstar/ChatDuplicateMessagesPerf.default_base.html) | 0.96:1 ProviderMinimalPerf.default | [199](https://fluentuipr.z22.web.core.windows.net/pull/31260/perf-test-northstar/ProviderMinimalPerf.default.html) | [207](https://fluentuipr.z22.web.core.windows.net/pull/31260/perf-test-northstar/ProviderMinimalPerf.default_base.html) | 0.96:1 CarouselMinimalPerf.default | [258](https://fluentuipr.z22.web.core.windows.net/pull/31260/perf-test-northstar/CarouselMinimalPerf.default.html) | [272](https://fluentuipr.z22.web.core.windows.net/pull/31260/perf-test-northstar/CarouselMinimalPerf.default_base.html) | 0.95:1
fabricteam commented 2 weeks ago

🕵 FluentUIV0 No visual regressions between this PR and main

fabricteam commented 2 weeks ago

📊 Bundle size report

✅ No changes found

fabricteam commented 2 weeks ago

🕵 fluentuiv9 No visual regressions between this PR and main

fabricteam commented 2 weeks ago

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 636 639 5000
Breadcrumb mount 1697 1709 1000
Checkbox mount 1697 1702 5000
CheckboxBase mount 1496 1492 5000
ChoiceGroup mount 3009 3009 5000
ComboBox mount 677 684 1000
CommandBar mount 6696 6680 1000
ContextualMenu mount 15254 14183 1000
DefaultButton mount 796 815 5000
DetailsRow mount 2251 2267 5000
DetailsRowFast mount 2232 2233 5000
DetailsRowNoStyles mount 2169 2088 5000
Dialog mount 2854 2668 1000
DocumentCardTitle mount 235 231 1000
Dropdown mount 2083 2029 5000
FocusTrapZone mount 1165 1156 5000
FocusZone mount 1101 1103 5000
GroupedList mount 42588 42870 2
GroupedList virtual-rerender 20582 20512 2
GroupedList virtual-rerender-with-unmount 51500 51500 2
GroupedListV2 mount 230 218 2
GroupedListV2 virtual-rerender 223 207 2
GroupedListV2 virtual-rerender-with-unmount 222 228 2
IconButton mount 1160 1157 5000
Label mount 341 343 5000
Layer mount 2765 2737 5000
Link mount 396 407 5000
MenuButton mount 986 975 5000
MessageBar mount 22123 22066 5000
Nav mount 2059 2029 1000
OverflowSet mount 801 790 5000
Panel mount 1864 1849 1000
Persona mount 753 771 1000
Pivot mount 931 885 1000
PrimaryButton mount 966 927 5000
Rating mount 4730 4772 5000
SearchBox mount 944 936 5000
Shimmer mount 1908 1946 5000
Slider mount 1373 1328 5000
SpinButton mount 2993 2995 5000
Spinner mount 396 395 5000
SplitButton mount 1899 1896 5000
Stack mount 425 422 5000
StackWithIntrinsicChildren mount 882 871 5000
StackWithTextChildren mount 2689 2673 5000
SwatchColorPicker mount 6399 6460 5000
TagPicker mount 1465 1474 5000
Text mount 381 383 5000
TextField mount 946 902 5000
ThemeProvider mount 871 862 5000
ThemeProvider virtual-rerender 601 591 5000
ThemeProvider virtual-rerender-with-unmount 1287 1304 5000
Toggle mount 637 621 5000
buttonNative mount 187 205 5000

  • © Githubissues.
  • Githubissues is a development platform for aggregating issues.