Closed micahgodbolt closed 5 days ago
This pull request is automatically built and testable in CodeSandbox.
To see build info of the built libraries, click here or the icon next to each commit SHA.
@fluentui/react-components
)Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
---|---|---|---|---|---|
FluentProviderWithTheme | virtual-rerender | 39 | 38 | 10 | Possible regression |
Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
---|---|---|---|---|---|
Avatar | mount | 628 | 625 | 5000 | |
Button | mount | 287 | 315 | 5000 | |
Field | mount | 1144 | 1138 | 5000 | |
FluentProvider | mount | 701 | 698 | 5000 | |
FluentProviderWithTheme | mount | 78 | 77 | 10 | |
FluentProviderWithTheme | virtual-rerender | 39 | 38 | 10 | Possible regression |
FluentProviderWithTheme | virtual-rerender-with-unmount | 75 | 70 | 10 | |
MakeStyles | mount | 830 | 851 | 50000 | |
Persona | mount | 1752 | 1700 | 5000 | |
SpinButton | mount | 1371 | 1396 | 5000 | |
SwatchPicker | mount | 1476 | 1521 | 5000 |
@fluentui/react-northstar
)Package & Exports | Baseline (minified/GZIP) | PR | Change |
---|---|---|---|
react-card Card - All |
103.992 kB 29.35 kB |
110.58 kB 30.763 kB |
6.588 kB 1.413 kB |
react-card Card |
97.003 kB 27.61 kB |
103.592 kB 29.009 kB |
6.589 kB 1.399 kB |
react-checkbox Checkbox |
35.656 kB 12.07 kB |
36.102 kB 12.131 kB |
446 B 61 B |
react-combobox Combobox (including child components) |
104.926 kB 33.812 kB |
105.372 kB 33.874 kB |
446 B 62 B |
react-combobox Dropdown (including child components) |
106.398 kB 33.79 kB |
106.844 kB 33.85 kB |
446 B 60 B |
react-components react-components: Button, FluentProvider & webLightTheme |
71.104 kB 20.52 kB |
71.55 kB 20.584 kB |
446 B 64 B |
react-components react-components: Accordion, Button, FluentProvider, Image, Menu, Popover |
221.287 kB 62.497 kB |
227.85 kB 64.466 kB |
6.563 kB 1.969 kB |
react-components react-components: FluentProvider & webLightTheme |
43.591 kB 14.356 kB |
44.037 kB 14.418 kB |
446 B 62 B |
react-components react-components: entire library |
1.1 MB 267.122 kB |
1.107 MB 268.745 kB |
6.601 kB 1.623 kB |
react-datepicker-compat DatePicker Compat |
227.451 kB 63.531 kB |
234.036 kB 63.791 kB |
6.585 kB 260 B |
react-menu Menu (including children components) |
153.846 kB 46.074 kB |
160.417 kB 47.863 kB |
6.571 kB 1.789 kB |
react-menu Menu (including selectable components) |
156.532 kB 46.623 kB |
163.103 kB 48.431 kB |
6.571 kB 1.808 kB |
react-popover Popover |
128.132 kB 40.174 kB |
134.702 kB 41.84 kB |
6.57 kB 1.666 kB |
react-portal Portal |
13.717 kB 4.886 kB |
14.163 kB 4.948 kB |
446 B 62 B |
react-portal-compat PortalCompatProvider |
7.944 kB 2.588 kB |
8.39 kB 2.64 kB |
446 B 52 B |
react-provider FluentProvider |
23.765 kB 8.662 kB |
24.211 kB 8.721 kB |
446 B 59 B |
react-radio Radio |
32.95 kB 10.252 kB |
33.396 kB 10.316 kB |
446 B 64 B |
react-slider Slider |
39.949 kB 12.968 kB |
40.395 kB 13.024 kB |
446 B 56 B |
react-switch Switch |
35.14 kB 11.199 kB |
35.586 kB 11.256 kB |
446 B 57 B |
react-table DataGrid |
168.828 kB 46.848 kB |
175.423 kB 48.495 kB |
6.595 kB 1.647 kB |
react-table Table (Primitives only) |
45.324 kB 14.116 kB |
45.77 kB 14.174 kB |
446 B 58 B |
react-table Table as DataGrid |
137.912 kB 37.14 kB |
144.512 kB 38.788 kB |
6.6 kB 1.648 kB |
react-table Table (Selection only) |
76.328 kB 20.545 kB |
76.774 kB 20.602 kB |
446 B 57 B |
react-table Table (Sort only) |
74.971 kB 20.148 kB |
75.417 kB 20.205 kB |
446 B 57 B |
react-tag-picker-preview @fluentui/react-tag-picker-preview - package |
188.273 kB 55.749 kB |
194.874 kB 55.989 kB |
6.601 kB 240 B |
react-timepicker-compat TimePicker |
106.944 kB 35.169 kB |
107.39 kB 35.223 kB |
446 B 54 B |
react-toast Toast (including Toaster) |
98.667 kB 29.793 kB |
105.235 kB 31.333 kB |
6.568 kB 1.54 kB |
react-tooltip Tooltip |
54.664 kB 19.206 kB |
55.11 kB 19.268 kB |
446 B 62 B |
🤖 This report was generated against cca849d98ac0b9be7c0081661f2a22f6d8eb619b
@fluentui/react
)No significant results to display.
Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
---|---|---|---|---|---|
BaseButton | mount | 620 | 631 | 5000 | |
Breadcrumb | mount | 1682 | 1686 | 1000 | |
Checkbox | mount | 1698 | 1717 | 5000 | |
CheckboxBase | mount | 1480 | 1478 | 5000 | |
ChoiceGroup | mount | 3021 | 2932 | 5000 | |
ComboBox | mount | 661 | 671 | 1000 | |
CommandBar | mount | 6546 | 6486 | 1000 | |
ContextualMenu | mount | 12193 | 12136 | 1000 | |
DefaultButton | mount | 787 | 779 | 5000 | |
DetailsRow | mount | 2214 | 2225 | 5000 | |
DetailsRowFast | mount | 2218 | 2262 | 5000 | |
DetailsRowNoStyles | mount | 1995 | 2075 | 5000 | |
Dialog | mount | 2780 | 2616 | 1000 | |
DocumentCardTitle | mount | 239 | 226 | 1000 | |
Dropdown | mount | 1974 | 1993 | 5000 | |
FocusTrapZone | mount | 1138 | 1154 | 5000 | |
FocusZone | mount | 1087 | 1077 | 5000 | |
GroupedList | mount | 41547 | 41873 | 2 | |
GroupedList | virtual-rerender | 18108 | 20106 | 2 | |
GroupedList | virtual-rerender-with-unmount | 50985 | 50747 | 2 | |
GroupedListV2 | mount | 225 | 222 | 2 | |
GroupedListV2 | virtual-rerender | 214 | 216 | 2 | |
GroupedListV2 | virtual-rerender-with-unmount | 227 | 226 | 2 | |
IconButton | mount | 1140 | 1136 | 5000 | |
Label | mount | 333 | 336 | 5000 | |
Layer | mount | 2791 | 2758 | 5000 | |
Link | mount | 392 | 396 | 5000 | |
MenuButton | mount | 995 | 986 | 5000 | |
MessageBar | mount | 21942 | 21640 | 5000 | |
Nav | mount | 2018 | 2032 | 1000 | |
OverflowSet | mount | 782 | 794 | 5000 | |
Panel | mount | 1826 | 1800 | 1000 | |
Persona | mount | 709 | 754 | 1000 | |
Pivot | mount | 925 | 895 | 1000 | |
PrimaryButton | mount | 883 | 911 | 5000 | |
Rating | mount | 4680 | 4600 | 5000 | |
SearchBox | mount | 907 | 909 | 5000 | |
Shimmer | mount | 1883 | 1925 | 5000 | |
Slider | mount | 1367 | 1328 | 5000 | |
SpinButton | mount | 2954 | 2989 | 5000 | |
Spinner | mount | 398 | 390 | 5000 | |
SplitButton | mount | 1881 | 1878 | 5000 | |
Stack | mount | 413 | 408 | 5000 | |
StackWithIntrinsicChildren | mount | 862 | 872 | 5000 | |
StackWithTextChildren | mount | 2660 | 2679 | 5000 | |
SwatchColorPicker | mount | 6409 | 6435 | 5000 | |
TagPicker | mount | 1438 | 1416 | 5000 | |
Text | mount | 379 | 375 | 5000 | |
TextField | mount | 939 | 946 | 5000 | |
ThemeProvider | mount | 850 | 835 | 5000 | |
ThemeProvider | virtual-rerender | 598 | 570 | 5000 | |
ThemeProvider | virtual-rerender-with-unmount | 1301 | 1287 | 5000 | |
Toggle | mount | 616 | 596 | 5000 | |
buttonNative | mount | 185 | 190 | 5000 |
The bundle size reporting seems to be really off. The change (https://github.com/microsoft/keyborg/pull/80) has 446B/57B and there is only one instance of keyborg in the app. It cannot possibly result in multiple Kb increase.
yarn.lock seems to be wrong, there is still a mention of 2.5.0 in it.
yarn.lock seems to be wrong, there is still a mention of 2.5.0 in it.
I suppose I need to bump keyborg in Tabster first to get rid of the 2.5.0 reference.
yarn.lock seems to be wrong, there is still a mention of 2.5.0 in it.
I suppose I need to bump keyborg in Tabster first to get rid of the 2.5.0 reference.
yes, it was the case: https://github.com/microsoft/fluentui/pull/31268 — this is a version with Tabster that has Keyborg 2.6.0 bump and the bundle is fine.
FYI @micahgodbolt we use solely forks for PR's, please follow that next time you create PR 🙏
Update keyborg to 2.6.0 to fix iOS touch bug https://github.com/microsoft/keyborg/issues/79