microsoft / fluentui

Fluent UI web represents a collection of utilities, React components, and web components for building web applications.
https://react.fluentui.dev
Other
17.75k stars 2.65k forks source link

chore(react-tag-picker): bug bash follow up #31272

Closed bsunderhus closed 1 week ago

bsunderhus commented 2 weeks ago

Previous Behavior

New Behavior

  1. adds TagPicker custom style hooks
  2. removes TODO comments
  3. fix style problems
  4. adds aria-expanded back to expandIcon
  5. adds aria-owns to TagPickerControl root

Related Issue(s)

codesandbox-ci[bot] commented 2 weeks ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

fabricteam commented 2 weeks ago

📊 Bundle size report

Package & Exports Baseline (minified/GZIP) PR Change
react-tag-picker-preview
@fluentui/react-tag-picker-preview - package
188.719 kB
55.819 kB
189.041 kB
55.839 kB
322 B
20 B
Unchanged fixtures | Package & Exports | Size (minified/GZIP) | | ----------------- | -------------------: | | global-context
createContext | `510 B`
`328 B` | | global-context
createContextSelector | `537 B`
`339 B` | | react-accordion
Accordion (including children components) | `101.386 kB`
`30.643 kB` | | react-alert
Alert | `83.737 kB`
`23.475 kB` | | react-avatar
Avatar | `50.175 kB`
`15.944 kB` | | react-avatar
AvatarGroup | `19.702 kB`
`7.794 kB` | | react-avatar
AvatarGroupItem | `64.829 kB`
`20.272 kB` | | react-badge
Badge | `26.905 kB`
`8.73 kB` | | react-badge
CounterBadge | `27.806 kB`
`9.025 kB` | | react-badge
PresenceBadge | `25.311 kB`
`9.307 kB` | | react-breadcrumb
@fluentui/react-breadcrumb - package | `117.263 kB`
`32.241 kB` | | react-button
Button | `39.513 kB`
`11.17 kB` | | react-button
CompoundButton | `46.874 kB`
`12.662 kB` | | react-button
MenuButton | `44.292 kB`
`12.544 kB` | | react-button
SplitButton | `52.306 kB`
`14.135 kB` | | react-button
ToggleButton | `56.558 kB`
`13.068 kB` | | react-calendar-compat
Calendar Compat | `153.874 kB`
`40.203 kB` | | react-card
Card - All | `104.438 kB`
`29.41 kB` | | react-card
Card | `97.449 kB`
`27.681 kB` | | react-card
CardFooter | `13.971 kB`
`5.626 kB` | | react-card
CardHeader | `16.214 kB`
`6.386 kB` | | react-card
CardPreview | `14.015 kB`
`5.752 kB` | | react-checkbox
Checkbox | `36.102 kB`
`12.131 kB` | | react-combobox
Combobox (including child components) | `105.372 kB`
`33.874 kB` | | react-combobox
Dropdown (including child components) | `106.844 kB`
`33.85 kB` | | react-components
react-components: Button, FluentProvider & webLightTheme | `71.55 kB`
`20.584 kB` | | react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover | `221.733 kB`
`62.557 kB` | | react-components
react-components: FluentProvider & webLightTheme | `44.037 kB`
`14.418 kB` | | react-components
react-components: entire library | `1.1 MB`
`267.187 kB` | | react-datepicker-compat
DatePicker Compat | `227.897 kB`
`63.584 kB` | | react-dialog
Dialog (including children components) | `117.345 kB`
`36.161 kB` | | react-divider
Divider | `20.922 kB`
`7.791 kB` | | react-field
Field | `22.976 kB`
`8.722 kB` | | react-image
Image | `15.745 kB`
`6.231 kB` | | react-input
Input | `28.122 kB`
`9.36 kB` | | react-jsx-runtime
Classic Pragma | `1.057 kB`
`530 B` | | react-jsx-runtime
JSX Dev Runtime | `3.781 kB`
`1.646 kB` | | react-jsx-runtime
JSX Runtime | `4.377 kB`
`1.881 kB` | | react-label
Label | `14.266 kB`
`5.829 kB` | | react-link
Link | `17.082 kB`
`6.911 kB` | | react-menu
Menu (including children components) | `154.292 kB`
`46.144 kB` | | react-menu
Menu (including selectable components) | `156.978 kB`
`46.695 kB` | | react-message-bar
MessageBar (all components) | `24.204 kB`
`8.983 kB` | | react-overflow
hooks only | `12.86 kB`
`4.825 kB` | | react-persona
Persona | `57.066 kB`
`17.821 kB` | | react-popover
Popover | `128.578 kB`
`40.244 kB` | | react-portal
Portal | `14.163 kB`
`4.948 kB` | | react-portal-compat
PortalCompatProvider | `8.39 kB`
`2.64 kB` | | react-positioning
usePositioning | `26.398 kB`
`9.539 kB` | | react-progress
ProgressBar | `17.428 kB`
`6.899 kB` | | react-provider
FluentProvider | `24.211 kB`
`8.721 kB` | | react-radio
Radio | `33.396 kB`
`10.316 kB` | | react-radio
RadioGroup | `15.354 kB`
`6.265 kB` | | react-select
Select | `28.609 kB`
`10.204 kB` | | react-slider
Slider | `40.395 kB`
`13.024 kB` | | react-spinbutton
SpinButton | `36.78 kB`
`11.789 kB` | | react-spinner
Spinner | `24.729 kB`
`8.348 kB` | | react-swatch-picker-preview
@fluentui/react-swatch-picker-preview - package | `108.862 kB`
`30.32 kB` | | react-switch
Switch | `35.586 kB`
`11.256 kB` | | react-table
DataGrid | `169.274 kB`
`46.907 kB` | | react-table
Table (Primitives only) | `45.77 kB`
`14.174 kB` | | react-table
Table as DataGrid | `138.358 kB`
`37.213 kB` | | react-table
Table (Selection only) | `76.774 kB`
`20.602 kB` | | react-table
Table (Sort only) | `75.417 kB`
`20.205 kB` | | react-tags
InteractionTag | `15.299 kB`
`6.08 kB` | | react-tags
Tag | `29.092 kB`
`9.418 kB` | | react-tags
TagGroup | `82.49 kB`
`24.46 kB` | | react-text
Text - Default | `16.705 kB`
`6.57 kB` | | react-text
Text - Wrappers | `19.878 kB`
`6.897 kB` | | react-textarea
Textarea | `30.947 kB`
`10.477 kB` | | react-timepicker-compat
TimePicker | `107.39 kB`
`35.223 kB` | | react-toast
Toast (including Toaster) | `99.113 kB`
`29.844 kB` | | react-tooltip
Tooltip | `55.11 kB`
`19.268 kB` | | react-utilities
SSRProvider | `180 B`
`160 B` |

🤖 This report was generated against de1ebdc8c44ac61696ace95998503817f9e4bfca

fabricteam commented 2 weeks ago

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 628 638 5000
Button mount 309 302 5000
Field mount 1165 1162 5000
FluentProvider mount 716 701 5000
FluentProviderWithTheme mount 77 83 10
FluentProviderWithTheme virtual-rerender 36 36 10
FluentProviderWithTheme virtual-rerender-with-unmount 76 73 10
MakeStyles mount 872 849 50000
Persona mount 1775 1746 5000
SpinButton mount 1423 1344 5000
SwatchPicker mount 1543 1560 5000