microsoft / fluentui

Fluent UI web represents a collection of utilities, React components, and web components for building web applications.
https://react.fluentui.dev
Other
17.87k stars 2.66k forks source link

feat(react-components, react-drawer, react-message-bar, react-swatch-picker-preview): Add missing context exports for Drawer, MessageBar, and SwatchPicker #31328

Closed sopranopillow closed 2 weeks ago

sopranopillow commented 3 weeks ago

Previous Behavior

Some exports were missing which prevent being able to recompose Drawer, MessageBar, and SwatchPicker since useContextValues is required when recomposing.

This is blocking a partner from bumping their version of react-components.

New Behavior

Added missing exports.

fabricteam commented 3 weeks ago

Perf Analysis (@fluentui/react-components)

Scenario Render type Master Ticks PR Ticks Iterations Status
FluentProviderWithTheme virtual-rerender 32 27 10 Possible regression
All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 643 627 5000
Button mount 305 310 5000
Field mount 1104 1156 5000
FluentProvider mount 712 688 5000
FluentProviderWithTheme mount 77 79 10
FluentProviderWithTheme virtual-rerender 32 27 10 Possible regression
FluentProviderWithTheme virtual-rerender-with-unmount 67 79 10
MakeStyles mount 842 849 50000
Persona mount 1728 1693 5000
SpinButton mount 1367 1328 5000
SwatchPicker mount 1451 1506 5000

codesandbox-ci[bot] commented 3 weeks ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

fabricteam commented 3 weeks ago

📊 Bundle size report

Package & Exports Baseline (minified/GZIP) PR Change
react-components
react-components: entire library
1.139 MB
275.306 kB
1.139 MB
275.332 kB
205 B
26 B
react-swatch-picker-preview
@fluentui/react-swatch-picker-preview - package
108.862 kB
30.32 kB
109.013 kB
30.362 kB
151 B
42 B
Unchanged fixtures | Package & Exports | Size (minified/GZIP) | | ----------------- | -------------------: | | react-components
react-components: Button, FluentProvider & webLightTheme | `71.55 kB`
`20.584 kB` | | react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover | `221.825 kB`
`62.568 kB` | | react-components
react-components: FluentProvider & webLightTheme | `44.037 kB`
`14.418 kB` | | react-message-bar
MessageBar (all components) | `24.204 kB`
`8.983 kB` | | react-portal-compat
PortalCompatProvider | `8.39 kB`
`2.64 kB` |

🤖 This report was generated against bd0a0820115040f9024807d72b29c9f5766a732b

fabricteam commented 3 weeks ago

🕵 fluentuiv9 No visual regressions between this PR and main