microsoft / fluentui

Fluent UI web represents a collection of utilities, React components, and web components for building web applications.
https://react.fluentui.dev
Other
17.87k stars 2.66k forks source link

Adding support for error handling #31410

Open srmukher opened 2 weeks ago

srmukher commented 2 weeks ago

From PR https://github.com/microsoft/fluentui/pull/30346 The following changes have been added:

  1. Created a common control that can show error and empty states.
  2. Used the common control to show already implemented empty messages.
  3. Use the common control to show type errors (eg: when string data is used on x axis for Line chart or area chart which is not supported)
  4. Added Error Codes to indicate Generic Error or No Data Error.
  5. Kept provision for customizing the error handling while rendering if required.
  6. Added support for light/dark theme.

Examples:

  1. Generic Types Error image

  2. Missing Data image

Monosizes after adding error handling for horizontal bar chart variants:

image

Monosize in master:

image

Bundle size after adding error handling: image

Bundle size in master: image

fabricteam commented 2 weeks ago

📊 Bundle size report

✅ No changes found

codesandbox-ci[bot] commented 2 weeks ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

fabricteam commented 1 day ago

🕵 fluentuiv8 No visual regressions between this PR and main