search

microsoft / fluentui

Fluent UI web represents a collection of utilities, React components, and web components for building web applications.
https://react.fluentui.dev
Other
17.87k stars 2.66k forks source link

chore:(docs) Migrating Keeping up with review requests #31414

Closed mltejera closed 1 week ago

mltejera commented 2 weeks ago

Migrating Keeping up with review requests from the wiki. Made no file changes.

codesandbox-ci[bot] commented 2 weeks ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

fabricteam commented 2 weeks ago

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 636 624 5000
Button mount 309 292 5000
Field mount 1159 1130 5000
FluentProvider mount 700 715 5000
FluentProviderWithTheme mount 84 79 10
FluentProviderWithTheme virtual-rerender 36 38 10
FluentProviderWithTheme virtual-rerender-with-unmount 74 79 10
MakeStyles mount 871 865 50000
Persona mount 1764 1788 5000
SpinButton mount 1366 1421 5000
SwatchPicker mount 1542 1525 5000

fabricteam commented 2 weeks ago

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions Scenario | Current PR Ticks | Baseline Ticks | Ratio :--- | ---:| ---:| ---: TreeWith60ListItems.default | [104](https://fluentuipr.z22.web.core.windows.net/pull/31414/perf-test-northstar/TreeWith60ListItems.default.html) | [85](https://fluentuipr.z22.web.core.windows.net/pull/31414/perf-test-northstar/TreeWith60ListItems.default_base.html) | 1.22:1 LoaderMinimalPerf.default | [204](https://fluentuipr.z22.web.core.windows.net/pull/31414/perf-test-northstar/LoaderMinimalPerf.default.html) | [179](https://fluentuipr.z22.web.core.windows.net/pull/31414/perf-test-northstar/LoaderMinimalPerf.default_base.html) | 1.14:1 ButtonMinimalPerf.default | [97](https://fluentuipr.z22.web.core.windows.net/pull/31414/perf-test-northstar/ButtonMinimalPerf.default.html) | [86](https://fluentuipr.z22.web.core.windows.net/pull/31414/perf-test-northstar/ButtonMinimalPerf.default_base.html) | 1.13:1 FlexMinimalPerf.default | [166](https://fluentuipr.z22.web.core.windows.net/pull/31414/perf-test-northstar/FlexMinimalPerf.default.html) | [147](https://fluentuipr.z22.web.core.windows.net/pull/31414/perf-test-northstar/FlexMinimalPerf.default_base.html) | 1.13:1 ChatDuplicateMessagesPerf.default | [170](https://fluentuipr.z22.web.core.windows.net/pull/31414/perf-test-northstar/ChatDuplicateMessagesPerf.default.html) | [152](https://fluentuipr.z22.web.core.windows.net/pull/31414/perf-test-northstar/ChatDuplicateMessagesPerf.default_base.html) | 1.12:1 TextAreaMinimalPerf.default | [313](https://fluentuipr.z22.web.core.windows.net/pull/31414/perf-test-northstar/TextAreaMinimalPerf.default.html) | [290](https://fluentuipr.z22.web.core.windows.net/pull/31414/perf-test-northstar/TextAreaMinimalPerf.default_base.html) | 1.08:1 SegmentMinimalPerf.default | [207](https://fluentuipr.z22.web.core.windows.net/pull/31414/perf-test-northstar/SegmentMinimalPerf.default.html) | [194](https://fluentuipr.z22.web.core.windows.net/pull/31414/perf-test-northstar/SegmentMinimalPerf.default_base.html) | 1.07:1 TableMinimalPerf.default | [249](https://fluentuipr.z22.web.core.windows.net/pull/31414/perf-test-northstar/TableMinimalPerf.default.html) | [232](https://fluentuipr.z22.web.core.windows.net/pull/31414/perf-test-northstar/TableMinimalPerf.default_base.html) | 1.07:1 VideoMinimalPerf.default | [455](https://fluentuipr.z22.web.core.windows.net/pull/31414/perf-test-northstar/VideoMinimalPerf.default.html) | [427](https://fluentuipr.z22.web.core.windows.net/pull/31414/perf-test-northstar/VideoMinimalPerf.default_base.html) | 1.07:1 AvatarMinimalPerf.default | [115](https://fluentuipr.z22.web.core.windows.net/pull/31414/perf-test-northstar/AvatarMinimalPerf.default.html) | [108](https://fluentuipr.z22.web.core.windows.net/pull/31414/perf-test-northstar/AvatarMinimalPerf.default_base.html) | 1.06:1 TextMinimalPerf.default | [214](https://fluentuipr.z22.web.core.windows.net/pull/31414/perf-test-northstar/TextMinimalPerf.default.html) | [201](https://fluentuipr.z22.web.core.windows.net/pull/31414/perf-test-northstar/TextMinimalPerf.default_base.html) | 1.06:1 AttachmentMinimalPerf.default | [82](https://fluentuipr.z22.web.core.windows.net/pull/31414/perf-test-northstar/AttachmentMinimalPerf.default.html) | [78](https://fluentuipr.z22.web.core.windows.net/pull/31414/perf-test-northstar/AttachmentMinimalPerf.default_base.html) | 1.05:1 FormMinimalPerf.default | [229](https://fluentuipr.z22.web.core.windows.net/pull/31414/perf-test-northstar/FormMinimalPerf.default.html) | [218](https://fluentuipr.z22.web.core.windows.net/pull/31414/perf-test-northstar/FormMinimalPerf.default_base.html) | 1.05:1 InputMinimalPerf.default | [555](https://fluentuipr.z22.web.core.windows.net/pull/31414/perf-test-northstar/InputMinimalPerf.default.html) | [530](https://fluentuipr.z22.web.core.windows.net/pull/31414/perf-test-northstar/InputMinimalPerf.default_base.html) | 1.05:1 ButtonOverridesMissPerf.default | [714](https://fluentuipr.z22.web.core.windows.net/pull/31414/perf-test-northstar/ButtonOverridesMissPerf.default.html) | [687](https://fluentuipr.z22.web.core.windows.net/pull/31414/perf-test-northstar/ButtonOverridesMissPerf.default_base.html) | 1.04:1 CarouselMinimalPerf.default | [271](https://fluentuipr.z22.web.core.windows.net/pull/31414/perf-test-northstar/CarouselMinimalPerf.default.html) | [261](https://fluentuipr.z22.web.core.windows.net/pull/31414/perf-test-northstar/CarouselMinimalPerf.default_base.html) | 1.04:1 ChatMinimalPerf.default | [457](https://fluentuipr.z22.web.core.windows.net/pull/31414/perf-test-northstar/ChatMinimalPerf.default.html) | [441](https://fluentuipr.z22.web.core.windows.net/pull/31414/perf-test-northstar/ChatMinimalPerf.default_base.html) | 1.04:1 DialogMinimalPerf.default | [446](https://fluentuipr.z22.web.core.windows.net/pull/31414/perf-test-northstar/DialogMinimalPerf.default.html) | [434](https://fluentuipr.z22.web.core.windows.net/pull/31414/perf-test-northstar/DialogMinimalPerf.default_base.html) | 1.03:1 HeaderMinimalPerf.default | [209](https://fluentuipr.z22.web.core.windows.net/pull/31414/perf-test-northstar/HeaderMinimalPerf.default.html) | [202](https://fluentuipr.z22.web.core.windows.net/pull/31414/perf-test-northstar/HeaderMinimalPerf.default_base.html) | 1.03:1 ImageMinimalPerf.default | [240](https://fluentuipr.z22.web.core.windows.net/pull/31414/perf-test-northstar/ImageMinimalPerf.default.html) | [234](https://fluentuipr.z22.web.core.windows.net/pull/31414/perf-test-northstar/ImageMinimalPerf.default_base.html) | 1.03:1 ListMinimalPerf.default | [319](https://fluentuipr.z22.web.core.windows.net/pull/31414/perf-test-northstar/ListMinimalPerf.default.html) | [311](https://fluentuipr.z22.web.core.windows.net/pull/31414/perf-test-northstar/ListMinimalPerf.default_base.html) | 1.03:1 TreeMinimalPerf.default | [490](https://fluentuipr.z22.web.core.windows.net/pull/31414/perf-test-northstar/TreeMinimalPerf.default.html) | [476](https://fluentuipr.z22.web.core.windows.net/pull/31414/perf-test-northstar/TreeMinimalPerf.default_base.html) | 1.03:1 AlertMinimalPerf.default | [155](https://fluentuipr.z22.web.core.windows.net/pull/31414/perf-test-northstar/AlertMinimalPerf.default.html) | [152](https://fluentuipr.z22.web.core.windows.net/pull/31414/perf-test-northstar/AlertMinimalPerf.default_base.html) | 1.02:1 AttachmentSlotsPerf.default | [669](https://fluentuipr.z22.web.core.windows.net/pull/31414/perf-test-northstar/AttachmentSlotsPerf.default.html) | [655](https://fluentuipr.z22.web.core.windows.net/pull/31414/perf-test-northstar/AttachmentSlotsPerf.default_base.html) | 1.02:1 CheckboxMinimalPerf.default | [1166](https://fluentuipr.z22.web.core.windows.net/pull/31414/perf-test-northstar/CheckboxMinimalPerf.default.html) | [1140](https://fluentuipr.z22.web.core.windows.net/pull/31414/perf-test-northstar/CheckboxMinimalPerf.default_base.html) | 1.02:1 HeaderSlotsPerf.default | [458](https://fluentuipr.z22.web.core.windows.net/pull/31414/perf-test-northstar/HeaderSlotsPerf.default.html) | [449](https://fluentuipr.z22.web.core.windows.net/pull/31414/perf-test-northstar/HeaderSlotsPerf.default_base.html) | 1.02:1 SkeletonMinimalPerf.default | [209](https://fluentuipr.z22.web.core.windows.net/pull/31414/perf-test-northstar/SkeletonMinimalPerf.default.html) | [204](https://fluentuipr.z22.web.core.windows.net/pull/31414/perf-test-northstar/SkeletonMinimalPerf.default_base.html) | 1.02:1 SplitButtonMinimalPerf.default | [2290](https://fluentuipr.z22.web.core.windows.net/pull/31414/perf-test-northstar/SplitButtonMinimalPerf.default.html) | [2253](https://fluentuipr.z22.web.core.windows.net/pull/31414/perf-test-northstar/SplitButtonMinimalPerf.default_base.html) | 1.02:1 IconMinimalPerf.default | [390](https://fluentuipr.z22.web.core.windows.net/pull/31414/perf-test-northstar/IconMinimalPerf.default.html) | [384](https://fluentuipr.z22.web.core.windows.net/pull/31414/perf-test-northstar/IconMinimalPerf.default_base.html) | 1.02:1 TableManyItemsPerf.default | [1107](https://fluentuipr.z22.web.core.windows.net/pull/31414/perf-test-northstar/TableManyItemsPerf.default.html) | [1085](https://fluentuipr.z22.web.core.windows.net/pull/31414/perf-test-northstar/TableManyItemsPerf.default_base.html) | 1.02:1 DropdownManyItemsPerf.default | [385](https://fluentuipr.z22.web.core.windows.net/pull/31414/perf-test-northstar/DropdownManyItemsPerf.default.html) | [382](https://fluentuipr.z22.web.core.windows.net/pull/31414/perf-test-northstar/DropdownManyItemsPerf.default_base.html) | 1.01:1 DropdownMinimalPerf.default | [1434](https://fluentuipr.z22.web.core.windows.net/pull/31414/perf-test-northstar/DropdownMinimalPerf.default.html) | [1423](https://fluentuipr.z22.web.core.windows.net/pull/31414/perf-test-northstar/DropdownMinimalPerf.default_base.html) | 1.01:1 MenuMinimalPerf.default | [516](https://fluentuipr.z22.web.core.windows.net/pull/31414/perf-test-northstar/MenuMinimalPerf.default.html) | [512](https://fluentuipr.z22.web.core.windows.net/pull/31414/perf-test-northstar/MenuMinimalPerf.default_base.html) | 1.01:1 MenuButtonMinimalPerf.default | [981](https://fluentuipr.z22.web.core.windows.net/pull/31414/perf-test-northstar/MenuButtonMinimalPerf.default.html) | [972](https://fluentuipr.z22.web.core.windows.net/pull/31414/perf-test-northstar/MenuButtonMinimalPerf.default_base.html) | 1.01:1 PopupMinimalPerf.default | [352](https://fluentuipr.z22.web.core.windows.net/pull/31414/perf-test-northstar/PopupMinimalPerf.default.html) | [350](https://fluentuipr.z22.web.core.windows.net/pull/31414/perf-test-northstar/PopupMinimalPerf.default_base.html) | 1.01:1 PortalMinimalPerf.default | [83](https://fluentuipr.z22.web.core.windows.net/pull/31414/perf-test-northstar/PortalMinimalPerf.default.html) | [82](https://fluentuipr.z22.web.core.windows.net/pull/31414/perf-test-northstar/PortalMinimalPerf.default_base.html) | 1.01:1 ProviderMinimalPerf.default | [198](https://fluentuipr.z22.web.core.windows.net/pull/31414/perf-test-northstar/ProviderMinimalPerf.default.html) | [196](https://fluentuipr.z22.web.core.windows.net/pull/31414/perf-test-northstar/ProviderMinimalPerf.default_base.html) | 1.01:1 ReactionMinimalPerf.default | [218](https://fluentuipr.z22.web.core.windows.net/pull/31414/perf-test-northstar/ReactionMinimalPerf.default.html) | [216](https://fluentuipr.z22.web.core.windows.net/pull/31414/perf-test-northstar/ReactionMinimalPerf.default_base.html) | 1.01:1 StatusMinimalPerf.default | [396](https://fluentuipr.z22.web.core.windows.net/pull/31414/perf-test-northstar/StatusMinimalPerf.default.html) | [393](https://fluentuipr.z22.web.core.windows.net/pull/31414/perf-test-northstar/StatusMinimalPerf.default_base.html) | 1.01:1 AnimationMinimalPerf.default | [294](https://fluentuipr.z22.web.core.windows.net/pull/31414/perf-test-northstar/AnimationMinimalPerf.default.html) | [295](https://fluentuipr.z22.web.core.windows.net/pull/31414/perf-test-northstar/AnimationMinimalPerf.default_base.html) | 1:1 CardMinimalPerf.default | [310](https://fluentuipr.z22.web.core.windows.net/pull/31414/perf-test-northstar/CardMinimalPerf.default.html) | [311](https://fluentuipr.z22.web.core.windows.net/pull/31414/perf-test-northstar/CardMinimalPerf.default_base.html) | 1:1 ChatWithPopoverPerf.default | [198](https://fluentuipr.z22.web.core.windows.net/pull/31414/perf-test-northstar/ChatWithPopoverPerf.default.html) | [198](https://fluentuipr.z22.web.core.windows.net/pull/31414/perf-test-northstar/ChatWithPopoverPerf.default_base.html) | 1:1 DatepickerMinimalPerf.default | [3584](https://fluentuipr.z22.web.core.windows.net/pull/31414/perf-test-northstar/DatepickerMinimalPerf.default.html) | [3596](https://fluentuipr.z22.web.core.windows.net/pull/31414/perf-test-northstar/DatepickerMinimalPerf.default_base.html) | 1:1 DividerMinimalPerf.default | [202](https://fluentuipr.z22.web.core.windows.net/pull/31414/perf-test-northstar/DividerMinimalPerf.default.html) | [203](https://fluentuipr.z22.web.core.windows.net/pull/31414/perf-test-northstar/DividerMinimalPerf.default_base.html) | 1:1 ItemLayoutMinimalPerf.default | [698](https://fluentuipr.z22.web.core.windows.net/pull/31414/perf-test-northstar/ItemLayoutMinimalPerf.default.html) | [697](https://fluentuipr.z22.web.core.windows.net/pull/31414/perf-test-northstar/ItemLayoutMinimalPerf.default_base.html) | 1:1 RadioGroupMinimalPerf.default | [257](https://fluentuipr.z22.web.core.windows.net/pull/31414/perf-test-northstar/RadioGroupMinimalPerf.default.html) | [256](https://fluentuipr.z22.web.core.windows.net/pull/31414/perf-test-northstar/RadioGroupMinimalPerf.default_base.html) | 1:1 ToolbarMinimalPerf.default | [557](https://fluentuipr.z22.web.core.windows.net/pull/31414/perf-test-northstar/ToolbarMinimalPerf.default.html) | [557](https://fluentuipr.z22.web.core.windows.net/pull/31414/perf-test-northstar/ToolbarMinimalPerf.default_base.html) | 1:1 BoxMinimalPerf.default | [192](https://fluentuipr.z22.web.core.windows.net/pull/31414/perf-test-northstar/BoxMinimalPerf.default.html) | [193](https://fluentuipr.z22.web.core.windows.net/pull/31414/perf-test-northstar/BoxMinimalPerf.default_base.html) | 0.99:1 SliderMinimalPerf.default | [738](https://fluentuipr.z22.web.core.windows.net/pull/31414/perf-test-northstar/SliderMinimalPerf.default.html) | [749](https://fluentuipr.z22.web.core.windows.net/pull/31414/perf-test-northstar/SliderMinimalPerf.default_base.html) | 0.99:1 CustomToolbarPrototype.default | [1504](https://fluentuipr.z22.web.core.windows.net/pull/31414/perf-test-northstar/CustomToolbarPrototype.default.html) | [1525](https://fluentuipr.z22.web.core.windows.net/pull/31414/perf-test-northstar/CustomToolbarPrototype.default_base.html) | 0.99:1 ButtonSlotsPerf.default | [315](https://fluentuipr.z22.web.core.windows.net/pull/31414/perf-test-northstar/ButtonSlotsPerf.default.html) | [320](https://fluentuipr.z22.web.core.windows.net/pull/31414/perf-test-northstar/ButtonSlotsPerf.default_base.html) | 0.98:1 EmbedMinimalPerf.default | [1861](https://fluentuipr.z22.web.core.windows.net/pull/31414/perf-test-northstar/EmbedMinimalPerf.default.html) | [1898](https://fluentuipr.z22.web.core.windows.net/pull/31414/perf-test-northstar/EmbedMinimalPerf.default_base.html) | 0.98:1 LayoutMinimalPerf.default | [203](https://fluentuipr.z22.web.core.windows.net/pull/31414/perf-test-northstar/LayoutMinimalPerf.default.html) | [207](https://fluentuipr.z22.web.core.windows.net/pull/31414/perf-test-northstar/LayoutMinimalPerf.default_base.html) | 0.98:1 ListWith60ListItems.default | [372](https://fluentuipr.z22.web.core.windows.net/pull/31414/perf-test-northstar/ListWith60ListItems.default.html) | [378](https://fluentuipr.z22.web.core.windows.net/pull/31414/perf-test-northstar/ListWith60ListItems.default_base.html) | 0.98:1 RosterPerf.default | [1562](https://fluentuipr.z22.web.core.windows.net/pull/31414/perf-test-northstar/RosterPerf.default.html) | [1592](https://fluentuipr.z22.web.core.windows.net/pull/31414/perf-test-northstar/RosterPerf.default_base.html) | 0.98:1 TooltipMinimalPerf.default | [1269](https://fluentuipr.z22.web.core.windows.net/pull/31414/perf-test-northstar/TooltipMinimalPerf.default.html) | [1290](https://fluentuipr.z22.web.core.windows.net/pull/31414/perf-test-northstar/TooltipMinimalPerf.default_base.html) | 0.98:1 AccordionMinimalPerf.default | [89](https://fluentuipr.z22.web.core.windows.net/pull/31414/perf-test-northstar/AccordionMinimalPerf.default.html) | [92](https://fluentuipr.z22.web.core.windows.net/pull/31414/perf-test-northstar/AccordionMinimalPerf.default_base.html) | 0.97:1 ListNestedPerf.default | [330](https://fluentuipr.z22.web.core.windows.net/pull/31414/perf-test-northstar/ListNestedPerf.default.html) | [339](https://fluentuipr.z22.web.core.windows.net/pull/31414/perf-test-northstar/ListNestedPerf.default_base.html) | 0.97:1 ProviderMergeThemesPerf.default | [640](https://fluentuipr.z22.web.core.windows.net/pull/31414/perf-test-northstar/ProviderMergeThemesPerf.default.html) | [662](https://fluentuipr.z22.web.core.windows.net/pull/31414/perf-test-northstar/ProviderMergeThemesPerf.default_base.html) | 0.97:1 LabelMinimalPerf.default | [217](https://fluentuipr.z22.web.core.windows.net/pull/31414/perf-test-northstar/LabelMinimalPerf.default.html) | [225](https://fluentuipr.z22.web.core.windows.net/pull/31414/perf-test-northstar/LabelMinimalPerf.default_base.html) | 0.96:1 RefMinimalPerf.default | [103](https://fluentuipr.z22.web.core.windows.net/pull/31414/perf-test-northstar/RefMinimalPerf.default.html) | [108](https://fluentuipr.z22.web.core.windows.net/pull/31414/perf-test-northstar/RefMinimalPerf.default_base.html) | 0.95:1 GridMinimalPerf.default | [183](https://fluentuipr.z22.web.core.windows.net/pull/31414/perf-test-northstar/GridMinimalPerf.default.html) | [195](https://fluentuipr.z22.web.core.windows.net/pull/31414/perf-test-northstar/GridMinimalPerf.default_base.html) | 0.94:1 ListCommonPerf.default | [388](https://fluentuipr.z22.web.core.windows.net/pull/31414/perf-test-northstar/ListCommonPerf.default.html) | [418](https://fluentuipr.z22.web.core.windows.net/pull/31414/perf-test-northstar/ListCommonPerf.default_base.html) | 0.93:1
fabricteam commented 2 weeks ago

🕵 FluentUIV0 No visual regressions between this PR and main

fabricteam commented 2 weeks ago

📊 Bundle size report

✅ No changes found

fabricteam commented 2 weeks ago

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 636 649 5000
Breadcrumb mount 1654 1670 1000
Checkbox mount 1702 1707 5000
CheckboxBase mount 1485 1470 5000
ChoiceGroup mount 2988 2992 5000
ComboBox mount 704 676 1000
CommandBar mount 6486 6488 1000
ContextualMenu mount 11650 11723 1000
DefaultButton mount 795 787 5000
DetailsRow mount 2254 2248 5000
DetailsRowFast mount 2224 2285 5000
DetailsRowNoStyles mount 2081 2085 5000
Dialog mount 2789 2775 1000
DocumentCardTitle mount 224 228 1000
Dropdown mount 1998 2030 5000
FocusTrapZone mount 1126 1162 5000
FocusZone mount 1079 1093 5000
GroupedList mount 42066 41871 2
GroupedList virtual-rerender 18149 20233 2
GroupedList virtual-rerender-with-unmount 50836 51051 2
GroupedListV2 mount 223 226 2
GroupedListV2 virtual-rerender 215 215 2
GroupedListV2 virtual-rerender-with-unmount 236 229 2
IconButton mount 1125 1110 5000
Label mount 338 343 5000
Layer mount 2751 2712 5000
Link mount 399 390 5000
MenuButton mount 993 975 5000
MessageBar mount 21288 21219 5000
Nav mount 2011 2078 1000
OverflowSet mount 773 779 5000
Panel mount 1804 1821 1000
Persona mount 761 745 1000
Pivot mount 907 894 1000
PrimaryButton mount 920 936 5000
Rating mount 4755 4780 5000
SearchBox mount 932 946 5000
Shimmer mount 1928 1890 5000
Slider mount 1349 1344 5000
SpinButton mount 3032 2975 5000
Spinner mount 386 387 5000
SplitButton mount 1890 1892 5000
Stack mount 402 401 5000
StackWithIntrinsicChildren mount 850 857 5000
StackWithTextChildren mount 2683 2674 5000
SwatchColorPicker mount 6387 6316 5000
TagPicker mount 1499 1477 5000
Text mount 372 371 5000
TextField mount 932 933 5000
ThemeProvider mount 849 830 5000
ThemeProvider virtual-rerender 583 583 5000
ThemeProvider virtual-rerender-with-unmount 1290 1299 5000
Toggle mount 613 618 5000
buttonNative mount 193 190 5000

fabricteam commented 1 week ago

🕵 fluentuiv9 No visual regressions between this PR and main

  • © Githubissues.
  • Githubissues is a development platform for aggregating issues.