microsoft / fluentui

Fluent UI web represents a collection of utilities, React components, and web components for building web applications.
https://react.fluentui.dev
Other
18.29k stars 2.71k forks source link

[Bug]: Dialog documentation could be clearer #31620

Closed ccardiasmenosMSFT closed 3 weeks ago

ccardiasmenosMSFT commented 3 months ago

Library

Web Components (@fluentui/web-components)

System Info

N/A

Are you reporting Accessibility issue?

None

Reproduction

N/A

Bug Description

Actual Behavior

The Dialog documentation found here was a bit confusing. We only show a close button on the non-modal dialog type but then explain later that modal and non-modal dialogs can both have close buttons.: https://fluent2.microsoft.design/components/web/react/dialog/usage

Expected Behavior

It would help to provide visuals that convey that you can interact with the below content in a non-modal dialog rather than have the only difference showing be the close button.

Logs

No response

Requested priority

Normal

Products/sites affected

All

Are you willing to submit a PR to fix?

no

Validations

chrisdholt commented 3 months ago

@gouttierre looks like this is for React, can you assign to the right person?

ccardiasmenosMSFT commented 3 months ago

I updated the description above. This doesn't need to be considered a bug but is a suggestion to improve the documentation. If there's a way to change the issue type, please let me know.

layershifter commented 3 weeks ago

@tudorpopams FYI

tudorpopams commented 3 weeks ago

Hi @ccardiasmenosMSFT , thanks for submitting this issue. This is intended for the Fluent 2 website and not Fluent UI React v9 per se, so I'm going to close this issue and recreate it on the website board (which is private, unfortunately) as an improvement suggestion.

ccardiasmenosMSFT commented 3 weeks ago

[like] Caroline Cardiasmenos reacted to your message: