microsoft / fluentui

Fluent UI web represents a collection of utilities, React components, and web components for building web applications.
https://react.fluentui.dev
Other
18.53k stars 2.74k forks source link

[Bug]: Narrator is announcing incorrect information on select/close of a Popover #31748

Open ValentinaKozlova opened 5 months ago

ValentinaKozlova commented 5 months ago

Library

React Components / v9 (@fluentui/react-components)

System Info

System:
    OS: Windows 11 10.0.22631
    CPU: (8) x64 Intel(R) Core(TM) i7-1065G7 CPU @ 1.30GHz
    Memory: 13.89 GB / 31.60 GB
  Browsers:
    Edge: Chromium (125.0.2535.92)
    Internet Explorer: 11.0.22621.3527

Are you reporting Accessibility issue?

yes

Reproduction

https://react.fluentui.dev/?path=/docs/components-popover--default#trapping-focus

Bug Description

This bug is reproducible when trapFocus prop is used.

Steps

  1. Turn on Narrator
  2. Open https://react.fluentui.dev/?path=/docs/components-popover--default#trapping-focus
  3. Navigate to "Popover trigger" button in "Trapping Focus" section.
  4. Press Space or Enter to open a popup.
  5. Press Esc.

Actual Behavior

Narrator is announcing a lot of extra information before saying "Popover trigger button collapsed".

Expected Behavior

Narrator is announcing: "Popover trigger button collapsed".

Notes:

  1. This bug is reproducible when selecting items in a popup and when closing it.
  2. Focus is set correctly
  3. Only in Edge browser. Not reproducible in Firefox and Chrome

Logs

No response

Requested priority

Normal

Products/sites affected

No response

Are you willing to submit a PR to fix?

no

Validations

jurokapsiar commented 4 months ago

@ValentinaKozlova can you please let us know what extra information is being read before the label, role and collapsed state?

I have tried and I can only hear those 3 pieces of information.

Please note that storybook renders individual stories in iframes, so screen readers might read the context change information before.

ValentinaKozlova commented 4 months ago

@ValentinaKozlova can you please let us know what extra information is being read before the label, role and collapsed state?

I have tried and I can only hear those 3 pieces of information.

Please note that storybook renders individual stories in iframes, so screen readers might read the context change information before.

Here's what Narrator reads: "Scan, Component forward slash popover, default storybook and 30 more pages, work, Microsoft edge window, Components Popover default document, Popover trigger, button". It's reproducible only for trapFocus and only in Edge browser

microsoft-github-policy-service[bot] commented 4 months ago

@ling1726

Gentle ping that this issue needs attention.