microsoft / fluentui

Fluent UI web represents a collection of utilities, React components, and web components for building web applications.
https://react.fluentui.dev
Other
18.29k stars 2.71k forks source link

[Bug]: No focus indicator for Checkboxes (V8) inside Drawers (V9) #31942

Open rocketBANG opened 2 months ago

rocketBANG commented 2 months ago

Library

React Components / v9 (@fluentui/react-components)

System Info

System:
    OS: Windows 10 10.0.22631
    CPU: (16) x64 AMD EPYC 7763 64-Core Processor
    Memory: 34.82 GB / 63.95 GB
  Browsers:
    Edge: Chromium (126.0.2592.87)
    Internet Explorer: 11.0.22621.3527

Are you reporting Accessibility issue?

yes

Reproduction

https://stackblitz.com/edit/8wcy3f?file=src%2Fexample.tsx

Bug Description

Actual Behavior

Focusing with a keyboard on the checkbox within a Drawer does not show any indicators image

The ThemeProvider is only at the root, the isFocusVisible class and event listeners don't work for components inside an OverlayDrawer image

Expected Behavior

The checkbox within the drawer to show a focus indicator like this image

Logs

No response

Requested priority

Blocking

Products/sites affected

No response

Are you willing to submit a PR to fix?

no

Validations

khmakoto commented 1 month ago

I can confirm that this is indeed happening.

This happens because we do not apply the v8 focus visibility class names to the v9 Drawer surface. We need to investigate if this happens with every v9 portal or if there is something we are missing with Drawer specifically.