search

microsoft / fluentui

Fluent UI web represents a collection of utilities, React components, and web components for building web applications.
https://react.fluentui.dev
Other
18.51k stars 2.73k forks source link

[Feature]: Dialog stories do not include an example for customizing (or disabling) motion #32411

Closed JustSlone closed 1 month ago

JustSlone commented 2 months ago

Library

React Components / v9 (@fluentui/react-components)

Describe the feature that you would like added

The dialog documentation / stories does not include information on how to customize or disable animations. The only information is a brief mention of the types for surfaceMotion. In fact backdropMotion is not even mentioned in the docs.

Have you discussed this feature with our team

No response

Additional context

This issue comes from a partner request about "how to disable motion on dialog".

Validations

Priority

Normal

tudorpopams commented 2 months ago

@bsunderhus would you be able to also update the Dialog docs to mention the backdropMotion prop as well? As Justin says here, there's no mention for it anywhere for now.

UPDATE: We did a new release for the v9 storybook and sub component tabs are now back, which include DialogSurface that mentions backdropMotion.

layershifter commented 2 months ago

The same is applicable there https://github.com/microsoft/fluentui/issues/32432#issuecomment-2324687163

JustSlone commented 2 months ago

UPDATE: We did a new release for the v9 storybook and sub component tabs are now back, which include DialogSurface that mentions backdropMotion.

This is great, thanks!

@tudorpopams, @bsunderhus Should we also have a story showing how to customize motion?

bsunderhus commented 2 months ago

UPDATE: We did a new release for the v9 storybook and sub component tabs are now back, which include DialogSurface that mentions backdropMotion.

This is great, thanks!

@tudorpopams, @bsunderhus Should we also have a story showing how to customize motion?

We have a section in our stories on how to customize motion (maybe it's missing more documentation there 🤔) @JustSlone, I believe on the Dialog side is enough to show what property gives access to motion, and then it becomes users responsibility to research Motion on our docs 😁 image

miroslavstastny commented 1 month ago

We need general motion doc page in storybook about this.