microsoft / fluentui

Fluent UI web represents a collection of utilities, React components, and web components for building web applications.
https://react.fluentui.dev
Other
18.53k stars 2.73k forks source link

[Bug]: List preview component should be free of axe core scan errors #33171

Open kolaps33 opened 2 weeks ago

kolaps33 commented 2 weeks ago

Component

List (Preview)

Package version

9.55.1

React version

18.3.1

Environment

System: OS: Windows 11 10.0.22631 CPU: (22) x64 Intel(R) Core(TM) Ultra 7 165H Memory: 40.92 GB / 63.64 GB Browsers: Edge: Chromium (127.0.2651.74) Internet Explorer: 11.0.22621.3527

Current Behavior

There are errors throw by a11y insight for web tool (which use axe core as engine): Image

Version of Accessibility insight for web: Version 2.44.0 | Powered by axe-core 4.9.1

Expected Behavior

There should not be accessibility insight errors within the list component.

Reproduction

https://react.fluentui.dev/?path=/docs/preview-components-list--docs

Steps to reproduce

  1. Go to docsite https://react.fluentui.dev/?path=/docs/preview-components-list--docs
  2. run "FastPass" Accessibility insight for web
  3. verify the result

Are you reporting an Accessibility issue?

None

Suggested severity

Urgent - No workaround and Products/sites are affected

Products/sites affected

No response

Are you willing to submit a PR to fix?

yes

Validations

smhigley commented 2 weeks ago

Yeah, the roles of List are not appropriate from an accessibility point of view. I'll take a look -- both the listbox/option version and the grid version don't look like they can support the proposed interaction & content model.