microsoft / fluentui

Fluent UI web represents a collection of utilities, React components, and web components for building web applications.
https://react.fluentui.dev
Other
18.58k stars 2.75k forks source link

Errors in NPM install #7707

Closed danmarshall closed 5 years ago

danmarshall commented 5 years ago

Environment Information

Actual behavior:

Errors during npm install on a fresh repo:

Expected behavior:

no errors in npm install.

Priorities and help requested:

Are you willing to submit a PR to fix? No

Requested priority: Normal

Products/sites affected: Developers/contributors of this repo

mikewheaton commented 5 years ago

Could you confirm that your registry is set to https://registry.npmjs.org/ by running: npm config get registry

danmarshall commented 5 years ago

@mikewheaton - yes it is https://registry.npmjs.org/

dzearing commented 5 years ago

@samiyaakhtar @Raghurk can you please investigate here? We should be avoiding hotfix dependencies, can these be removed?

dzearing commented 5 years ago

@kenotron hmm, shouldn't errors like this fail our install on ci?

kenotron commented 5 years ago

This is likely an error in rush install somewhere. It doesn't verify these installs because those are not properly coming from npmjs.org. Those are github dependencies. Agreed with @dzearing, we really should not have these in our repo, but they're added to an experimental package, so we had traditionally let it slide.

I've not had a chance to tease out what was modded in react-layout to support dashboard. I think if we really can't rush install, we'll have to remove that project from rush.json and just keep the code checked in until we can restore that functionality.

kenotron commented 5 years ago

I cannot repro this anymore. This is probably due to github's less-than-stellar uptime. Further points to the fact that we need to move away from github commit version dependency.

When we do rush install / npm install, we always see this:

WARNING: Not validating git-based specifier: "samiyaakhtar/react-grid-layout"
kenotron commented 5 years ago

This #5464 brought that change in. It looks like the fork was needed by @samiyaakhtar to bring in another drag API that wasn't available to react-grid-layout. One way to do this is to actually fork & publish to npmjs.org so we're not dependent on github.com's infra. But longer term, I would suggest submitting a PR to react-grid-layout to see if they would merge it - which would be the point of having access to their code in OSS.

danmarshall commented 5 years ago

Thanks for looking into this @kenotron . I seem to be able to repro consistently. I'm on a fresh machine and I'm not able to set it up for dev contribution. 🥺

kenotron commented 5 years ago

@danmarshall dag nab it cache! Let me try again... if rush install is indeed failing, I'm really going to have to disable the dashboard project altogether...

kenotron commented 5 years ago

@danmarshall - Can you try going to here: https://codeload.github.com/samiyaakhtar/react-grid-layout/tar.gz/6ed4e54bcb5236f78bf181433ad36aea971e5891

Does it download anything for you in the browser on that machine?

kenotron commented 5 years ago

FYI, I fired up a docker instance which has no cache inside and npm install went okay... I'm thinking it might be a network issue on your end?

oasis:workspace ken$ docker run -it node:10 /bin/bash
root@8a8cc9938d7e:/# su node
node@8a8cc9938d7e:/$ cd
node@8a8cc9938d7e:~$ git clone https://github.com/OfficeDev/office-ui-fabric-react.git fabric
Cloning into 'fabric'...
remote: Enumerating objects: 171, done.
remote: Counting objects: 100% (171/171), done.
remote: Compressing objects: 100% (140/140), done.
remote: Total 120900 (delta 53), reused 31 (delta 31), pack-reused 120729
Receiving objects: 100% (120900/120900), 49.87 MiB | 20.45 MiB/s, done.
Resolving deltas: 100% (85655/85655), done.
node@8a8cc9938d7e:~$ cd fabric
node@8a8cc9938d7e:~/fabric$ npm i

> office-ui-fabric-react-repo@1.0.0 postinstall /home/node/fabric
> npm run _rushInstall && npm run _rushBuildToExperiments -- --npm-install-mode

> office-ui-fabric-react-repo@1.0.0 _rushInstall /home/node/fabric
> node common/scripts/install-run-rush.js install --purge

The rush.json configuration requests Rush version 5.5.4
Installing @microsoft/rush...
npm notice created a lockfile as package-lock.json. You should commit this file.
added 168 packages from 178 contributors and audited 365 packages in 8.242s
found 0 vulnerabilities

Successfully installed @microsoft/rush@5.5.4

Invoking "rush install --purge"
-------------------------------

Rush Multi-Project Build Tool 5.5.4 - https://rushjs.io

Starting "rush install"

The --purge flag was specified, so performing "rush purge"
Purging /home/node/fabric/common/temp
The active process's folder will not be deleted: /home/node/fabric/common/temp/install-run

Found files in the "common/git-hooks" folder.
Successfully installed these Git hook scripts: pre-commit

Creating /home/node/.rush/node-v10.15.0
Trying to acquire lock for pnpm-2.19.2
Acquired lock for pnpm-2.19.2
Installing pnpm version 2.19.2

Copying /home/node/fabric/common/config/rush/.npmrc --> /home/node/.rush/node-v10.15.0/pnpm-2.19.2/.npmrc

Running "npm install" in /home/node/.rush/node-v10.15.0/pnpm-2.19.2
npm notice created a lockfile as package-lock.json. You should commit this file.
added 1 package from 1 contributor and audited 1 package in 3.927s
found 0 vulnerabilities

Successfully installed pnpm version 2.19.2

Symlinking "/home/node/fabric/common/temp/pnpm-local"
  --> "/home/node/.rush/node-v10.15.0/pnpm-2.19.2"

Using the default variant for installation.

Updating temp projects in /home/node/fabric/common/temp/projects
Copying /home/node/fabric/common/config/rush/.npmrc --> /home/node/fabric/common/temp/.npmrc
Updating /home/node/fabric/common/temp/pnpmfile.js
Updating /home/node/fabric/common/temp/projects/azure-themes.tgz
Updating /home/node/fabric/common/temp/projects/build.tgz
Updating /home/node/fabric/common/temp/projects/charting.tgz
WARNING: Not validating git-based specifier: "samiyaakhtar/react-grid-layout"
Updating /home/node/fabric/common/temp/projects/dashboard.tgz
Updating /home/node/fabric/common/temp/projects/date-time.tgz
Updating /home/node/fabric/common/temp/projects/example-app-base.tgz
Updating /home/node/fabric/common/temp/projects/experiments.tgz
Updating /home/node/fabric/common/temp/projects/fabric-website.tgz
Updating /home/node/fabric/common/temp/projects/fabric-website-resources.tgz
Updating /home/node/fabric/common/temp/projects/file-type-icons.tgz
Updating /home/node/fabric/common/temp/projects/fluent-theme.tgz
Updating /home/node/fabric/common/temp/projects/foundation.tgz
Updating /home/node/fabric/common/temp/projects/foundation-scenarios.tgz
Updating /home/node/fabric/common/temp/projects/icons.tgz
Updating /home/node/fabric/common/temp/projects/jest-serializer-merge-styles.tgz
Updating /home/node/fabric/common/temp/projects/merge-styles.tgz
Updating /home/node/fabric/common/temp/projects/office-ui-fabric-react.tgz
Updating /home/node/fabric/common/temp/projects/pr-deploy-site.tgz
Updating /home/node/fabric/common/temp/projects/prettier-rules.tgz
Updating /home/node/fabric/common/temp/projects/server-rendered-app.tgz
Updating /home/node/fabric/common/temp/projects/set-version.tgz
Updating /home/node/fabric/common/temp/projects/ssr-tests.tgz
Updating /home/node/fabric/common/temp/projects/styling.tgz
Updating /home/node/fabric/common/temp/projects/test-bundles.tgz
Updating /home/node/fabric/common/temp/projects/test-utilities.tgz
Updating /home/node/fabric/common/temp/projects/theme-samples.tgz
Updating /home/node/fabric/common/temp/projects/todo-app.tgz
Updating /home/node/fabric/common/temp/projects/tslint-rules.tgz
Updating /home/node/fabric/common/temp/projects/utilities.tgz
Updating /home/node/fabric/common/temp/projects/variants.tgz
Updating /home/node/fabric/common/temp/projects/vr-tests.tgz
Updating /home/node/fabric/common/temp/projects/webpack-utils.tgz
Finished creating temporary modules (0.31 seconds)

Checking node_modules in /home/node/fabric/common/temp

Running "pnpm install" in /home/node/fabric/common/temp

Using hooks from: /home/node/fabric/common/temp/pnpmfile.js
readPackage hook is declared. Manifests of dependencies might get overridden
 WARN  deprecated github@7.3.2: 'github' has been renamed to '@octokit/rest' (https://git.io/vNB11)
Downloading registry.npmjs.org/ngrok/3.1.0: 5.25 MB/5.25 MB, done
Downloading registry.npmjs.org/typescript/2.8.4: 6.03 MB/6.03 MB, done
Downloading registry.npmjs.org/typescript/3.1.6: 7.45 MB/7.45 MB, done
Packages: +1864
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 WARN  Cannot link bin "jest" of "jest-cli" to "/home/node/fabric/common/temp/node_modules/.local/%2Fhome%2Fnode%2Ffabric%2Fcommon%2Ftemp%2Fprojects%2Fbuild.tgz/node_modules/@rush-temp/build/node_modules/.bin". A package called "jest" already has its bin linked.
Resolving: total 1820, reused 0, downloaded 1820, done
 WARN  Cannot link bin "jest" of "jest-cli" to "/home/node/fabric/common/temp/node_modules/.bin". A package called "jest" already has its bin linked.

registry.npmjs.org/fsevents/1.2.4        |     install$ node install
registry.npmjs.org/fsevents/1.2.4        |     install: done

registry.npmjs.org/ngrok/3.1.0           | postinstall$ node ./postinstall.js
registry.npmjs.org/ngrok/3.1.0           | postinstall: ngrok - binary downloaded to /home/node/.ngrok/aHR0cHM6Ly9iaW4uZXF1aW5veC5pby9jLzRWbUR6QTdpYUhiL25ncm9rLXN
registry.npmjs.org/ngrok/3.1.0           | postinstall: ngrok - unpacking binary
registry.npmjs.org/ngrok/3.1.0           | postinstall: ngrok - binary unpacked to /home/node/fabric/common/temp/node_modules/.registry.npmjs.org/ngrok/3.1.0/node

registry.npmjs.org/sinon/4.5.0           | postinstall$ node scripts/support-sinon.js
registry.npmjs.org/sinon/4.5.0           | postinstall: Have some ❤️ for Sinon? You can support the project via Open Collective:
registry.npmjs.org/sinon/4.5.0           | postinstall:  > https://opencollective.com/sinon/donate
registry.npmjs.org/sinon/4.5.0           | postinstall: 

registry.npmjs.org/screener-ngrok/2.2.27 | postinstall$ node ./postinstall.js
registry.npmjs.org/screener-ngrok/2.2.27 | postinstall: ngrok - unpacking binary
registry.npmjs.org/screener-ngrok/2.2.27 | postinstall: ngrok - binary unpacked to /home/node/fabric/common/temp/node_modules/.registry.npmjs.org/screener-ngrok/2

registry.npmjs.org/node-sass/4.10.0      |     install$ node scripts/install.js
registry.npmjs.org/node-sass/4.10.0      |     install: Download complete
registry.npmjs.org/node-sass/4.10.0      |     install: Binary saved to /home/node/fabric/common/temp/node_modules/.registry.npmjs.org/node-sass/4.10.0/node_modul
registry.npmjs.org/node-sass/4.10.0      |     install: Caching binary to /home/node/.npm/node-sass/4.10.0/linux-x64-64_binding.node

registry.npmjs.org/node-sass/4.10.0      | postinstall$ node scripts/build.js
registry.npmjs.org/node-sass/4.10.0      | postinstall: Binary found at /home/node/fabric/common/temp/node_modules/.registry.npmjs.org/node-sass/4.10.0/node_modul
registry.npmjs.org/node-sass/4.10.0      | postinstall: Testing binary
registry.npmjs.org/node-sass/4.10.0      | postinstall: Binary is fine

registry.npmjs.org/uglifyjs-webpack-plugin/0.4.6/webpack@3.12.0 | postinstall$ node lib/post_install.js
registry.npmjs.org/uglifyjs-webpack-plugin/0.4.6/webpack@3.12.0 | postinstall: done

dependencies:
+ @microsoft/api-extractor 6.1.6
+ @microsoft/load-themed-styles 1.8.39
+ @microsoft/loader-load-themed-styles 1.7.107
+ @rush-temp/azure-themes 0.0.0
+ @rush-temp/build 0.0.0
+ @rush-temp/charting 0.0.0
+ @rush-temp/dashboard 0.0.0
+ @rush-temp/date-time 0.0.0
+ @rush-temp/example-app-base 0.0.0
+ @rush-temp/experiments 0.0.0
+ @rush-temp/fabric-website 0.0.0
+ @rush-temp/fabric-website-resources 0.0.0
+ @rush-temp/file-type-icons 0.0.0
+ @rush-temp/fluent-theme 0.0.0
+ @rush-temp/foundation 0.0.0
+ @rush-temp/foundation-scenarios 0.0.0
+ @rush-temp/icons 0.0.0
+ @rush-temp/jest-serializer-merge-styles 0.0.0
+ @rush-temp/merge-styles 0.0.0
+ @rush-temp/office-ui-fabric-react 0.0.0
+ @rush-temp/pr-deploy-site 0.0.0
+ @rush-temp/prettier-rules 0.0.0
+ @rush-temp/server-rendered-app 0.0.0
+ @rush-temp/set-version 0.0.0
+ @rush-temp/ssr-tests 0.0.0
+ @rush-temp/styling 0.0.0
+ @rush-temp/test-bundles 0.0.0
+ @rush-temp/test-utilities 0.0.0
+ @rush-temp/theme-samples 0.0.0
+ @rush-temp/todo-app 0.0.0
+ @rush-temp/tslint-rules 0.0.0
+ @rush-temp/utilities 0.0.0
+ @rush-temp/variants 0.0.0
+ @rush-temp/vr-tests 0.0.0
+ @rush-temp/webpack-utils 0.0.0
+ @storybook/addon-options 3.2.3
+ @storybook/addons 3.4.11
+ @storybook/channels 3.4.11
+ @storybook/react 3.4.11
+ @types/d3-array 1.2.1
+ @types/d3-axis 1.0.10
+ @types/d3-scale 2.0.0
+ @types/d3-selection 1.3.0
+ @types/d3-shape 1.2.6
+ @types/d3-time-format 2.1.0
+ @types/deep-assign 0.1.1
+ @types/enzyme 3.1.13
+ @types/enzyme-adapter-react-16 1.0.3
+ @types/es6-promise 0.0.32
+ @types/glob 5.0.36
+ @types/highlight.js 9.12.2
+ @types/jest 23.0.0
+ @types/loader-utils 1.1.3
+ @types/mocha 2.2.39
+ @types/node 8.10.38
+ @types/prop-types 15.5.3
+ @types/react 16.3.16
+ @types/react-addons-test-utils 0.14.18
+ @types/react-dom 16.0.5
+ @types/react-test-renderer 16.0.3
+ @types/resemblejs 1.3.28
+ @types/sinon 2.2.2
+ @types/storybook__react 3.0.5
+ @types/webpack 4.4.0
+ @types/webpack-env 1.13.0
+ async 2.6.1
+ auto-fontsize 1.0.18
+ autoprefixer 7.2.6
+ awesome-typescript-loader 3.5.0
+ babel-core 6.26.3
+ babel-loader 7.1.5
+ babylon 7.0.0-beta.47
+ bundlesize 0.15.3
+ chalk 2.4.1
+ codecov 3.1.0
+ color-functions 1.1.0
+ command-line-args 4.0.7
+ compression 1.7.3
+ cpx 1.5.0
+ css-loader 0.28.11
+ d3-array 1.2.1
+ d3-axis 1.0.8
+ d3-scale 2.0.0
+ d3-selection 1.3.0
+ d3-shape 1.2.2
+ d3-time-format 2.1.3
+ deep-assign 2.0.0
+ enzyme 3.7.0
+ enzyme-adapter-react-16 1.7.0
+ enzyme-to-json 3.3.4
+ es6-map 0.1.5
+ es6-promise 4.2.5
+ es6-weak-map 2.0.2
+ express 4.16.4
+ file-loader 0.11.2
+ fork-ts-checker-webpack-plugin 0.4.15
+ github 7.3.2 deprecated
+ glob 7.1.3
+ gzip-size 3.0.0
+ highlight.js 9.13.1
+ immutability-helper 2.8.1
+ jest 23.6.0
+ jest-cli 23.6.0
+ jest-environment-jsdom 23.4.0
+ jest-snapshot 23.6.0
+ jju 1.4.0
+ jscodeshift 0.5.1
+ json-loader 0.5.7
+ just-task 0.7.5
+ just-task-preset 0.6.5
+ lint-staged 7.3.0
+ loader-utils 1.1.0
+ markdown-to-jsx 6.6.1
+ mkdirp 0.5.1
+ mocha 3.5.3
+ mustache 2.3.2
+ ngrok 3.1.0
+ node-sass 4.10.0
+ office-ui-fabric-core 9.6.1
+ open 0.0.5
+ postcss 6.0.23
+ postcss-loader 2.1.6
+ postcss-modules 0.8.0
+ prettier 1.15.2
+ prop-types 15.6.2
+ raf 3.4.1
+ raw-loader 0.5.1
+ react 16.6.3
+ react-dom 16.6.3
+ react-draggable 3.0.5
+ react-grid-layout 0.16.6
+ react-highlight 0.10.0
+ react-loadable 5.5.0
+ react-resizable 1.7.5
+ react-syntax-highlighter 7.0.4
+ react-test-renderer 16.6.3
+ recast 0.15.5
+ resemblejs 2.2.6
+ resolve 1.8.1
+ rimraf 2.6.2
+ rxjs 6.3.3
+ sass-loader 6.0.7
+ screener-runner 0.10.22
+ screener-storybook 0.16.2
+ sinon 4.5.0
+ source-map-loader 0.2.4
+ storybook-readme 3.3.0
+ style-loader 0.21.0
+ ts-jest 22.4.6
+ ts-loader 4.5.0
+ tslib 1.9.3
+ tslint 5.11.0
+ tslint-microsoft-contrib 5.2.1
+ tslint-react 3.6.0
+ typescript 2.8.4
+ webpack 4.7.0
+ webpack-bundle-analyzer 2.13.1
+ webpack-cli 2.1.2
+ webpack-dev-server 3.1.14
+ webpack-notifier 1.7.0
+ whatwg-fetch 2.0.4
+ write-file-webpack-plugin 4.5.0
+ yargs 6.6.0

Linking projects together...

LINKING: @uifabric/azure-themes
Purging /home/node/fabric/packages/azure-themes/node_modules

LINKING: @uifabric/build
Purging /home/node/fabric/scripts/node_modules

LINKING: @uifabric/charting
Purging /home/node/fabric/packages/charting/node_modules

LINKING: @uifabric/dashboard
Purging /home/node/fabric/packages/dashboard/node_modules

LINKING: @uifabric/date-time
Purging /home/node/fabric/packages/date-time/node_modules

LINKING: @uifabric/example-app-base
Purging /home/node/fabric/packages/example-app-base/node_modules

LINKING: @uifabric/experiments
Purging /home/node/fabric/packages/experiments/node_modules

LINKING: @uifabric/fabric-website
Purging /home/node/fabric/apps/fabric-website/node_modules

LINKING: @uifabric/fabric-website-resources
Purging /home/node/fabric/apps/fabric-website-resources/node_modules

LINKING: @uifabric/file-type-icons
Purging /home/node/fabric/packages/file-type-icons/node_modules

LINKING: @uifabric/fluent-theme
Purging /home/node/fabric/packages/fluent-theme/node_modules

LINKING: @uifabric/foundation
Purging /home/node/fabric/packages/foundation/node_modules

LINKING: @uifabric/foundation-scenarios
Purging /home/node/fabric/packages/foundation-scenarios/node_modules

LINKING: @uifabric/icons
Purging /home/node/fabric/packages/icons/node_modules

LINKING: @uifabric/jest-serializer-merge-styles
Purging /home/node/fabric/packages/jest-serializer-merge-styles/node_modules

LINKING: @uifabric/merge-styles
Purging /home/node/fabric/packages/merge-styles/node_modules

LINKING: @uifabric/pr-deploy-site
Purging /home/node/fabric/apps/pr-deploy-site/node_modules

LINKING: @uifabric/prettier-rules
Purging /home/node/fabric/packages/prettier-rules/node_modules

LINKING: @uifabric/set-version
Purging /home/node/fabric/packages/set-version/node_modules

LINKING: @uifabric/styling
Purging /home/node/fabric/packages/styling/node_modules

LINKING: @uifabric/test-utilities
Purging /home/node/fabric/packages/test-utilities/node_modules

LINKING: @uifabric/theme-samples
Purging /home/node/fabric/packages/theme-samples/node_modules

LINKING: @uifabric/tslint-rules
Purging /home/node/fabric/packages/tslint-rules/node_modules

LINKING: @uifabric/utilities
Purging /home/node/fabric/packages/utilities/node_modules

LINKING: @uifabric/variants
Purging /home/node/fabric/packages/variants/node_modules

LINKING: @uifabric/webpack-utils
Purging /home/node/fabric/packages/webpack-utils/node_modules

LINKING: office-ui-fabric-react
Purging /home/node/fabric/packages/office-ui-fabric-react/node_modules

LINKING: server-rendered-app
Purging /home/node/fabric/apps/server-rendered-app/node_modules

LINKING: ssr-tests
Purging /home/node/fabric/apps/ssr-tests/node_modules

LINKING: test-bundles
Purging /home/node/fabric/apps/test-bundles/node_modules

LINKING: todo-app
Purging /home/node/fabric/apps/todo-app/node_modules

LINKING: vr-tests
Purging /home/node/fabric/apps/vr-tests/node_modules
Writing "/home/node/fabric/common/temp/rush-link.json"

Linking finished successfully. (1.47 seconds)

Next you should probably run "rush build" or "rush rebuild"

Rush install finished successfully. (1 minute 7.9 seconds)
danmarshall commented 5 years ago

@kenotron - yes it does download. Perhaps it's a firewall issue with Node.js ??

kenotron commented 5 years ago

Some firewall issue could be related... it would be interesting to see if you can do these steps in a blank package:

mkdir testme
cd testme
npm init -y
npm i -S samiyaakhtar/react-grid-layout

My results:

node@8a8cc9938d7e:~$ mkdir testme
node@8a8cc9938d7e:~$ cd testme
node@8a8cc9938d7e:~/testme$ npm init -y
Wrote to /home/node/testme/package.json:

{
  "name": "testme",
  "version": "1.0.0",
  "description": "",
  "main": "index.js",
  "scripts": {
    "test": "echo \"Error: no test specified\" && exit 1"
  },
  "keywords": [],
  "author": "",
  "license": "ISC"
}

node@8a8cc9938d7e:~/testme$ npm i -S samiyaakhtar/react-grid-layout
npm notice created a lockfile as package-lock.json. You should commit this file.
npm WARN react-resizable@1.7.5 requires a peer of react@0.14.x || 15.x || 16.x but none is installed. You must install peer dependencies yourself.
npm WARN react-resizable@1.7.5 requires a peer of react-dom@0.14.x || 15.x || 16.x but none is installed. You must install peer dependencies yourself.
npm WARN testme@1.0.0 No description
npm WARN testme@1.0.0 No repository field.

+ react-grid-layout@0.16.6
added 9 packages from 8 contributors and audited 24 packages in 3.909s
found 0 vulnerabilities
danmarshall commented 5 years ago

The "testme" thing succeeded 👍 But still not in office-ui-fabric-react 🤷‍♂️

dzearing commented 5 years ago

@danmarshall what npm version are you on? (npm -v)

dzearing commented 5 years ago

actually nevermind, that won't matter.

We will follow up asap on this particular dependency and see what we can do. Sorry for the friction, but there's something weird here with maybe your setup, maybe firewall, but certainly the dependency is abnormal and we might be able to address that.

dzearing commented 5 years ago

@danmarshall couple questions: OS? node.js version?

I cloned a new instance this morning and had no errors installing. I'm on Mac and node.js v10.14.1

mikewheaton commented 5 years ago

I had this same error a couple weeks back. Tried everything I could think of with no luck, eventually had to remove the dashboard package from my build. Then a few days later I made a fresh clone and it worked.

dzearing commented 5 years ago

Almost certain it's either an old node.js (or possibly too new), or somehow, corrupt package cache.

I don't think firewall theory makes sense if @danmarshall was able to add that package in isolation.

danmarshall commented 5 years ago

@dzearing I'm on Windows 10, Node v10.15.0, npm 6.4.1

yumikohey commented 5 years ago

I encountered into this issue since Monday. Not able to fix yet. Windows 10, node v8.11.3 npm 4.5

yumikohey commented 5 years ago

The "testme" thing succeeded 👍 But still not in office-ui-fabric-react 🤷‍♂️

I did the same. It work in testme, but NOT in office-ui-fabric-react.

@kenotron

dzearing commented 5 years ago

Have you tried on a different computer or network? I just tried on Windows 10, Node v10.15.0 and npm 6.6.0 and installed with no issues.

dzearing commented 5 years ago

Also, is anything funny about your .npmrc? Do you have npm pointed at a private registry by default for example?

danmarshall commented 5 years ago

I don't have an .npmrc file in this clone or in my user folder. 👻

dzearing commented 5 years ago

Talked with @Raghurk offline. We will temporarily disable dashboard from rush.json, and he will separately repair the dependency. This should unblock. Let me get that rolling.

danmarshall commented 5 years ago

Tried on a different machine, and it worked without error. 🤔

yumikohey commented 5 years ago

@dzearing I tried with another laptop, it works. Windows 10, node v8.11.3 npm 4.5. Didn't have npm pointed to any private registry. It used to work.

sikrishn commented 5 years ago

I'm publishing samiyaakhtar/react-grid-layout fork to npmjs.org. Will update fabric once it is done.

dzearing commented 5 years ago

I will close down the PR to disable dashboard from rush.json, as it sounds like we've identified that the issue is machine specific, and also we have a real fix in the pipeline.

kenotron commented 5 years ago

@yumikohey and @danmarshall - can you try this on the problematic machine & repo:

rush unlink
rush install

This will clear the pnpm cache. If that works, that means pnpm was caching something bad. If it still fails, try to "nuke" everything by:

git clean -fdx

This will restore your repo back to the way it was right after you cloned, basically. If that installs fine, that means something else gummed up the installation. If THAT fails, probably means something is amiss in your npm configuration or machine - it would good to paste in your config (minus any auth token) here. Run this in your Fabric repo root:

npm config list

Paste it in a comment and maybe we can see if something is amiss.

kenotron commented 5 years ago

@yumikohey and I had been trying to get to the bottom of this. We've actually tried multiple ways of running pnpm install samiyaakhtar/react-grid-layout on an empty folder. It works! Going back to Fabric's folder and it fails. For some reason rush + pnpm + github.com dep don't mix...

danmarshall commented 5 years ago

@kenotron - ok I tried but was immediately shut down, as I don't have rush installed globally.

kenotron commented 5 years ago

I've removed the dep, @danmarshall & @yumikohey can you try again after git pull?

danmarshall commented 5 years ago

Much success! Thank you to the team for your responsiveness!

dzearing commented 5 years ago

Thank you @kenotron and @sikrishn for the help, thanks for reporting @danmarshall and @yumikohey !

msft-github-bot commented 5 years ago

:tada:This issue was addressed in #7790, which has now been successfully released as @uifabric/dashboard@v0.46.0.:tada:

Handy links: