search

microsoft / fluentui

Fluent UI web represents a collection of utilities, React components, and web components for building web applications.
https://react.fluentui.dev
Other
18.59k stars 2.75k forks source link

detailslist - accessibility labels for sortAscending, sortDescending, filter , group are not added when used onRenderColumnHeaderTooltip #8035

Closed arunarokk closed 3 years ago

arunarokk commented 5 years ago

Environment Information

Please provide a reproduction of the bug in a codepen:

Actual behavior:

accessibility labels for sortAscending, sortDescending, filter , group are not added when used onRenderColumnHeaderTooltip.

looking at the codebase https://github.com/OfficeDev/office-ui-fabric-react/blob/master/packages/office-ui-fabric-react/src/components/DetailsList/DetailsColumn.base.tsx _renderAccessibleLabel - there is check for onRenderColumnHeaderTooltip, labels are added only when this onRenderColumnHeaderTooltip doesn't available on props.

Expected behavior:

these accessibility labels should be added when used onRenderColumnHeaderTooltip

Priorities and help requested:

Are you willing to submit a PR to fix? (No)

Requested priority: ( Normal)

Products/sites affected: (Power Apps portal)

aneeshack4 commented 5 years ago

I think this is related to https://github.com/OfficeDev/office-ui-fabric-react/issues/2786.

aneeshack4 commented 5 years ago

@KevinTCoughlin This is another DetailsList issue - it looks like a dupe of #2786 because that one also talks about aria labels. Do you know why these aria labels aren't added in the case of onRenderColumnHeaderTooltip?

KevinTCoughlin commented 5 years ago

@KevinTCoughlin This is another DetailsList issue - it looks like a dupe of #2786 because that one also talks about aria labels. Do you know why these aria labels aren't added in the case of onRenderColumnHeaderTooltip?

Hrm its not clear to me how #2786 is related. @arunarokk can you clarify the ask here perhaps with the DOM markup you expect given a condition?

Is there an accessibility validation error that you can share?

cc: @natalieethell

msft-github-bot commented 5 years ago

This issue has been automatically marked as stale because it has marked as requiring author feedback but has not had any activity for 4 days. It will be closed if no further activity occurs within 3 days of this comment. Thank you for your contributions to Fabric React!

arunarokk commented 5 years ago

filterAriaLabel, sortAscendingAriaLabel,
sortDescendingAriaLabel, when we pass these aria labels on IColumn, we have these labels are created in the DOM, Ex:

Without onRenderColumnHeaderTooltip: https://codepen.io/anon/pen/yrGwKa

however, when we use the onRenderColumnHeaderTooltip used these labels are not being added to DOM. With onRenderColumnHeaderTooltip: https://codepen.io/anon/pen/YdXbQR

@aneeshack4 , please consider this and reopen this bug?

KevinTCoughlin commented 5 years ago

cc: @natalieethell @Vitalius1 @aditima we may want to consider this during List backlog review

msft-fluent-ui-bot commented 3 years ago

Because this issue has not had activity for over 150 days, we're automatically closing it for house-keeping purposes.

Still require assistance? Please, create a new issue with up-to date details.