Closed giventocode closed 6 months ago
Notes: Consider the following WRT the DRS Localizer (which is the current DRS approach
):
--vault-name
and --secret-name
. Both should be removed, along with all the configuration that drives them. See #392.--manifest-path
and requires one argument, a CSV file with two columns (Url
, Path
) and one row per input file. The file should be without headers and should follow RFC-4180 formatting.--identity-client-id
) for authorization (pass the ClientId
of the azure managed identity) which we should be setting. This means that the container running the localizer needs to not be blocked.DRS_RESOLVER_NUM_RETRIES
, DRS_RESOLVER_WAIT_INITIAL_SECONDS
, DRS_RESOLVER_WAIT_MAXIMUM_SECONDS
, DRS_RESOLVER_WAIT_MULTIPLIER
, DRS_RESOLVER_WAIT_RANDOMIZATION_FACTOR
. We should consider whether we should provide any of these, or simply continue to use the defaults.The following is provided because it is no longer showing up in the source code:
DRS files are identified via this line of code: task.Inputs.Where(f => f?.Url?.StartsWith("drs://", StringComparison.OrdinalIgnoreCase) == true)
The docker image is available in BatchScheduler
as cromwellDrsLocalizerImageName
, the resolver URL (found currently in Options.MarthaOptions.Url
) is passed double-quoted via the DRS_RESOLVER_URL
environment variable, the command-line option --access-token-strategy azure
is always provided, and the container should run with the same volume mounts options as the executor. When not using the manifest file, the Url
and Path
should be passed as command-line arguments in that same order.
Overview The TES Task Runner provides an extensibility mechanism to enable just-in-time SAS token resolution on the Batch Nodes. The goal of this story is to implement a new SAS resolution strategy when DRS URLs are provided.
AC:
DoD: