search

microsoft / ga4gh-tes

C# implementation of the GA4GH TES API; provides distributed batch task execution on Microsoft Azure
MIT License
34 stars 27 forks source link

TES internal files not configured for Terra for uploading TES runner and storing the supported-vm-sizes #275

Closed MattMcL4475 closed 1 year ago

MattMcL4475 commented 1 year ago

When in Terra, all the code that uses "defaultStorageAccountName" should use: TerraOptions.WorkspaceStorageAccountName. "TesExecutionsPathPrefix" should be set by a new property in TerraOptions, that Terra should set to a value like: "WorkspaceStorageContainerName/workspace-services/cbas/APPID/tes-internal"

  1. supported-vm-sizes

This doesn't work in Terra. Need to use defaultStorageAccountName with TesExecutionsPathPrefix

  1. https://github.com/microsoft/ga4gh-tes/blob/243a4aaa0b08fcbf7dacc366a0bdd53d633dd250/src/TesApi.Web/BatchScheduler.cs#L373

This also doesn't work in Terra for the same reason

image

BMurri commented 1 year ago

Since this makes "TesExecutionsPath" store three types of data (up from two), I'm going to add the following root directories to the tes-internals container (and, by extension, this new property):