search

microsoft / ga4gh-tes

C# implementation of the GA4GH TES API; provides distributed batch task execution on Microsoft Azure
MIT License
34 stars 27 forks source link

Add a config section to be able to define container registries (host/login/password) #40

Open MattMcL4475 opened 1 year ago

MattMcL4475 commented 1 year ago

Problem: Currently, there needs to be a way to specify container registries (Azure, Google, DockerHub, Amazon, others?) host/login/password in TES configuration.

Solution 1 :

  1. Review whether this should be added to the TES spec. Maybe add to Resources section or consider backend_parameters. Consult with @vsmalladi

Solution 2:

  1. Add a TES config section to be able to supply a list of the tuple:

"ContainerRegistryHostname", "ContainerRegistryLogin", "ContainerRegistryPassword"

  1. Validate that all properties of the tuple contain a value at startup, and throw an exception if not and TES shall not start.
  2. Consider whether there are additional properties needed to support the following container registry providers: (Azure, Google, DockerHub, Amazon, others?).
  3. TES shall parse the image name to determine whether the container credentials were provided in configuration, and if so, it shall use the provided credentials to connect.
vsmalladi commented 1 year ago

@MattMcL4475 current discussion in TES Spec: TES Issue #167