search

microsoft / ga4gh-tes

C# implementation of the GA4GH TES API; provides distributed batch task execution on Microsoft Azure
MIT License
32 stars 26 forks source link

Send expected cloudPlatform with DRS requests #708

Closed jgainerdewar closed 3 months ago

jgainerdewar commented 3 months ago

DRSHub was receiving cloudPlatform: Azure rather than cloudPlatform: azure as expected. I tried to do this in a less gross way, but it looks like support for varying enum names and JSON serialized values is not great with this library: https://github.com/dotnet/runtime/issues/74385 Happy for alternate recommendations.

jgainerdewar commented 3 months ago

@microsoft-github-policy-service agree [company="Broad Institute"]

jgainerdewar commented 3 months ago

@ agree company="Broad Institute"

BMurri commented 3 months ago

I'm making a suggestion that I will include as a PR to this PR. Expect it later today.

BMurri commented 3 months ago

@jgainerdewar here are my proposed changes: jgainerdewar/ga4gh-tes#1

BMurri commented 3 months ago

Also, I think you need to reinsert microsoft-github-policy-service between the @ and the agree...

jgainerdewar commented 3 months ago

@microsoft-github-policy-service agree company="Broad Institute"

jgainerdewar commented 3 months ago

Thanks @BMurri, this is much better! I've retested the new changes and confirmed it still works as expected.