search

microsoft / garnet

Garnet is a remote cache-store from Microsoft Research that offers strong performance (throughput and latency), scalability, storage, recovery, cluster sharding, key migration, and replication features. Garnet can work with existing Redis clients.
https://microsoft.github.io/garnet/
MIT License
10.18k stars 508 forks source link

Setting "MemorySize" has no effect on maxmemory #414

Closed MrBlaise closed 4 months ago

MrBlaise commented 4 months ago

Describe the bug

I am trying to limit the maximum memory garnet can use, however when I set it using the documented "MemorySize" I don't see it reflected when I query it using CONFIG GET maxmemory

Even though during startup I can see this line in the logs:

[000.2024-05-23 13:57:38.2895] (Information) <Options> [Store] Using log memory size of 2g

When I set it manually during runtime with CONFIG SET maxmemory 2g I immediately see it reflected as the memory usage of my instances will go down and keys will be reported evicted.

Steps to reproduce the bug

Deploy garnet like so: /garnet --config-import-path /etc/garnet/garnet.conf

garnet.conf:

{
    "MemorySize": "2g",
}

Expected behavior

The changes should be reflected in CONFIG GET maxmemory, and if the memory consumption is larger it should evict keys based on the policy instantly.

Screenshots

No response

Release version

v1.0.10 (linux x64)

IDE

No response

OS version

Debian

Additional context

No response

MrBlaise commented 4 months ago

It turns out my test machines were improperly setup and this might not actually be an issue. I will close it and reopen if I can confirm for sure. Sorry for the noise.