Fix ACL enforcement when transaction active

microsoft / garnet

Garnet is a remote cache-store from Microsoft Research that offers strong performance (throughput and latency), scalability, storage, recovery, cluster sharding, key migration, and replication features. Garnet can work with existing Redis clients.

https://microsoft.github.io/garnet/

MIT License

9.71k stars 459 forks source link

Fix ACL enforcement when transaction active #459

Closed kevin-montrose closed 2 weeks ago

kevin-montrose commented 2 weeks ago

ProcessBasicCommands is not (currently) called if a transaction is pending. This allowed commands to bypass ACLs when queuing commands.

Fixed that, which revealed a bug in the MultiACLs test (I assumed DISCARD was available if MULTI was) which is also fixed.