search

microsoft / garnet

Garnet is a remote cache-store from Microsoft Research that offers strong performance (throughput and latency), scalability, storage, recovery, cluster sharding, key migration, and replication features. Garnet can work with existing Redis clients.
https://microsoft.github.io/garnet/
MIT License
10.35k stars 522 forks source link

API: CLIENT LIST #603

Closed benh57 closed 1 month ago

benh57 commented 2 months ago

Feature request type

enhancement

Is your feature request related to a problem? Please describe

We use the 'CLIENT LIST' Redis api, and would like to use this with Garnet

Describe the solution you'd like

'CLIENT LIST' functionality, with the same response as Redis

Describe alternatives you've considered

No response

Additional context

Would it be possible to implement CLIENT LIST? It might be something we could tackle if provided some guidance as to where it would be added.

plucked commented 2 months ago

Regarding how to do it, there is a great documentation about it here: https://microsoft.github.io/garnet/docs/dev/onboarding

TalZaccai commented 2 months ago

Hi @benh57! We have docs dedicated to how to add a command to the Garnet API here. Let me know if you need anything else! Thanks for willing to contribute!

MojtabaTajik commented 2 months ago

@TalZaccai Where do we store the client's info? I can't find the storage object where clients' info is stored.

benh57 commented 2 months ago

Thanks for the pointers. I've started experimenting with adding some commands on my fork.

Vijay-Nirmal commented 1 month ago

@TalZaccai This can be closed as its already implemented as part of #620

benh57 commented 1 month ago

Glad to see this. I did start some work on my own but didn't get very far, looks like a much better implementation was put in. Thanks!