search

microsoft / garnet

Garnet is a remote cache-store from Microsoft Research that offers strong performance (throughput and latency), scalability, storage, recovery, cluster sharding, key migration, and replication features. Garnet can work with existing Redis clients.
https://microsoft.github.io/garnet/
MIT License
10.19k stars 508 forks source link

Map deprecated Redis comments to its alternative if its already exist in Garnet #684

Open Vijay-Nirmal opened 1 week ago

Vijay-Nirmal commented 1 week ago

Feature request type

sample request

Is your feature request related to a problem? Please describe

Personally, I don't like to waste our time in implementing deprecated commands. But the issue is that these deprecated Redis comments will not be removed for years before they are removed completely. This means libraries and applications could still continue to use it even it's not recommented.

Describe the solution you'd like

I like to map deprecated comments to its alternative if it's already exist in Garnet

Describe alternatives you've considered

No response

Additional context

I can raise the PR for this if the garnet team is fine with this change.

yrajas commented 1 week ago

Good point. Thanks. Please open a PR for this.

Vijay-Nirmal commented 2 days ago

@yrajas Should the deprecated command need to be added as part of IGarnetApi or can it be mapped to the alternative in the network layer (RespServerSession) itself?

yrajas commented 1 day ago

The main advantage of adding support for these older commands is primarily to expand compatibility with existing clients. So, as long as the parsing is supported and mapped to an existing command, we should be good.